Re: [PATCH v4 01/29] selftests/resctrl: Convert perror() to ksft_perror() or ksft_print_msg()

Hi Ilpo,

On 12/15/2023 7:04 AM, Ilpo Järvinen wrote:

The resctrl selftest code contains a number of perror() calls. Some of them come with hash character and some don't. The kselftest framework provides ksft_perror() that is compatible with test output formatting so it should be used instead of adding custom hash signs.

Some perror() calls are too far away from anything that sets error. For those call sites, ksft_print_msg() must be used instead.

Convert perror() to ksft_perror() or ksft_print_msg().

Other related changes:

• Remove hash signs
• Remove trailing stops & newlines from ksft_perror()
• Add terminating newlines for converted ksft_print_msg()
• Use consistent capitalization
• Small fixes/tweaks to typos & grammar of the messages
• Extract error printing out of PARENT_EXIT() to be able to differentiate

Signed-off-by: Ilpo Järvinen ilpo.jarvinen@linux.intel.com

Reviewed-by: Reinette Chatre reinette.chatre@intel.com

Reinette