From: SeongJae Park sjpark@amazon.de
Commit 87c9c1631788 ("kunit: tool: add support for QEMU") on the 'next' tree adds 'from __future__ import annotations' in 'kunit_kernel.py'. Because it is supported on only >=3.7 Python, people using older Python will get below error:
Traceback (most recent call last): File "./tools/testing/kunit/kunit.py", line 20, in <module> import kunit_kernel File "/home/sjpark/linux/tools/testing/kunit/kunit_kernel.py", line 9 from __future__ import annotations ^ SyntaxError: future feature annotations is not defined
This commit adds a version assertion in 'kunit.py', so that people get more explicit error message like below:
Traceback (most recent call last): File "./tools/testing/kunit/kunit.py", line 15, in <module> assert sys.version_info >= (3, 7), "Python version is too old" AssertionError: Python version is too old
Signed-off-by: SeongJae Park sjpark@amazon.de Acked-by: Daniel Latypov dlatypov@google.com ---
Changes from v2 - Fix mismatch of Signed-off and from
Changes from v1 - Add assertion failure message (Daniel Latypov) - Add Acked-by: Daniel Latypov dlatypov@google.com
tools/testing/kunit/kunit.py | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tools/testing/kunit/kunit.py b/tools/testing/kunit/kunit.py index be8d8d4a4e08..6276ce0c0196 100755 --- a/tools/testing/kunit/kunit.py +++ b/tools/testing/kunit/kunit.py @@ -12,6 +12,8 @@ import sys import os import time
+assert sys.version_info >= (3, 7), "Python version is too old" + from collections import namedtuple from enum import Enum, auto