Re: [PATCH] selftests/harness: pass variant to teardown

On Thu, 10 Dec 2020 18:10:10 -0500 Willem de Bruijn wrote:

From: Willem de Bruijn willemb@google.com

FIXTURE_VARIANT data is passed to FIXTURE_SETUP and TEST_F as variant.

In some cases, the variant will change the setup, such that expections also change on teardown. Also pass variant to FIXTURE_TEARDOWN.

The new FIXTURE_TEARDOWN logic is identical to that in FIXTURE_SETUP, right above.

Signed-off-by: Willem de Bruijn willemb@google.com

IDK where we want to draw the line between reusing fixtures creating separate ones, some test cases are completely skipped in the example you provide. But in principle the harness change is fine by me:

Reviewed-by: Jakub Kicinski kuba@kernel.org