Re: [PATCH v2 04/31] ntsync: Introduce NTSYNC_IOC_WAIT_ANY.

On Monday, 19 February 2024 16:38:06 CDT Elizabeth Figura wrote:

+static struct ntsync_obj *get_obj(struct ntsync_device *dev, int fd) +{

• struct file *file = fget(fd);
• struct ntsync_obj *obj;
• if (file->f_op != &ntsync_obj_fops) {

• fput(file);
  

• return NULL;
  

• }

I just noticed during self-review that this fails to check the result of fget() for NULL :-/

I'll fix this next revision.

• obj = file->private_data;
• if (obj->dev != dev) {

• fput(file);
  

• return NULL;
  

• }
• return obj;

+}