On Tue, May 7, 2019 at 8:12 AM Steven Rostedt rostedt@goodmis.org wrote:
Yes, band-aids are usually simpler than a proper fix.
What? No/.
My fix is the *proper* fix.
PeterZ's is the bandaid.
We have 28 yearsof hacks built on hacks. There's a lot of hacks in the C code to handle the differences between the crappy way x86_32 does pt_regs and the proper way x86_64 does them.
You're confusing "reality": with "your dream world". They are different.
The reality is that the i386 kernel stack is just how things work. End of story.
The reality is that changing something fundamental like the kernel stack at this point for an architecture that will not change in the future is silly.
The reality is that Peter's patch is much bigger than mine, because it needed a lot of other changes *because* it did that change.
To implement your way, we need to change how the int3 handler works. It will be the only exception handler having to return regs, otherwise it will crash.
What? That's what the patch *does*. It's trivial. It is done.
Linus