Re: [PATCH 8/9] drm/xe/tests: Fix printf format specifiers in xe_migrate test

On Wed, Feb 21, 2024 at 05:27:21PM +0800, David Gow wrote:

KUNIT_FAIL() is used to fail the xe_migrate test when an error occurs. However, there's a mismatch in the format specifier: '%li' is used to log 'err', which is an 'int'.

Use '%i' instead of '%li', and for the case where we're printing an error pointer, just use '%pe', instead of extracting the error code manually with PTR_ERR(). (This also results in a nicer output when the error code is known.)

Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs") Signed-off-by: David Gow davidgow@google.com

Tested-by: Guenter Roeck linux@roeck-us.net

---

drivers/gpu/drm/xe/tests/xe_migrate.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/tests/xe_migrate.c b/drivers/gpu/drm/xe/tests/xe_migrate.c index a6523df0f1d3..c347e2c29f81 100644 --- a/drivers/gpu/drm/xe/tests/xe_migrate.c +++ b/drivers/gpu/drm/xe/tests/xe_migrate.c @@ -114,21 +114,21 @@ static void test_copy(struct xe_migrate *m, struct xe_bo *bo, region | XE_BO_NEEDS_CPU_ACCESS); if (IS_ERR(remote)) {

• KUNIT_FAIL(test, "Failed to allocate remote bo for %s: %li\n",
  

• 	   str, PTR_ERR(remote));
  

• KUNIT_FAIL(test, "Failed to allocate remote bo for %s: %pe\n",
  

• 	   str, remote);
  

  return; }

err = xe_bo_validate(remote, NULL, false); if (err) {

• KUNIT_FAIL(test, "Failed to validate system bo for %s: %li\n",
  

• KUNIT_FAIL(test, "Failed to validate system bo for %s: %i\n",
     str, err);
  

  goto out_unlock; }

err = xe_bo_vmap(remote); if (err) {

• KUNIT_FAIL(test, "Failed to vmap system bo for %s: %li\n",
  

• KUNIT_FAIL(test, "Failed to vmap system bo for %s: %i\n",
     str, err);
  

  goto out_unlock; }

-- 2.44.0.rc0.258.g7320e95886-goog