Re: [PATCH 4/5] RISC-V: KVM: Allow Zaamo/Zalrsc extensions for Guest/VM

On Wed, Jun 19, 2024 at 9:11 PM Clément Léger cleger@rivosinc.com wrote:

Extend the KVM ISA extension ONE_REG interface to allow KVM user space to detect and enable Zaamo/Zalrsc extensions for Guest/VM.

Signed-off-by: Clément Léger cleger@rivosinc.com

LGTM.

Reviewed-by: Anup Patel anup@brainfault.org

Regards, Anup

---

arch/riscv/include/uapi/asm/kvm.h | 2 ++ arch/riscv/kvm/vcpu_onereg.c | 4 ++++ 2 files changed, 6 insertions(+)

diff --git a/arch/riscv/include/uapi/asm/kvm.h b/arch/riscv/include/uapi/asm/kvm.h index a6215634df7c..f10c6e133d4d 100644 --- a/arch/riscv/include/uapi/asm/kvm.h +++ b/arch/riscv/include/uapi/asm/kvm.h @@ -174,6 +174,8 @@ enum KVM_RISCV_ISA_EXT_ID { KVM_RISCV_ISA_EXT_ZCD, KVM_RISCV_ISA_EXT_ZCF, KVM_RISCV_ISA_EXT_ZCMOP,

•   KVM_RISCV_ISA_EXT_ZAAMO,
  

•   KVM_RISCV_ISA_EXT_ZALRSC,
    KVM_RISCV_ISA_EXT_MAX,
  

};

diff --git a/arch/riscv/kvm/vcpu_onereg.c b/arch/riscv/kvm/vcpu_onereg.c index fa5ee544bc69..0972a997beca 100644 --- a/arch/riscv/kvm/vcpu_onereg.c +++ b/arch/riscv/kvm/vcpu_onereg.c @@ -41,7 +41,9 @@ static const unsigned long kvm_isa_ext_arr[] = { KVM_ISA_EXT_ARR(SVINVAL), KVM_ISA_EXT_ARR(SVNAPOT), KVM_ISA_EXT_ARR(SVPBMT),

•   KVM_ISA_EXT_ARR(ZAAMO),
    KVM_ISA_EXT_ARR(ZACAS),
  

•   KVM_ISA_EXT_ARR(ZALRSC),
    KVM_ISA_EXT_ARR(ZBA),
    KVM_ISA_EXT_ARR(ZBB),
    KVM_ISA_EXT_ARR(ZBC),
  

@@ -131,7 +133,9 @@ static bool kvm_riscv_vcpu_isa_disable_allowed(unsigned long ext) case KVM_RISCV_ISA_EXT_SSTC: case KVM_RISCV_ISA_EXT_SVINVAL: case KVM_RISCV_ISA_EXT_SVNAPOT:

•   case KVM_RISCV_ISA_EXT_ZAAMO:
    case KVM_RISCV_ISA_EXT_ZACAS:
  

•   case KVM_RISCV_ISA_EXT_ZALRSC:
    case KVM_RISCV_ISA_EXT_ZBA:
    case KVM_RISCV_ISA_EXT_ZBB:
    case KVM_RISCV_ISA_EXT_ZBC:
  

-- 2.45.2