Re: [PATCH net-next 4/5] netconsole: resume previously deactivated target

On Wed, Sep 10, 2025 at 12:50:07PM -0700, Breno Leitao wrote:

...

• if (nt->state == STATE_DEACTIVATED && event == NETDEV_UP)  {
  

• 	if (!strncmp(nt->np.dev_name, dev->name, IFNAMSIZ))
  

Don't you need to check for dev_mac here as well?

I believe so. Will fix that and try to cover this case on the selftest too.

...

• 		schedule_work(&nt->resume_wq);
  

I would prefer to have the enablement done inline here, instead of scheduling a task.

That makes sense. I believe I'll need an alternative to netpoll_setup that can be called with rtnl already held. I'll attempt to do this for v2.

Thanks for the review!