Re: [PATCH bpf-next v2 3/6] net: remove duplicate reuseport_lookup functions

On Tue, Jun 13, 2023 at 4:33 PM Simon Horman simon.horman@corigine.com wrote:

...

+INDIRECT_CALLABLE_DECLARE(u32 udp_ehashfn(const struct net *,

•                                   const __be32, const __u16,
  

•                                   const __be32, const __be16));
  

Hi Lorenz,

Would this be better placed in a header file? GCC complains that in udp.c this function is neither static nor has a prototype.

Hi Simon,

The problem is that I don't want to pull in udp.h in inet_hashtables.c, but that is the natural place to define that function. I was hoping the macro magic would solve the problem, but oh well. How do you make gcc complain, and what is the full error message?

Thanks Lorenz