Re: [PATCH V2] selftests/vm: Add protection_keys tests to run_vmtests

On 6/14/2022 3:14 AM, Shuah Khan wrote:

On 6/10/22 3:07 AM, Kalpana Shetty wrote:

...

Adding "protected_keys" tests to "run_vmtests.sh" would help out to run all VM related tests from a single shell script.

Makes sense - can you explain why you can't just run protection_keys_32 without checks?

Yes; we can run protection_keys_32 without check.

Why are you checking for VADDR64?

The check is added to ensure if the system is in 64-bit mode before executing 64-bit binary.

All of this information helps us review the patch and give you feedback and suggest a different approach.

Thanks,

Kalpana

...

Signed-off-by: Kalpana Shetty kalpana.shetty@amd.com

Changes in V2:    * Added patch description.

thanks, -- Shuah