Re: [PATCH v2] kunit: fix failure to build without printk

On Thu, 2019-08-29 at 21:44 -0700, Joe Perches wrote:

On Thu, 2019-08-29 at 11:01 -0600, shuah wrote:

[]

...

WARNING: Prefer [subsystem eg: netdev]_level([subsystem]dev, ... then dev_level(dev, ... then pr_level(... to printk(KERN_LEVEL ... #105: FILE: include/kunit/test.h:343:

• printk(KERN_LEVEL "\t# %s: " fmt, (test)->name, ##__VA_ARGS__)

Is there supposed to be pr_level() - I can find dev_level()

btw: the checkpatch message is meant to be interpreted as

Prefer [subsystem eg: netdev]_<level>([subsystem]dev, ...) then dev_<level>(dev, ...) then pr_<level>(...), to printk(KERN_<LEVEL> ...)

btw2:

dev_level is actually not a function, but a convenience macro argument which indirects to an actual specific logging function.

So no, there is not supposed to be a pr_level.