Re: [PATCH 4/8] kselftest/arm64: mte: use string literal for printf-style functions

On Fri, Aug 16, 2024 at 04:32:47PM +0100, Andre Przywara wrote:

Using pointers for the format specifier strings in printf-style functions can create potential security problems, as the number of arguments to be parsed could vary from call to call. Most compilers consequently warn about those: "format not a string literal and no format arguments [-Wformat-security]"

If we only want to print a constant string, we can just use a fixed "%s" format instead, and pass the string as an argument.

Fixes: e9b60476bea0 ("kselftest/arm64: Add utilities and a test to validate mte memory")

I'm not sure this qualifies as a fix given that all the strings we're passing in here are trusted... otheriwse this looks good.

Reviewed-by: Mark Brown broonie@kernel.org