On Wed, Aug 14, 2024 at 12:55 PM Liam R. Howlett Liam.Howlett@oracle.com wrote:
The majority of the comments to V2 are mine, you only told us that splitting a sealed vma is wrong (after I asked you directly to answer) and then you made a comment about testing of the patch set. Besides the direct responses to me, your comment was "wait for me to test".
Please share this link for " Besides the direct responses to me, your comment was "wait for me to test". Or pop up that email by responding to it, to remind me. Thanks.
You are holding us hostage by asking for more testing but not sharing what is and is not valid for mseal() - or even answering questions on tests you run.
https://docs.kernel.org/process/submitting-patches.html#don-t-get-discourage...
These patches should be rejected in favour of fixing the feature like it should have been written in the first place.
This is not ture.
Without removing arch_unmap, it is impossible to implement in-loop. And I have mentioned this during initial discussion of mseal patch, as well as when Pedro expressed the interest on in-loop approach. If you like reference, I can find the links for you.
I'm glad that arch_unmap is removed now and resulting in much cleaner code, it has always been a question/mysterial to me ever since I read that code. Thanks to Linus's leadership and Michael Ellerman's quick response, this is now resolved.
Best regards, -Jeff