28 Feb
2019
28 Feb
'19
1:54 p.m.
On Thu, Feb 28, 2019 at 01:03:24AM -0800, Brendan Higgins wrote:
you could do:
if (IS_ERR_OR_NULL(ptr)) { KUNIT_FAIL(test, "ptr is an errno or null: %ld", ptr); return; }
It's best to not mix error pointers and NULL but when we do mix them, it means that NULL is a special kind of success. Like we try to load a feature and we get back:
valid pointer <-- success null <-- feature is disabled. not an error. error pointer <-- feature is broken. fail.
regards, dan carpenter