Re: [PATCH v6 4/6] mm/mmu_notifier: add mmu_interval_notifier_find()

On Mon, Jan 13, 2020 at 02:47:01PM -0800, Ralph Campbell wrote:

diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c index 47ad9cc89aab..4efecc0f13cb 100644 +++ b/mm/mmu_notifier.c @@ -1171,6 +1171,39 @@ void mmu_interval_notifier_update(struct mmu_interval_notifier *mni, } EXPORT_SYMBOL_GPL(mmu_interval_notifier_update); +struct mmu_interval_notifier *mmu_interval_notifier_find(struct mm_struct *mm,

• 		const struct mmu_interval_notifier_ops *ops,
  

• 		unsigned long start, unsigned long last)
  

+{

• struct mmu_notifier_mm *mmn_mm = mm->mmu_notifier_mm;
• struct interval_tree_node *node;
• struct mmu_interval_notifier *mni;
• struct mmu_interval_notifier *res = NULL;
• spin_lock(&mmn_mm->lock);
• node = interval_tree_iter_first(&mmn_mm->itree, start, last);
• if (node) {

• mni = container_of(node, struct mmu_interval_notifier,
  

• 		   interval_tree);
  

• while (true) {
  

• 	if (mni->ops == ops) {
  

• 		res = mni;
  

• 		break;
  

• 	}
  

• 	node = interval_tree_iter_next(&mni->interval_tree,
  

• 				       start, last);
  

• 	if (!node)
  

• 		break;
  

• 	mni = container_of(node, struct mmu_interval_notifier,
  

• 			   interval_tree);
  

• }
  

• }
• spin_unlock(&mmn_mm->lock);

This doesn't seem safe at all, here we are returning a pointer to memory from the interval tree with out any kind of lifetime protection.

If the interval tree is read it must be left in the read lock state until the caller is done with the pointer.

.. and this poses all sorts of questions about consistency with items on the deferred list. Should find return an item undergoing deletion?

Should find return items using the old interval tree values or their new updated values?

Jason