Re: [PATCH] selftests: icmp_redirect: pass xfail=0 to log_test() for non-xfail cases

On Wed, 8 Dec 2021 15:11:51 +0800 Po-Hsu Lin wrote:

If any sub-test in this icmp_redirect.sh is failing but not expected to fail. The script will complain: ./icmp_redirect.sh: line 72: [: 1: unary operator expected

This is because when the sub-test is not expected to fail, we won't pass any value for the xfail local variable in log_test() and thus it's empty. Fix this by passing 0 as the 4th variable to log_test() for non-xfail cases.

Signed-off-by: Po-Hsu Lin po-hsu.lin@canonical.com

Thanks, could you please add a fixes tag (even if the breakage is only present in linux-next) and CC David Ahern on v2?