25 Jun
2025
25 Jun
'25
8:08 a.m.
On Sat, Jun 21, 2025 at 12:38 PM chia-yu.chang@nokia-bell-labs.com wrote:
From: Ilpo Järvinen ij@kernel.org
Don't early return when sack doesn't fit. AccECN code will be placed after this fragment so no early returns please.
Make sure opts->num_sack_blocks is not left undefined. E.g., tcp_current_mss() does not memset its opts struct to zero. AccECN code checks if SACK option is present and may even alter it to make room for AccECN option when many SACK blocks are present. Thus, num_sack_blocks needs to be always valid.
Signed-off-by: Ilpo Järvinen ij@kernel.org Signed-off-by: Chia-Yu Chang chia-yu.chang@nokia-bell-labs.com
Reviewed-by: Eric Dumazet edumazet@google.com