Fix typos about "transmit" missing the first "s" found by searching with keyword "tram" in the first 7 patches.
Add related patterns to "scripts/spelling.txt" in the last patch.
Yueh-Shun Li (8): RDMA/rxe: fix comment typo i40e, xsk: fix comment typo zd1211rw: fix comment typo scsi: fix comment typo tcp: fix comment typo net/tls: fix comment typo selftests: mptcp: connect: fix comment typo scripts/spelling.txt: Add "transmit" patterns
drivers/infiniband/sw/rxe/rxe_verbs.h | 2 +- drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +- drivers/net/wireless/zydas/zd1211rw/zd_usb.c | 2 +- drivers/scsi/isci/scu_task_context.h | 2 +- net/ipv4/tcp_input.c | 2 +- net/tls/tls_device_fallback.c | 2 +- scripts/spelling.txt | 11 +++++++++++ tools/testing/selftests/net/mptcp/mptcp_connect.sh | 2 +- 8 files changed, 18 insertions(+), 7 deletions(-)
Spell "retransmitting" properly.
Found by searching for keyword "tranm".
Signed-off-by: Yueh-Shun Li shamrocklee@posteo.net --- drivers/infiniband/sw/rxe/rxe_verbs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h index 26a20f088692..aca0f4c7a5cd 100644 --- a/drivers/infiniband/sw/rxe/rxe_verbs.h +++ b/drivers/infiniband/sw/rxe/rxe_verbs.h @@ -237,7 +237,7 @@ struct rxe_qp { atomic_t skb_out; int need_req_skb;
- /* Timer for retranmitting packet when ACKs have been lost. RC + /* Timer for retransmitting packet when ACKs have been lost. RC * only. The requester sets it when it is not already * started. The responder resets it whenever an ack is * received.
在 2023/6/22 9:26, Yueh-Shun Li 写道:
Spell "retransmitting" properly.
Found by searching for keyword "tranm".
Signed-off-by: Yueh-Shun Li shamrocklee@posteo.net
Thanks. Reviewed-by: Zhu Yanjun yanjun.zhu@linux.dev
Zhu Yanjun
drivers/infiniband/sw/rxe/rxe_verbs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h index 26a20f088692..aca0f4c7a5cd 100644 --- a/drivers/infiniband/sw/rxe/rxe_verbs.h +++ b/drivers/infiniband/sw/rxe/rxe_verbs.h @@ -237,7 +237,7 @@ struct rxe_qp { atomic_t skb_out; int need_req_skb;
- /* Timer for retranmitting packet when ACKs have been lost. RC
- /* Timer for retransmitting packet when ACKs have been lost. RC
- only. The requester sets it when it is not already
- started. The responder resets it whenever an ack is
- received.
Spell "transmission" properly.
Found by searching for keyword "tranm".
Signed-off-by: Yueh-Shun Li shamrocklee@posteo.net --- drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c index cd7b52fb6b46..05ec1181471e 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c +++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c @@ -582,7 +582,7 @@ static void i40e_clean_xdp_tx_buffer(struct i40e_ring *tx_ring, * @vsi: Current VSI * @tx_ring: XDP Tx ring * - * Returns true if cleanup/tranmission is done. + * Returns true if cleanup/transmission is done. **/ bool i40e_clean_xdp_tx_irq(struct i40e_vsi *vsi, struct i40e_ring *tx_ring) {
Spell "transmits" properly.
Found by searching for keyword "tranm".
Signed-off-by: Yueh-Shun Li shamrocklee@posteo.net --- drivers/net/wireless/zydas/zd1211rw/zd_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_usb.c b/drivers/net/wireless/zydas/zd1211rw/zd_usb.c index 850c26bc9524..8505d84eeed6 100644 --- a/drivers/net/wireless/zydas/zd1211rw/zd_usb.c +++ b/drivers/net/wireless/zydas/zd1211rw/zd_usb.c @@ -1006,7 +1006,7 @@ static void tx_urb_complete(struct urb *urb) * @usb: the zd1211rw-private USB structure * @skb: a &struct sk_buff pointer * - * This function tranmits a frame to the device. It doesn't wait for + * This function transmits a frame to the device. It doesn't wait for * completion. The frame must contain the control set and have all the * control set information available. *
Yueh-Shun Li shamrocklee@posteo.net wrote:
Spell "transmits" properly.
Found by searching for keyword "tranm".
Signed-off-by: Yueh-Shun Li shamrocklee@posteo.net
Patch applied to wireless-next.git, thanks.
2d5947830868 wifi: zd1211rw: fix typo "tranmits"
Spell "transmitting" properly.
Found by searching for keyword "tranm".
Signed-off-by: Yueh-Shun Li shamrocklee@posteo.net --- drivers/scsi/isci/scu_task_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/isci/scu_task_context.h b/drivers/scsi/isci/scu_task_context.h index 869a979eb5b2..582d22d54689 100644 --- a/drivers/scsi/isci/scu_task_context.h +++ b/drivers/scsi/isci/scu_task_context.h @@ -845,7 +845,7 @@ struct scu_task_context {
/** * This field is used by the SCU TL to determine when to take a snapshot when - * tranmitting read data frames. + * transmitting read data frames. * - 0x00 The entire IO * - 0x01 32k * - 0x02 64k
Spell "transmissions" properly.
Found by searching for keyword "tranm".
Signed-off-by: Yueh-Shun Li shamrocklee@posteo.net --- net/ipv4/tcp_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index bf8b22218dd4..6f072095211e 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -2867,7 +2867,7 @@ static void tcp_process_loss(struct sock *sk, int flag, int num_dupack, } if (tcp_is_reno(tp)) { /* A Reno DUPACK means new data in F-RTO step 2.b above are - * delivered. Lower inflight to clock out (re)tranmissions. + * delivered. Lower inflight to clock out (re)transmissions. */ if (after(tp->snd_nxt, tp->high_seq) && num_dupack) tcp_add_reno_sack(sk, num_dupack, flag & FLAG_ECE);
Spell "retransmit" properly.
Found by searching for keyword "tranm".
Signed-off-by: Yueh-Shun Li shamrocklee@posteo.net --- net/tls/tls_device_fallback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tls/tls_device_fallback.c b/net/tls/tls_device_fallback.c index 7fbb1d0b69b3..b28c5e296dfd 100644 --- a/net/tls/tls_device_fallback.c +++ b/net/tls/tls_device_fallback.c @@ -271,7 +271,7 @@ static int fill_sg_in(struct scatterlist *sg_in, * There is a corner case where the packet contains * both an acked and a non-acked record. * We currently don't handle that case and rely - * on TCP to retranmit a packet that doesn't contain + * on TCP to retransmit a packet that doesn't contain * already acked payload. */ if (!is_start_marker)
Spell "transmissions" properly.
Found by searching for keyword "tranm".
Signed-off-by: Yueh-Shun Li shamrocklee@posteo.net --- tools/testing/selftests/net/mptcp/mptcp_connect.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/testing/selftests/net/mptcp/mptcp_connect.sh index 773dd770a567..13561e5bc0cd 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_connect.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.sh @@ -809,7 +809,7 @@ run_tests_disconnect()
cat $cin $cin $cin > "$cin".disconnect
- # force do_transfer to cope with the multiple tranmissions + # force do_transfer to cope with the multiple transmissions sin="$cin.disconnect" cin="$cin.disconnect" cin_disconnect="$old_cin"
Hi Yueh-Shun,
On 22/06/2023 03:26, Yueh-Shun Li wrote:
Spell "transmissions" properly.
Found by searching for keyword "tranm".
Signed-off-by: Yueh-Shun Li shamrocklee@posteo.net
Reviewed-by: Matthieu Baerts matthieu.baerts@tessares.net
Thanks, Matt
Add "transmit"-related patterns misspelled with the first "s" missing.
Signed-off-by: Yueh-Shun Li shamrocklee@posteo.net --- scripts/spelling.txt | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/scripts/spelling.txt b/scripts/spelling.txt index f8bd6178d17b..c81e489ba4cf 100644 --- a/scripts/spelling.txt +++ b/scripts/spelling.txt @@ -1319,6 +1319,12 @@ ressource||resource ressources||resources restesting||retesting resumbmitting||resubmitting +retranmission||retransmission +retranmissions||retransmissions +retranmit||retransmit +retranmits||retransmits +retranmitted||retransmitted +retranmitting||retransmitting retransmited||retransmitted retreived||retrieved retreive||retrieve @@ -1553,6 +1559,11 @@ tranasction||transaction tranceiver||transceiver tranfer||transfer tranmission||transmission +tranmissions||transmissions +tranmit||transmit +tranmits||transmits +tranmitted||transmitted +tranmitting||transmitting transcevier||transceiver transciever||transceiver transferd||transferred
On 6/21/23 18:26, Yueh-Shun Li wrote:
Add "transmit"-related patterns misspelled with the first "s" missing.
Signed-off-by: Yueh-Shun Li shamrocklee@posteo.net
Reviewed-by: Randy Dunlap rdunlap@infradead.org
Thanks.
scripts/spelling.txt | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/scripts/spelling.txt b/scripts/spelling.txt index f8bd6178d17b..c81e489ba4cf 100644 --- a/scripts/spelling.txt +++ b/scripts/spelling.txt @@ -1319,6 +1319,12 @@ ressource||resource ressources||resources restesting||retesting resumbmitting||resubmitting +retranmission||retransmission +retranmissions||retransmissions +retranmit||retransmit +retranmits||retransmits +retranmitted||retransmitted +retranmitting||retransmitting retransmited||retransmitted retreived||retrieved retreive||retrieve @@ -1553,6 +1559,11 @@ tranasction||transaction tranceiver||transceiver tranfer||transfer tranmission||transmission +tranmissions||transmissions +tranmit||transmit +tranmits||transmits +tranmitted||transmitted +tranmitting||transmitting transcevier||transceiver transciever||transceiver transferd||transferred
Hello:
This series was applied to netdev/net-next.git (main) by Jakub Kicinski kuba@kernel.org:
On Thu, 22 Jun 2023 01:26:21 +0000 you wrote:
Fix typos about "transmit" missing the first "s" found by searching with keyword "tram" in the first 7 patches.
Add related patterns to "scripts/spelling.txt" in the last patch.
[...]
Here is the summary with links: - [1/8] RDMA/rxe: fix comment typo (no matching commit) - [2/8] i40e, xsk: fix comment typo https://git.kernel.org/netdev/net-next/c/b028813ac973 - [3/8] zd1211rw: fix comment typo (no matching commit) - [4/8] scsi: fix comment typo (no matching commit) - [5/8] tcp: fix comment typo https://git.kernel.org/netdev/net-next/c/304b1875ba02 - [6/8] net/tls: fix comment typo https://git.kernel.org/netdev/net-next/c/a0e128ef88e4 - [7/8] selftests: mptcp: connect: fix comment typo (no matching commit) - [8/8] scripts/spelling.txt: Add "transmit" patterns (no matching commit)
You are awesome, thank you!
Dear Maintainer,
On 23.06.2023 04:50, patchwork-bot+netdevbpf@kernel.org wrote:
Hello:
This series was applied to netdev/net-next.git (main) by Jakub Kicinski kuba@kernel.org:
On Thu, 22 Jun 2023 01:26:21 +0000 you wrote:
Fix typos about "transmit" missing the first "s" found by searching with keyword "tram" in the first 7 patches.
Add related patterns to "scripts/spelling.txt" in the last patch.
[...]
Thanks for merging!
Here is the summary with links:
- [1/8] RDMA/rxe: fix comment typo (no matching commit)
- [2/8] i40e, xsk: fix comment typo https://git.kernel.org/netdev/net-next/c/b028813ac973
- [3/8] zd1211rw: fix comment typo (no matching commit)
- [4/8] scsi: fix comment typo (no matching commit)
- [5/8] tcp: fix comment typo https://git.kernel.org/netdev/net-next/c/304b1875ba02
- [6/8] net/tls: fix comment typo https://git.kernel.org/netdev/net-next/c/a0e128ef88e4
- [7/8] selftests: mptcp: connect: fix comment typo (no matching commit)
- [8/8] scripts/spelling.txt: Add "transmit" patterns (no matching commit)
You are awesome, thank you!
Should I rebase the local branch onto netdev/net-next/main and send the "no matching commit" patches again?
Best regards,
Shamrock
Hi,
On 23/06/2023 10:51, Yueh-Shun Li wrote:
Dear Maintainer,
On 23.06.2023 04:50, patchwork-bot+netdevbpf@kernel.org wrote:
Hello:
This series was applied to netdev/net-next.git (main) by Jakub Kicinski kuba@kernel.org:
On Thu, 22 Jun 2023 01:26:21 +0000 you wrote:
Fix typos about "transmit" missing the first "s" found by searching with keyword "tram" in the first 7 patches.
Add related patterns to "scripts/spelling.txt" in the last patch.
(...)
- [7/8] selftests: mptcp: connect: fix comment typo (no matching commit)
I just applied this patch 7/8 in MPTCP tree (features for net-next), no need to send it again elsewhere.
New patches for t/upstream: - ba8a625a062a: selftests: mptcp: connect: fix comment typo - Results: e16a005b0d79..f186e81ff99c (export)
- [8/8] scripts/spelling.txt: Add "transmit" patterns (no matching commit)
You are awesome, thank you!
Should I rebase the local branch onto netdev/net-next/main and send the "no matching commit" patches again?
For the other ones, you might have to send them separately to the appropriated maintainers according to the MAINTAINERS file, not all of them in the same series I guess.
Cheers, Matt
On Fri, 2023-06-23 at 08:51 +0000, Yueh-Shun Li wrote:
- [3/8] zd1211rw: fix comment typo (no matching commit)
Should I rebase the local branch onto netdev/net-next/main and send the "no matching commit" patches again?
The wireless one is on our radar, no need to resend.
But: https://lore.kernel.org/r/87y1kncuh4.fsf@kernel.org
johannes
On Fri, 23 Jun 2023 08:51:39 +0000 Yueh-Shun Li wrote:
Here is the summary with links:
- [1/8] RDMA/rxe: fix comment typo (no matching commit)
- [2/8] i40e, xsk: fix comment typo https://git.kernel.org/netdev/net-next/c/b028813ac973
- [3/8] zd1211rw: fix comment typo (no matching commit)
- [4/8] scsi: fix comment typo (no matching commit)
- [5/8] tcp: fix comment typo https://git.kernel.org/netdev/net-next/c/304b1875ba02
- [6/8] net/tls: fix comment typo https://git.kernel.org/netdev/net-next/c/a0e128ef88e4
- [7/8] selftests: mptcp: connect: fix comment typo (no matching commit)
- [8/8] scripts/spelling.txt: Add "transmit" patterns (no matching commit)
You are awesome, thank you!
Should I rebase the local branch onto netdev/net-next/main and send the "no matching commit" patches again?
No, not directly to netdev, at least..
rdma/rxe needs to go to linux-rdma i40e should be picked up by Tony (CCed, no need to repost) zd1211rw is wireless so post it to linux-wireless scsi, I don't even know off the top of my head, not networking mptcp should be picked up by MPTCP folks (CCed, no need to repost) scripts, IDK who takes that, Andrew? 🤷️
linux-kselftest-mirror@lists.linaro.org
-
Jakub Kicinski -
Johannes Berg -
Kalle Valo -
Matthieu Baerts -
patchwork-bot+netdevbpf＠kernel.org -
Randy Dunlap -
Yueh-Shun Li -
Zhu Yanjun