On Thu, Nov 09, 2017 at 04:47:15PM -0200, Breno Leitao wrote:

Hi Ram,

On Mon, Nov 06, 2017 at 12:57:36AM -0800, Ram Pai wrote:

...

@@ -206,12 +209,14 @@ void signal_handler(int signum, siginfo_t *si, void *vucontext) trapno = uctxt->uc_mcontext.gregs[REG_TRAPNO]; ip = uctxt->uc_mcontext.gregs[REG_IP_IDX];

• fpregset = uctxt->uc_mcontext.fpregs;
• fpregs = (void *)fpregset;

Since you removed all references for fpregset now, you probably want to remove the declaration of the variable above.

fpregs is still needed.

...

@@ -219,20 +224,21 @@ void signal_handler(int signum, siginfo_t *si, void *vucontext) * state. We just assume that it is here. */ fpregs += 0x70; -#endif

• pkey_reg_offset = pkey_reg_xstate_offset();

With this code, you removed all the reference for variable pkey_reg_offset, thus, its declaration could be removed also.

yes. will fix it.

...

• *(u64 *)pkey_reg_ptr = 0x00000000;

• dprintf1("si_pkey from siginfo: %lx\n", si_pkey);

+#if defined(__i386__) || defined(__x86_64__) /* arch */

• dprintf1("signal pkey_reg from xsave: %016lx\n", *pkey_reg_ptr);
• *(u64 *)pkey_reg_ptr &= reset_bits(si_pkey, PKEY_DISABLE_ACCESS);

+#elif __powerpc64__

Since the variable pkey_reg_ptr is only used for Intel code (inside #ifdefs), you probably want to #ifdef the variable declaration also, avoid triggering "unused variable" warning on non-Intel machines.

yes. Actually it will trigger the warning on intel machines. Fixed it.

Thanks Breno! RP

-- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html