This patchset includes two small fixes for the tests that were introduced in commit 1bb58d2d3cbe ("Merge branch 'Mirroring-tests-involving-VLAN'").
In patch #1, a "tc action trap" is uninstalled after the suite runs, instead of being installed again.
In patch #2, a test in suite is renamed to differentiate it from another test of the same name.
Petr Machata (2): selftests: forwarding: mirror_vlan: Uninstall trap selftests: forwarding: mirror_vlan: Change test description
tools/testing/selftests/net/forwarding/mirror_vlan.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Instead of installing a trap before tests run and uninstalling it after they run, mirror_vlan.sh installs it twice due to a typo. Fix the typo.
Signed-off-by: Petr Machata petrm@mellanox.com --- tools/testing/selftests/net/forwarding/mirror_vlan.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/forwarding/mirror_vlan.sh b/tools/testing/selftests/net/forwarding/mirror_vlan.sh index 1e10520..c22e949 100755 --- a/tools/testing/selftests/net/forwarding/mirror_vlan.sh +++ b/tools/testing/selftests/net/forwarding/mirror_vlan.sh @@ -146,7 +146,7 @@ test_all()
tests_run
- trap_install $h3 ingress + trap_uninstall $h3 ingress slow_path_trap_uninstall $swp1 egress slow_path_trap_uninstall $swp1 ingress }
The test description is displayed with the PASS/FAIL resolution after the test is ran. There however already is one other test described exactly like this, which makes it unclear which of the tests passed or failed. Make the description unique.
Signed-off-by: Petr Machata petrm@mellanox.com --- tools/testing/selftests/net/forwarding/mirror_vlan.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/forwarding/mirror_vlan.sh b/tools/testing/selftests/net/forwarding/mirror_vlan.sh index c22e949..efade19 100755 --- a/tools/testing/selftests/net/forwarding/mirror_vlan.sh +++ b/tools/testing/selftests/net/forwarding/mirror_vlan.sh @@ -129,7 +129,7 @@ test_tagged_vlan_dir() 192.0.2.17 192.0.2.18 mirror_uninstall $swp1 $direction
- log_test "$direction mirror to vlan ($tcflags)" + log_test "$direction mirror tagged to vlan ($tcflags)" }
test_tagged_vlan()
From: Petr Machata petrm@mellanox.com Date: Fri, 01 Jun 2018 00:37:29 +0200
This patchset includes two small fixes for the tests that were introduced in commit 1bb58d2d3cbe ("Merge branch 'Mirroring-tests-involving-VLAN'").
In patch #1, a "tc action trap" is uninstalled after the suite runs, instead of being installed again.
In patch #2, a test in suite is renamed to differentiate it from another test of the same name.
Series applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
linux-kselftest-mirror@lists.linaro.org
-
David Miller -
Petr Machata