On Mon, 27 Apr 2020 21:21:41 +0200 Veronika Kabatova vkabatov@redhat.com wrote:
The gen_kselftest_tar.sh always packages *all* selftests and doesn't pass along any variables to `make install` to influence what should be built. This can result in an early error on the command line ("Unknown tarball format TARGETS=XXX"), or unexpected test failures as the tarball contains tests people wanted to skip on purpose.
Since the makefile already contains all the logic, we can add a target for packaging. Keep the default .gz target the script uses, and actually extend the supported formats by using tar's autodetection.
To not break current workflows, keep the gen_kselftest_tar.sh script as it is, with an added suggestion to use the makefile target instead.
Signed-off-by: Veronika Kabatova vkabatov@redhat.com
Reviewed-by: Stefano Brivio sbrivio@redhat.com
Hi Veronika,
On 4/27/20 1:24 PM, Stefano Brivio wrote:
On Mon, 27 Apr 2020 21:21:41 +0200 Veronika Kabatova vkabatov@redhat.com wrote:
The gen_kselftest_tar.sh always packages *all* selftests and doesn't pass along any variables to `make install` to influence what should be built. This can result in an early error on the command line ("Unknown tarball format TARGETS=XXX"), or unexpected test failures as the tarball contains tests people wanted to skip on purpose.
Since the makefile already contains all the logic, we can add a target for packaging. Keep the default .gz target the script uses, and actually extend the supported formats by using tar's autodetection.
To not break current workflows, keep the gen_kselftest_tar.sh script as it is, with an added suggestion to use the makefile target instead.
Signed-off-by: Veronika Kabatova vkabatov@redhat.com
Reviewed-by: Stefano Brivio sbrivio@redhat.com
I don't see this in my Inbox. Please include everybody get_maintainers script tells you to do.
You can add the Reviewed-by: Stefano Brivio sbrivio@redhat.com to the patch when you resend it.
thanks, -- Shuah
On Mon, 27 Apr 2020 18:17:27 -0600 shuah shuah@kernel.org wrote:
I don't see this in my Inbox. Please include everybody get_maintainers script tells you to do.
Strange, the copy I have has you in To: and linux-kselftest in Cc:, and yet it's not even on linux-kselftest archives. :( It looks like some MTA issue on our side...
----- Original Message -----
From: "shuah" shuah@kernel.org To: "Stefano Brivio" sbrivio@redhat.com, "Veronika Kabatova" vkabatov@redhat.com Cc: linux-kselftest@vger.kernel.org, "shuah" shuah@kernel.org Sent: Tuesday, April 28, 2020 2:17:27 AM Subject: Re: [PATCH] selftests: introduce gen_tar Makefile target
Hi Veronika,
On 4/27/20 1:24 PM, Stefano Brivio wrote:
On Mon, 27 Apr 2020 21:21:41 +0200 Veronika Kabatova vkabatov@redhat.com wrote:
The gen_kselftest_tar.sh always packages *all* selftests and doesn't pass along any variables to `make install` to influence what should be built. This can result in an early error on the command line ("Unknown tarball format TARGETS=XXX"), or unexpected test failures as the tarball contains tests people wanted to skip on purpose.
Since the makefile already contains all the logic, we can add a target for packaging. Keep the default .gz target the script uses, and actually extend the supported formats by using tar's autodetection.
To not break current workflows, keep the gen_kselftest_tar.sh script as it is, with an added suggestion to use the makefile target instead.
Signed-off-by: Veronika Kabatova vkabatov@redhat.com
Reviewed-by: Stefano Brivio sbrivio@redhat.com
I don't see this in my Inbox. Please include everybody get_maintainers script tells you to do.
You can add the Reviewed-by: Stefano Brivio sbrivio@redhat.com to the patch when you resend it.
Hi Shuah,
apologies for the complications. As Stefano said, I did indeed include you and the list in the recipients, but it looks like either a setup of our internal smtp server or my git setup refuses to send the emails out to some external recipients. Funnily enough, sending the email to my private account works fine.
I resent the patch from my private account and I can see it on the list now, please let me know there are any issues with the copy in your inbox.
Veronika
thanks, -- Shuah
linux-kselftest-mirror@lists.linaro.org
-
shuah -
Stefano Brivio -
Veronika Kabatova