May 2024 - Linux-stable-mirror

[PATCH AUTOSEL 6.1 1/9] md: Fix overflow in is_mddev_idle

by Sasha Levin

From: Li Nan <linan122(a)huawei.com> [ Upstream commit 3f9f231236ce7e48780d8a4f1f8cb9fae2df1e4e ] UBSAN reports this problem: UBSAN: Undefined behaviour in drivers/md/md.c:8175:15 signed integer overflow: -2147483291 - 2072033152 cannot be represented in type 'int' Call trace: dump_backtrace+0x0/0x310 show_stack+0x28/0x38 dump_stack+0xec/0x15c ubsan_epilogue+0x18/0x84 handle_overflow+0x14c/0x19c __ubsan_handle_sub_overflow+0x34/0x44 is_mddev_idle+0x338/0x3d8 md_do_sync+0x1bb8/0x1cf8 md_thread+0x220/0x288 kthread+0x1d8/0x1e0 ret_from_fork+0x10/0x18 'curr_events' will overflow when stat accum or 'sync_io' is greater than INT_MAX. Fix it by changing sync_io, last_events and curr_events to 64bit. Signed-off-by: Li Nan <linan122(a)huawei.com> Reviewed-by: Yu Kuai <yukuai3(a)huawei.com> Link: https://lore.kernel.org/r/20240117031946.2324519-2-linan666@huaweicloud.com Signed-off-by: Song Liu <song(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/md/md.c | 7 ++++--- drivers/md/md.h | 4 ++-- include/linux/blkdev.h | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index 788acc81e7a84..7b7c048e2670a 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -8541,14 +8541,15 @@ static int is_mddev_idle(struct mddev *mddev, int init) { struct md_rdev *rdev; int idle; - int curr_events; + long long curr_events; idle = 1; rcu_read_lock(); rdev_for_each_rcu(rdev, mddev) { struct gendisk *disk = rdev->bdev->bd_disk; - curr_events = (int)part_stat_read_accum(disk->part0, sectors) - - atomic_read(&disk->sync_io); + curr_events = + (long long)part_stat_read_accum(disk->part0, sectors) - + atomic64_read(&disk->sync_io); /* sync IO will cause sync_io to increase before the disk_stats * as sync_io is counted when a request starts, and * disk_stats is counted when it completes. diff --git a/drivers/md/md.h b/drivers/md/md.h index 4f0b480974552..5910527514db2 100644 --- a/drivers/md/md.h +++ b/drivers/md/md.h @@ -50,7 +50,7 @@ struct md_rdev { sector_t sectors; /* Device size (in 512bytes sectors) */ struct mddev *mddev; /* RAID array if running */ - int last_events; /* IO event timestamp */ + long long last_events; /* IO event timestamp */ /* * If meta_bdev is non-NULL, it means that a separate device is @@ -576,7 +576,7 @@ extern void mddev_unlock(struct mddev *mddev); static inline void md_sync_acct(struct block_device *bdev, unsigned long nr_sectors) { - atomic_add(nr_sectors, &bdev->bd_disk->sync_io); + atomic64_add(nr_sectors, &bdev->bd_disk->sync_io); } static inline void md_sync_acct_bio(struct bio *bio, unsigned long nr_sectors) diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index e255674a9ee72..02e55676e0283 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -161,7 +161,7 @@ struct gendisk { struct list_head slave_bdevs; #endif struct timer_rand_state *random; - atomic_t sync_io; /* RAID */ + atomic64_t sync_io; /* RAID */ struct disk_events *ev; #ifdef CONFIG_BLK_DEV_INTEGRITY struct kobject integrity_kobj; -- 2.43.0

1 year, 1 month

1
8
0 0

[PATCH AUTOSEL 6.6 01/11] fs/writeback: bail out if there is no more inodes for IO and queued once

by Sasha Levin

From: Kemeng Shi <shikemeng(a)huaweicloud.com> [ Upstream commit d92109891f21cf367caa2cc6dff11a4411d917f4 ] For case there is no more inodes for IO in io list from last wb_writeback, We may bail out early even there is inode in dirty list should be written back. Only bail out when we queued once to avoid missing dirtied inode. This is from code reading... Signed-off-by: Kemeng Shi <shikemeng(a)huaweicloud.com> Link: https://lore.kernel.org/r/20240228091958.288260-3-shikemeng@huaweicloud.com Reviewed-by: Jan Kara <jack(a)suse.cz> [brauner(a)kernel.org: fold in memory corruption fix from Jan in [1]] Link: https://lore.kernel.org/r/20240405132346.bid7gibby3lxxhez@quack3 [1] Signed-off-by: Christian Brauner <brauner(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- fs/fs-writeback.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 1767493dffda7..0a498bc60f557 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -2044,6 +2044,7 @@ static long wb_writeback(struct bdi_writeback *wb, struct inode *inode; long progress; struct blk_plug plug; + bool queued = false; blk_start_plug(&plug); for (;;) { @@ -2086,8 +2087,10 @@ static long wb_writeback(struct bdi_writeback *wb, dirtied_before = jiffies; trace_writeback_start(wb, work); - if (list_empty(&wb->b_io)) + if (list_empty(&wb->b_io)) { queue_io(wb, work, dirtied_before); + queued = true; + } if (work->sb) progress = writeback_sb_inodes(work->sb, wb, work); else @@ -2102,7 +2105,7 @@ static long wb_writeback(struct bdi_writeback *wb, * mean the overall work is done. So we keep looping as long * as made some progress on cleaning pages or inodes. */ - if (progress) { + if (progress || !queued) { spin_unlock(&wb->list_lock); continue; } -- 2.43.0

1 year, 1 month

1
10
0 0

[PATCH AUTOSEL 6.8 01/14] fs/writeback: bail out if there is no more inodes for IO and queued once

by Sasha Levin

From: Kemeng Shi <shikemeng(a)huaweicloud.com> [ Upstream commit d92109891f21cf367caa2cc6dff11a4411d917f4 ] For case there is no more inodes for IO in io list from last wb_writeback, We may bail out early even there is inode in dirty list should be written back. Only bail out when we queued once to avoid missing dirtied inode. This is from code reading... Signed-off-by: Kemeng Shi <shikemeng(a)huaweicloud.com> Link: https://lore.kernel.org/r/20240228091958.288260-3-shikemeng@huaweicloud.com Reviewed-by: Jan Kara <jack(a)suse.cz> [brauner(a)kernel.org: fold in memory corruption fix from Jan in [1]] Link: https://lore.kernel.org/r/20240405132346.bid7gibby3lxxhez@quack3 [1] Signed-off-by: Christian Brauner <brauner(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- fs/fs-writeback.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 3d84fcc471c60..e89222ae285e9 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -2044,6 +2044,7 @@ static long wb_writeback(struct bdi_writeback *wb, struct inode *inode; long progress; struct blk_plug plug; + bool queued = false; blk_start_plug(&plug); for (;;) { @@ -2086,8 +2087,10 @@ static long wb_writeback(struct bdi_writeback *wb, dirtied_before = jiffies; trace_writeback_start(wb, work); - if (list_empty(&wb->b_io)) + if (list_empty(&wb->b_io)) { queue_io(wb, work, dirtied_before); + queued = true; + } if (work->sb) progress = writeback_sb_inodes(work->sb, wb, work); else @@ -2102,7 +2105,7 @@ static long wb_writeback(struct bdi_writeback *wb, * mean the overall work is done. So we keep looping as long * as made some progress on cleaning pages or inodes. */ - if (progress) { + if (progress || !queued) { spin_unlock(&wb->list_lock); continue; } -- 2.43.0

1 year, 1 month

1
13
0 0

[PATCH] iio: invensense: fix odr switching to same value

by inv.git-commit＠tdk.com

From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol(a)tdk.com> ODR switching happens in 2 steps, update to store the new value and then apply when the ODR change flag is received in the data. When switching to the same ODR value, the ODR change flag is never happening, and frequency switching is blocked waiting for the never coming apply. Fix the issue by preventing update to happen when switching to same ODR value. Fixes: 0ecc363ccea7 ("iio: make invensense timestamp module generic") Cc: stable(a)vger.kernel.org Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol(a)tdk.com> --- drivers/iio/common/inv_sensors/inv_sensors_timestamp.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/iio/common/inv_sensors/inv_sensors_timestamp.c b/drivers/iio/common/inv_sensors/inv_sensors_timestamp.c index fa205f17bd90..f44458c380d9 100644 --- a/drivers/iio/common/inv_sensors/inv_sensors_timestamp.c +++ b/drivers/iio/common/inv_sensors/inv_sensors_timestamp.c @@ -60,11 +60,15 @@ EXPORT_SYMBOL_NS_GPL(inv_sensors_timestamp_init, IIO_INV_SENSORS_TIMESTAMP); int inv_sensors_timestamp_update_odr(struct inv_sensors_timestamp *ts, uint32_t period, bool fifo) { + uint32_t mult; + /* when FIFO is on, prevent odr change if one is already pending */ if (fifo && ts->new_mult != 0) return -EAGAIN; - ts->new_mult = period / ts->chip.clock_period; + mult = period / ts->chip.clock_period; + if (mult != ts->mult) + ts->new_mult = mult; return 0; } -- 2.34.1

1 year, 1 month

2
1
0 0

[PATCH 6.9 00/25] 6.9.2-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.9.2 release. There are 25 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 25 May 2024 13:03:15 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.9.2-rc1.… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.9.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 6.9.2-rc1 Christoph Hellwig <hch(a)lst.de> block: add a partscan sysfs attribute for disks Christoph Hellwig <hch(a)lst.de> block: add a disk_has_partscan helper SeongJae Park <sj(a)kernel.org> Docs/admin-guide/mm/damon/usage: fix wrong schemes effective quota update command SeongJae Park <sj(a)kernel.org> Docs/admin-guide/mm/damon/usage: fix wrong example of DAMOS filter matching sysfs file Akira Yokosawa <akiyks(a)gmail.com> docs: kernel_include.py: Cope with docutils 0.21 Thomas Weißschuh <linux(a)weissschuh.net> admin-guide/hw-vuln/core-scheduling: fix return type of PR_SCHED_CORE_GET Jarkko Sakkinen <jarkko(a)kernel.org> KEYS: trusted: Do not use WARN when encode fails Hans Verkuil <hverkuil-cisco(a)xs4all.nl> Revert "media: v4l2-ctrls: show all owned controls in log_status" AngeloGioacchino Del Regno <angelogioacchino.delregno(a)collabora.com> remoteproc: mediatek: Make sure IPI buffer fits in L2TCM Daniel Thompson <daniel.thompson(a)linaro.org> serial: kgdboc: Fix NMI-safety problems from keyboard reset code Javier Carrasco <javier.carrasco(a)wolfvision.net> usb: typec: tipd: fix event checking for tps6598x Javier Carrasco <javier.carrasco(a)wolfvision.net> usb: typec: tipd: fix event checking for tps25750 Heikki Krogerus <heikki.krogerus(a)linux.intel.com> usb: typec: ucsi: displayport: Fix potential deadlock Jose Ignacio Tornos Martinez <jtornosm(a)redhat.com> net: usb: ax88179_178a: fix link status when link is set to down/up Prashanth K <quic_prashk(a)quicinc.com> usb: dwc3: Wait unconditionally after issuing EndXfer command Carlos Llamas <cmllamas(a)google.com> binder: fix max_thread type inconsistency Bard Liao <yung-chuan.liao(a)linux.intel.com> ASoC: Intel: sof_sdw: use generic rtd_init function for Realtek SDW DMICs Jarkko Sakkinen <jarkko(a)kernel.org> KEYS: trusted: Fix memory leak in tpm2_key_encode() Sungwoo Kim <iam(a)sung-woo.kim> Bluetooth: L2CAP: Fix div-by-zero in l2cap_le_flowctl_init() Uros Bizjak <ubizjak(a)gmail.com> x86/percpu: Use __force to cast from __percpu address space Ronald Wahl <ronald.wahl(a)raritan.com> net: ks8851: Fix another TX stall caused by wrong ISR flag handling Jose Fernandez <josef(a)netflix.com> drm/amd/display: Fix division by zero in setup_dsc_config Perry Yuan <perry.yuan(a)amd.com> cpufreq: amd-pstate: fix the highest frequency issue which limits performance Ben Greear <greearb(a)candelatech.com> wifi: iwlwifi: Use request_module_nowait Peter Tsao <peter.tsao(a)mediatek.com> Bluetooth: btusb: Fix the patch for MT7920 the affected to MT7921 ------------- Diffstat: Documentation/ABI/stable/sysfs-block | 10 +++ .../admin-guide/hw-vuln/core-scheduling.rst | 4 +- Documentation/admin-guide/mm/damon/usage.rst | 6 +- Documentation/sphinx/kernel_include.py | 1 - Makefile | 4 +- arch/x86/include/asm/percpu.h | 6 +- block/genhd.c | 15 +++-- block/partitions/core.c | 5 +- drivers/android/binder.c | 2 +- drivers/android/binder_internal.h | 2 +- drivers/bluetooth/btusb.c | 1 + drivers/cpufreq/amd-pstate.c | 22 ++++++- drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 7 +- drivers/media/v4l2-core/v4l2-ctrls-core.c | 18 ++---- drivers/net/ethernet/micrel/ks8851_common.c | 18 +----- drivers/net/usb/ax88179_178a.c | 37 +++++++---- drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 10 +-- drivers/remoteproc/mtk_scp.c | 10 ++- drivers/tty/serial/kgdboc.c | 30 ++++++++- drivers/usb/dwc3/gadget.c | 4 +- drivers/usb/typec/tipd/core.c | 51 ++++++++++----- drivers/usb/typec/tipd/tps6598x.h | 11 ++++ drivers/usb/typec/ucsi/displayport.c | 4 -- include/linux/blkdev.h | 13 ++++ include/net/bluetooth/hci.h | 9 +++ include/net/bluetooth/hci_core.h | 1 + net/bluetooth/hci_conn.c | 75 +++++++++++++++------- net/bluetooth/hci_event.c | 31 +++++---- net/bluetooth/iso.c | 2 +- net/bluetooth/l2cap_core.c | 17 +---- net/bluetooth/sco.c | 6 +- security/keys/trusted-keys/trusted_tpm2.c | 25 ++++++-- sound/soc/intel/boards/Makefile | 1 + sound/soc/intel/boards/sof_sdw.c | 12 ++-- sound/soc/intel/boards/sof_sdw_common.h | 1 + sound/soc/intel/boards/sof_sdw_rt_dmic.c | 52 +++++++++++++++ 36 files changed, 357 insertions(+), 166 deletions(-)

1 year, 1 month

13
39
0 0

[PATCH 6.6 000/102] 6.6.32-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.6.32 release. There are 102 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 25 May 2024 13:03:15 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.32-rc1… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 6.6.32-rc1 Christoph Hellwig <hch(a)lst.de> block: add a partscan sysfs attribute for disks Christoph Hellwig <hch(a)lst.de> block: add a disk_has_partscan helper SeongJae Park <sj(a)kernel.org> Docs/admin-guide/mm/damon/usage: fix wrong example of DAMOS filter matching sysfs file Akira Yokosawa <akiyks(a)gmail.com> docs: kernel_include.py: Cope with docutils 0.21 Thomas Weißschuh <linux(a)weissschuh.net> admin-guide/hw-vuln/core-scheduling: fix return type of PR_SCHED_CORE_GET Jarkko Sakkinen <jarkko(a)kernel.org> KEYS: trusted: Do not use WARN when encode fails AngeloGioacchino Del Regno <angelogioacchino.delregno(a)collabora.com> remoteproc: mediatek: Make sure IPI buffer fits in L2TCM Daniel Thompson <daniel.thompson(a)linaro.org> serial: kgdboc: Fix NMI-safety problems from keyboard reset code Javier Carrasco <javier.carrasco(a)wolfvision.net> usb: typec: tipd: fix event checking for tps6598x Heikki Krogerus <heikki.krogerus(a)linux.intel.com> usb: typec: ucsi: displayport: Fix potential deadlock Jose Ignacio Tornos Martinez <jtornosm(a)redhat.com> net: usb: ax88179_178a: fix link status when link is set to down/up Prashanth K <quic_prashk(a)quicinc.com> usb: dwc3: Wait unconditionally after issuing EndXfer command Carlos Llamas <cmllamas(a)google.com> binder: fix max_thread type inconsistency Srinivasan Shanmugam <srinivasan.shanmugam(a)amd.com> drm/amdgpu: Fix possible NULL dereference in amdgpu_ras_query_error_status_helper() Christian Brauner <brauner(a)kernel.org> erofs: reliably distinguish block based and fscache mode Baokun Li <libaokun1(a)huawei.com> erofs: get rid of erofs_fs_context Jiri Olsa <jolsa(a)kernel.org> bpf: Add missing BPF_LINK_TYPE invocations Mark Brown <broonie(a)kernel.org> kselftest: Add a ksft_perror() helper Mengqi Zhang <mengqi.zhang(a)mediatek.com> mmc: core: Add HS400 tuning in HS400es initialization Jarkko Sakkinen <jarkko(a)kernel.org> KEYS: trusted: Fix memory leak in tpm2_key_encode() Sungwoo Kim <iam(a)sung-woo.kim> Bluetooth: L2CAP: Fix div-by-zero in l2cap_le_flowctl_init() Sungwoo Kim <iam(a)sung-woo.kim> Bluetooth: L2CAP: Fix slab-use-after-free in l2cap_connect() Jacob Keller <jacob.e.keller(a)intel.com> ice: remove unnecessary duplicate checks for VF VSI ID Jacob Keller <jacob.e.keller(a)intel.com> ice: pass VSI pointer into ice_vc_isvalid_q_id Ronald Wahl <ronald.wahl(a)raritan.com> net: ks8851: Fix another TX stall caused by wrong ISR flag handling Jose Fernandez <josef(a)netflix.com> drm/amd/display: Fix division by zero in setup_dsc_config Gustavo A. R. Silva <gustavoars(a)kernel.org> smb: smb2pdu.h: Avoid -Wflex-array-member-not-at-end warnings Namjae Jeon <linkinjeon(a)kernel.org> ksmbd: add continuous availability share parameter David Howells <dhowells(a)redhat.com> cifs: Add tracing for the cifs_tcon struct refcounting Paulo Alcantara <pc(a)manguebit.com> smb: client: instantiate when creating SFU files Paulo Alcantara <pc(a)manguebit.com> smb: client: fix NULL ptr deref in cifs_mark_open_handles_for_deleted_file() Steve French <stfrench(a)microsoft.com> smb3: add trace event for mknod Steve French <stfrench(a)microsoft.com> smb311: additional compression flag defined in updated protocol spec Steve French <stfrench(a)microsoft.com> smb311: correct incorrect offset field in compression header Steve French <stfrench(a)microsoft.com> cifs: Move some extern decls from .c files to .h Namjae Jeon <linkinjeon(a)kernel.org> ksmbd: fix potencial out-of-bounds when buffer offset is invalid Namjae Jeon <linkinjeon(a)kernel.org> ksmbd: fix slab-out-of-bounds in smb_strndup_from_utf16() Colin Ian King <colin.i.king(a)gmail.com> ksmbd: Fix spelling mistake "connction" -> "connection" Marios Makassikis <mmakassikis(a)freebox.fr> ksmbd: fix possible null-deref in smb_lazy_parent_lease_break_close Bharath SM <bharathsm(a)microsoft.com> cifs: remove redundant variable assignment Meetakshi Setiya <msetiya(a)microsoft.com> cifs: fixes for get_inode_info Bharath SM <bharathsm(a)microsoft.com> cifs: defer close file handles having RH lease Namjae Jeon <linkinjeon(a)kernel.org> ksmbd: add support for durable handles v1/v2 Namjae Jeon <linkinjeon(a)kernel.org> ksmbd: mark SMB2_SESSION_EXPIRED to session when destroying previous session Enzo Matsumiya <ematsumiya(a)suse.de> smb: common: simplify compression headers Enzo Matsumiya <ematsumiya(a)suse.de> smb: common: fix fields sizes in compression_pattern_payload_v1 Enzo Matsumiya <ematsumiya(a)suse.de> smb: client: negotiate compression algorithms Steve French <stfrench(a)microsoft.com> smb3: add dynamic trace point for ioctls Paulo Alcantara <pc(a)manguebit.com> smb: client: return reparse type in /proc/mounts Paulo Alcantara <pc(a)manguebit.com> smb: client: set correct d_type for reparse DFS/DFSR and mount point Paulo Alcantara <pc(a)manguebit.com> smb: client: parse uid, gid, mode and dev from WSL reparse points Steve French <stfrench(a)microsoft.com> smb: client: introduce SMB2_OP_QUERY_WSL_EA Dan Carpenter <dan.carpenter(a)linaro.org> smb: client: Fix a NULL vs IS_ERR() check in wsl_set_xattrs() Paulo Alcantara <pc(a)manguebit.com> smb: client: add support for WSL reparse points Paulo Alcantara <pc(a)manguebit.com> smb: client: reduce number of parameters in smb2_compound_op() Paulo Alcantara <pc(a)manguebit.com> smb: client: fix potential broken compound request Paulo Alcantara <pc(a)manguebit.com> smb: client: move most of reparse point handling code to common file Paulo Alcantara <pc(a)manguebit.com> smb: client: introduce reparse mount option Meetakshi Setiya <msetiya(a)microsoft.com> smb: client: retry compound request without reusing lease Steve French <stfrench(a)microsoft.com> smb: client: do not defer close open handles to deleted files Meetakshi Setiya <msetiya(a)microsoft.com> smb: client: reuse file lease key in compound operations Paulo Alcantara <pc(a)manguebit.com> smb: client: get rid of smb311_posix_query_path_info() Steve French <stfrench(a)microsoft.com> smb: client: parse owner/group when creating reparse points Steve French <stfrench(a)microsoft.com> smb3: update allocation size more accurately on write completion Paulo Alcantara <pc(a)manguebit.com> smb: client: handle path separator of created SMB symlinks Steve French <stfrench(a)microsoft.com> cifs: update the same create_guid on replay Yang Li <yang.lee(a)linux.alibaba.com> ksmbd: Add kernel-doc for ksmbd_extract_sharename() function Shyam Prasad N <sprasad(a)microsoft.com> cifs: set replay flag for retries of write command Shyam Prasad N <sprasad(a)microsoft.com> cifs: commands that are retried should have replay flag set Alexey Dobriyan <adobriyan(a)gmail.com> smb: client: delete "true", "false" defines Yang Li <yang.lee(a)linux.alibaba.com> smb: Fix some kernel-doc comments Shyam Prasad N <sprasad(a)microsoft.com> cifs: new mount option called retrans Paulo Alcantara <pc(a)manguebit.com> smb: client: don't clobber ->i_rdev from cached reparse points Shyam Prasad N <sprasad(a)microsoft.com> cifs: new nt status codes from MS-SMB2 Shyam Prasad N <sprasad(a)microsoft.com> cifs: pick channel for tcon and tdis Steve French <stfrench(a)microsoft.com> cifs: minor comment cleanup Colin Ian King <colin.i.king(a)gmail.com> cifs: remove redundant variable tcon_exist Randy Dunlap <rdunlap(a)infradead.org> ksmbd: vfs: fix all kernel-doc warnings Randy Dunlap <rdunlap(a)infradead.org> ksmbd: auth: fix most kernel-doc warnings Steve French <stfrench(a)microsoft.com> cifs: remove unneeded return statement Paulo Alcantara <pc(a)manguebit.com> cifs: get rid of dup length check in parse_reparse_point() David Howells <dhowells(a)redhat.com> cifs: Pass unbyteswapped eof value into SMB2_set_eof() Markus Elfring <elfring(a)users.sourceforge.net> smb3: Improve exception handling in allocate_mr_list() Steve French <stfrench(a)microsoft.com> cifs: fix in logging in cifs_chan_update_iface Paulo Alcantara <pc(a)manguebit.com> smb: client: handle special files and symlinks in SMB3 POSIX Paulo Alcantara <pc(a)manguebit.com> smb: client: cleanup smb2_query_reparse_point() Paulo Alcantara <pc(a)manguebit.com> smb: client: allow creating symlinks via reparse points Steve French <stfrench(a)microsoft.com> smb: client: optimise reparse point querying Steve French <stfrench(a)microsoft.com> smb: client: allow creating special files via reparse points Steve French <stfrench(a)microsoft.com> smb: client: extend smb2_compound_op() to accept more commands Pierre Mariani <pierre.mariani(a)gmail.com> smb: client: Fix minor whitespace errors and warnings Steve French <stfrench(a)microsoft.com> smb: client: introduce cifs_sfu_make_node() Ritvik Budhiraja <rbudhiraja(a)microsoft.com> cifs: fix use after free for iface while disabling secondary channels Steve French <stfrench(a)microsoft.com> Missing field not being returned in ioctl CIFS_IOC_GET_MNT_INFO Steve French <stfrench(a)microsoft.com> smb3: minor cleanup of session handling code Steve French <stfrench(a)microsoft.com> smb3: more minor cleanups for session handling routines Steve French <stfrench(a)microsoft.com> smb3: minor RDMA cleanup Shyam Prasad N <sprasad(a)microsoft.com> cifs: print server capabilities in DebugData Eric Biggers <ebiggers(a)google.com> smb: use crypto_shash_digest() in symlink_hash() Steve French <stfrench(a)microsoft.com> Add definition for new smb3.1.1 command type Steve French <stfrench(a)microsoft.com> SMB3: clarify some of the unused CreateOption flags Meetakshi Setiya <msetiya(a)microsoft.com> cifs: Add client version details to NTLM authenticate message ------------- Diffstat: Documentation/ABI/stable/sysfs-block | 10 + .../admin-guide/hw-vuln/core-scheduling.rst | 4 +- Documentation/admin-guide/mm/damon/usage.rst | 2 +- Documentation/sphinx/kernel_include.py | 1 - Makefile | 4 +- block/genhd.c | 15 +- block/partitions/core.c | 5 +- drivers/android/binder.c | 2 +- drivers/android/binder_internal.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 + drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 7 +- drivers/mmc/core/mmc.c | 9 +- drivers/net/ethernet/intel/ice/ice_virtchnl.c | 22 +- drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c | 3 - drivers/net/ethernet/micrel/ks8851_common.c | 18 +- drivers/net/usb/ax88179_178a.c | 37 +- drivers/remoteproc/mtk_scp.c | 10 +- drivers/tty/serial/kgdboc.c | 30 +- drivers/usb/dwc3/gadget.c | 4 +- drivers/usb/typec/tipd/core.c | 45 +- drivers/usb/typec/tipd/tps6598x.h | 11 + drivers/usb/typec/ucsi/displayport.c | 4 - fs/erofs/internal.h | 7 - fs/erofs/super.c | 124 +- fs/smb/client/Makefile | 2 +- fs/smb/client/cached_dir.c | 24 +- fs/smb/client/cifs_debug.c | 38 +- fs/smb/client/cifsfs.c | 10 +- fs/smb/client/cifsglob.h | 93 +- fs/smb/client/cifsproto.h | 39 +- fs/smb/client/cifssmb.c | 18 +- fs/smb/client/connect.c | 57 +- fs/smb/client/dir.c | 14 +- fs/smb/client/file.c | 39 +- fs/smb/client/fs_context.c | 43 +- fs/smb/client/fs_context.h | 13 +- fs/smb/client/fscache.c | 7 + fs/smb/client/inode.c | 235 ++-- fs/smb/client/ioctl.c | 6 + fs/smb/client/link.c | 41 +- fs/smb/client/misc.c | 47 +- fs/smb/client/ntlmssp.h | 4 +- fs/smb/client/readdir.c | 32 +- fs/smb/client/reparse.c | 532 ++++++++ fs/smb/client/reparse.h | 113 ++ fs/smb/client/sess.c | 73 +- fs/smb/client/smb1ops.c | 80 +- fs/smb/client/smb2glob.h | 27 +- fs/smb/client/smb2inode.c | 1402 +++++++++++++------- fs/smb/client/smb2maperror.c | 2 + fs/smb/client/smb2misc.c | 10 +- fs/smb/client/smb2ops.c | 603 ++++----- fs/smb/client/smb2pdu.c | 340 ++++- fs/smb/client/smb2pdu.h | 46 +- fs/smb/client/smb2proto.h | 37 +- fs/smb/client/smb2status.h | 2 + fs/smb/client/smb2transport.c | 2 + fs/smb/client/smbdirect.c | 4 +- fs/smb/client/smbencrypt.c | 7 - fs/smb/client/trace.h | 137 +- fs/smb/common/smb2pdu.h | 122 +- fs/smb/common/smbfsctl.h | 6 - fs/smb/server/auth.c | 14 +- fs/smb/server/ksmbd_netlink.h | 36 +- fs/smb/server/mgmt/user_session.c | 28 +- fs/smb/server/mgmt/user_session.h | 3 + fs/smb/server/misc.c | 1 + fs/smb/server/oplock.c | 96 +- fs/smb/server/oplock.h | 7 +- fs/smb/server/smb2misc.c | 26 +- fs/smb/server/smb2ops.c | 6 + fs/smb/server/smb2pdu.c | 338 ++++- fs/smb/server/smb2pdu.h | 31 +- fs/smb/server/transport_tcp.c | 2 + fs/smb/server/vfs.c | 28 +- fs/smb/server/vfs_cache.c | 137 +- fs/smb/server/vfs_cache.h | 9 + include/linux/blkdev.h | 13 + include/linux/bpf_types.h | 3 + include/net/bluetooth/hci.h | 9 + include/net/bluetooth/hci_core.h | 1 + net/bluetooth/hci_conn.c | 71 +- net/bluetooth/hci_event.c | 31 +- net/bluetooth/iso.c | 2 +- net/bluetooth/l2cap_core.c | 38 +- net/bluetooth/sco.c | 6 +- security/keys/trusted-keys/trusted_tpm2.c | 25 +- tools/testing/selftests/kselftest.h | 14 + 88 files changed, 3923 insertions(+), 1738 deletions(-)

1 year, 1 month

12
113
0 0

[PATCH 6.1 00/45] 6.1.92-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.92 release. There are 45 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 25 May 2024 13:03:15 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.92-rc1… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 6.1.92-rc1 Akira Yokosawa <akiyks(a)gmail.com> docs: kernel_include.py: Cope with docutils 0.21 Thomas Weißschuh <linux(a)weissschuh.net> admin-guide/hw-vuln/core-scheduling: fix return type of PR_SCHED_CORE_GET Jarkko Sakkinen <jarkko(a)kernel.org> KEYS: trusted: Do not use WARN when encode fails AngeloGioacchino Del Regno <angelogioacchino.delregno(a)collabora.com> remoteproc: mediatek: Make sure IPI buffer fits in L2TCM Daniel Thompson <daniel.thompson(a)linaro.org> serial: kgdboc: Fix NMI-safety problems from keyboard reset code Javier Carrasco <javier.carrasco(a)wolfvision.net> usb: typec: tipd: fix event checking for tps6598x Heikki Krogerus <heikki.krogerus(a)linux.intel.com> usb: typec: ucsi: displayport: Fix potential deadlock Jose Ignacio Tornos Martinez <jtornosm(a)redhat.com> net: usb: ax88179_178a: fix link status when link is set to down/up Prashanth K <quic_prashk(a)quicinc.com> usb: dwc3: Wait unconditionally after issuing EndXfer command Carlos Llamas <cmllamas(a)google.com> binder: fix max_thread type inconsistency Srinivasan Shanmugam <srinivasan.shanmugam(a)amd.com> drm/amdgpu: Fix possible NULL dereference in amdgpu_ras_query_error_status_helper() Mark Rutland <mark.rutland(a)arm.com> arm64: atomics: lse: remove stale dependency on JUMP_LABEL Eric Sandeen <sandeen(a)redhat.com> xfs: short circuit xfs_growfs_data_private() if delta is zero Hironori Shiina <shiina.hironori(a)gmail.com> xfs: get root inode correctly at bulkstat Darrick J. Wong <djwong(a)kernel.org> xfs: fix log recovery when unknown rocompat bits are set Darrick J. Wong <djwong(a)kernel.org> xfs: allow inode inactivation during a ro mount log recovery Darrick J. Wong <djwong(a)kernel.org> xfs: invalidate xfs_bufs when allocating cow extents Darrick J. Wong <djwong(a)kernel.org> xfs: estimate post-merge refcounts correctly Darrick J. Wong <djwong(a)kernel.org> xfs: hoist refcount record merge predicates Guo Xuenan <guoxuenan(a)huawei.com> xfs: fix super block buf log item UAF during force shutdown Guo Xuenan <guoxuenan(a)huawei.com> xfs: wait iclog complete before tearing down AIL Darrick J. Wong <djwong(a)kernel.org> xfs: attach dquots to inode before reading data/cow fork mappings Darrick J. Wong <djwong(a)kernel.org> xfs: invalidate block device page cache during unmount Long Li <leo.lilong(a)huawei.com> xfs: fix incorrect i_nlink caused by inode racing Long Li <leo.lilong(a)huawei.com> xfs: fix sb write verify for lazysbcount Darrick J. Wong <djwong(a)kernel.org> xfs: fix incorrect error-out in xfs_remove Dave Chinner <dchinner(a)redhat.com> xfs: fix off-by-one-block in xfs_discard_folio() Dave Chinner <dchinner(a)redhat.com> xfs: drop write error injection is unfixable, remove it Dave Chinner <dchinner(a)redhat.com> xfs: use iomap_valid method to detect stale cached iomaps Dave Chinner <dchinner(a)redhat.com> iomap: write iomap validity checks Dave Chinner <dchinner(a)redhat.com> xfs: xfs_bmap_punch_delalloc_range() should take a byte range Dave Chinner <dchinner(a)redhat.com> iomap: buffered write failure should not truncate the page cache Dave Chinner <dchinner(a)redhat.com> xfs,iomap: move delalloc punching to iomap Dave Chinner <dchinner(a)redhat.com> xfs: use byte ranges for write cleanup ranges Dave Chinner <dchinner(a)redhat.com> xfs: punching delalloc extents on write failure is racy Dave Chinner <dchinner(a)redhat.com> xfs: write page faults in iomap are not buffered writes Mengqi Zhang <mengqi.zhang(a)mediatek.com> mmc: core: Add HS400 tuning in HS400es initialization Jarkko Sakkinen <jarkko(a)kernel.org> KEYS: trusted: Fix memory leak in tpm2_key_encode() NeilBrown <neilb(a)suse.de> nfsd: don't allow nfsd threads to be signalled. Aidan MacDonald <aidanmacdonald.0x0(a)gmail.com> mfd: stpmic1: Fix swapped mask/unmask in irq chip Sergey Shtylyov <s.shtylyov(a)omp.ru> pinctrl: core: handle radix_tree_insert() errors in pinctrl_register_one_pin() Jacob Keller <jacob.e.keller(a)intel.com> ice: remove unnecessary duplicate checks for VF VSI ID Jacob Keller <jacob.e.keller(a)intel.com> ice: pass VSI pointer into ice_vc_isvalid_q_id Ronald Wahl <ronald.wahl(a)raritan.com> net: ks8851: Fix another TX stall caused by wrong ISR flag handling Jose Fernandez <josef(a)netflix.com> drm/amd/display: Fix division by zero in setup_dsc_config ------------- Diffstat: .../admin-guide/hw-vuln/core-scheduling.rst | 4 +- Documentation/sphinx/kernel_include.py | 1 - Makefile | 4 +- arch/arm64/Kconfig | 1 - arch/arm64/include/asm/lse.h | 1 - drivers/android/binder.c | 2 +- drivers/android/binder_internal.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 + drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 7 +- drivers/mfd/stpmic1.c | 5 +- drivers/mmc/core/mmc.c | 9 +- drivers/net/ethernet/intel/ice/ice_virtchnl.c | 22 +- drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c | 3 - drivers/net/ethernet/micrel/ks8851_common.c | 18 +- drivers/net/usb/ax88179_178a.c | 37 ++- drivers/pinctrl/core.c | 14 +- drivers/remoteproc/mtk_scp.c | 10 +- drivers/tty/serial/kgdboc.c | 30 ++- drivers/usb/dwc3/gadget.c | 4 +- drivers/usb/typec/tipd/core.c | 45 ++-- drivers/usb/typec/tipd/tps6598x.h | 11 + drivers/usb/typec/ucsi/displayport.c | 4 - fs/iomap/buffered-io.c | 254 ++++++++++++++++++++- fs/iomap/iter.c | 19 +- fs/nfs/callback.c | 9 +- fs/nfsd/nfs4proc.c | 5 +- fs/nfsd/nfssvc.c | 12 - fs/xfs/libxfs/xfs_bmap.c | 8 +- fs/xfs/libxfs/xfs_errortag.h | 12 +- fs/xfs/libxfs/xfs_refcount.c | 146 ++++++++++-- fs/xfs/libxfs/xfs_sb.c | 7 +- fs/xfs/xfs_aops.c | 37 +-- fs/xfs/xfs_bmap_util.c | 10 +- fs/xfs/xfs_bmap_util.h | 2 +- fs/xfs/xfs_buf.c | 1 + fs/xfs/xfs_buf_item.c | 2 + fs/xfs/xfs_error.c | 27 ++- fs/xfs/xfs_file.c | 2 +- fs/xfs/xfs_fsops.c | 4 + fs/xfs/xfs_icache.c | 6 + fs/xfs/xfs_inode.c | 16 +- fs/xfs/xfs_ioctl.c | 4 +- fs/xfs/xfs_iomap.c | 177 ++++++++------ fs/xfs/xfs_iomap.h | 6 +- fs/xfs/xfs_log.c | 53 ++--- fs/xfs/xfs_mount.c | 15 ++ fs/xfs/xfs_pnfs.c | 6 +- include/linux/iomap.h | 47 +++- net/sunrpc/svc_xprt.c | 16 +- security/keys/trusted-keys/trusted_tpm2.c | 25 +- 50 files changed, 866 insertions(+), 299 deletions(-)

1 year, 1 month

12
56
0 0

[PATCH 6.8 00/23] 6.8.11-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.8.11 release. There are 23 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 25 May 2024 13:03:15 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.8.11-rc1… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.8.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 6.8.11-rc1 Christoph Hellwig <hch(a)lst.de> block: add a partscan sysfs attribute for disks Christoph Hellwig <hch(a)lst.de> block: add a disk_has_partscan helper SeongJae Park <sj(a)kernel.org> Docs/admin-guide/mm/damon/usage: fix wrong example of DAMOS filter matching sysfs file Akira Yokosawa <akiyks(a)gmail.com> docs: kernel_include.py: Cope with docutils 0.21 Thomas Weißschuh <linux(a)weissschuh.net> admin-guide/hw-vuln/core-scheduling: fix return type of PR_SCHED_CORE_GET Jarkko Sakkinen <jarkko(a)kernel.org> KEYS: trusted: Do not use WARN when encode fails AngeloGioacchino Del Regno <angelogioacchino.delregno(a)collabora.com> remoteproc: mediatek: Make sure IPI buffer fits in L2TCM Daniel Thompson <daniel.thompson(a)linaro.org> serial: kgdboc: Fix NMI-safety problems from keyboard reset code Javier Carrasco <javier.carrasco(a)wolfvision.net> usb: typec: tipd: fix event checking for tps6598x Javier Carrasco <javier.carrasco(a)wolfvision.net> usb: typec: tipd: fix event checking for tps25750 Heikki Krogerus <heikki.krogerus(a)linux.intel.com> usb: typec: ucsi: displayport: Fix potential deadlock Jose Ignacio Tornos Martinez <jtornosm(a)redhat.com> net: usb: ax88179_178a: fix link status when link is set to down/up Prashanth K <quic_prashk(a)quicinc.com> usb: dwc3: Wait unconditionally after issuing EndXfer command Carlos Llamas <cmllamas(a)google.com> binder: fix max_thread type inconsistency Christian Brauner <brauner(a)kernel.org> erofs: reliably distinguish block based and fscache mode Baokun Li <libaokun1(a)huawei.com> erofs: get rid of erofs_fs_context Jarkko Sakkinen <jarkko(a)kernel.org> KEYS: trusted: Fix memory leak in tpm2_key_encode() Sungwoo Kim <iam(a)sung-woo.kim> Bluetooth: L2CAP: Fix div-by-zero in l2cap_le_flowctl_init() Sungwoo Kim <iam(a)sung-woo.kim> Bluetooth: L2CAP: Fix slab-use-after-free in l2cap_connect() Jacob Keller <jacob.e.keller(a)intel.com> ice: remove unnecessary duplicate checks for VF VSI ID Jacob Keller <jacob.e.keller(a)intel.com> ice: pass VSI pointer into ice_vc_isvalid_q_id Ronald Wahl <ronald.wahl(a)raritan.com> net: ks8851: Fix another TX stall caused by wrong ISR flag handling Jose Fernandez <josef(a)netflix.com> drm/amd/display: Fix division by zero in setup_dsc_config ------------- Diffstat: Documentation/ABI/stable/sysfs-block | 10 ++ .../admin-guide/hw-vuln/core-scheduling.rst | 4 +- Documentation/admin-guide/mm/damon/usage.rst | 2 +- Documentation/sphinx/kernel_include.py | 1 - Makefile | 4 +- block/genhd.c | 15 ++- block/partitions/core.c | 5 +- drivers/android/binder.c | 2 +- drivers/android/binder_internal.h | 2 +- drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 7 +- drivers/net/ethernet/intel/ice/ice_virtchnl.c | 22 ++-- drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c | 3 - drivers/net/ethernet/micrel/ks8851_common.c | 18 +-- drivers/net/usb/ax88179_178a.c | 37 ++++-- drivers/remoteproc/mtk_scp.c | 10 +- drivers/tty/serial/kgdboc.c | 30 ++++- drivers/usb/dwc3/gadget.c | 4 +- drivers/usb/typec/tipd/core.c | 51 ++++++--- drivers/usb/typec/tipd/tps6598x.h | 11 ++ drivers/usb/typec/ucsi/displayport.c | 4 - fs/erofs/internal.h | 7 -- fs/erofs/super.c | 124 +++++++++------------ include/linux/blkdev.h | 13 +++ include/net/bluetooth/hci.h | 9 ++ include/net/bluetooth/hci_core.h | 1 + net/bluetooth/hci_conn.c | 71 ++++++++---- net/bluetooth/hci_event.c | 31 ++++-- net/bluetooth/iso.c | 2 +- net/bluetooth/l2cap_core.c | 38 +++---- net/bluetooth/sco.c | 6 +- security/keys/trusted-keys/trusted_tpm2.c | 25 ++++- 31 files changed, 339 insertions(+), 230 deletions(-)

1 year, 1 month

11
33
0 0

[PATCH] selftest: mm: Test if hugepage does not get leaked during __bio_release_pages()

by Donet Tom

Commit 1b151e2435fc ("block: Remove special-casing of compound pages") caused a change in behaviour when releasing the pages if the buffer does not start at the beginning of the page. This was because the calculation of the number of pages to release was incorrect. This was fixed by commit 38b43539d64b ("block: Fix page refcounts for unaligned buffers in __bio_release_pages()"). We pin the user buffer during direct I/O writes. If this buffer is a hugepage, bio_release_page() will unpin it and decrement all references and pin counts at ->bi_end_io. However, if any references to the hugepage remain post-I/O, the hugepage will not be freed upon unmap, leading to a memory leak. This patch verifies that a hugepage, used as a user buffer for DIO operations, is correctly freed upon unmapping, regardless of whether the offsets are aligned or unaligned w.r.t page boundary. Test Result Fail Scenario (Without the fix) -------------------------------------------------------- []# ./hugetlb_dio TAP version 13 1..4 No. Free pages before allocation : 7 No. Free pages after munmap : 7 ok 1 : Huge pages freed successfully ! No. Free pages before allocation : 7 No. Free pages after munmap : 7 ok 2 : Huge pages freed successfully ! No. Free pages before allocation : 7 No. Free pages after munmap : 7 ok 3 : Huge pages freed successfully ! No. Free pages before allocation : 7 No. Free pages after munmap : 6 not ok 4 : Huge pages not freed! Totals: pass:3 fail:1 xfail:0 xpass:0 skip:0 error:0 Test Result PASS Scenario (With the fix) --------------------------------------------------------- []#./hugetlb_dio TAP version 13 1..4 No. Free pages before allocation : 7 No. Free pages after munmap : 7 ok 1 : Huge pages freed successfully ! No. Free pages before allocation : 7 No. Free pages after munmap : 7 ok 2 : Huge pages freed successfully ! No. Free pages before allocation : 7 No. Free pages after munmap : 7 ok 3 : Huge pages freed successfully ! No. Free pages before allocation : 7 No. Free pages after munmap : 7 ok 4 : Huge pages freed successfully ! Totals: pass:4 fail:0 xfail:0 xpass:0 skip:0 error:0 Signed-off-by: Donet Tom <donettom(a)linux.ibm.com> Signed-off-by: Ritesh Harjani (IBM) <ritesh.list(a)gmail.com> --- tools/testing/selftests/mm/Makefile | 1 + tools/testing/selftests/mm/hugetlb_dio.c | 118 +++++++++++++++++++++++ 2 files changed, 119 insertions(+) create mode 100644 tools/testing/selftests/mm/hugetlb_dio.c diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile index eb5f39a2668b..87d8130b3376 100644 --- a/tools/testing/selftests/mm/Makefile +++ b/tools/testing/selftests/mm/Makefile @@ -71,6 +71,7 @@ TEST_GEN_FILES += ksm_functional_tests TEST_GEN_FILES += mdwe_test TEST_GEN_FILES += hugetlb_fault_after_madv TEST_GEN_FILES += hugetlb_madv_vs_map +TEST_GEN_FILES += hugetlb_dio ifneq ($(ARCH),arm64) TEST_GEN_FILES += soft-dirty diff --git a/tools/testing/selftests/mm/hugetlb_dio.c b/tools/testing/selftests/mm/hugetlb_dio.c new file mode 100644 index 000000000000..6f6587c7913c --- /dev/null +++ b/tools/testing/selftests/mm/hugetlb_dio.c @@ -0,0 +1,118 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * This program tests for hugepage leaks after DIO writes to a file using a + * hugepage as the user buffer. During DIO, the user buffer is pinned and + * should be properly unpinned upon completion. This patch verifies that the + * kernel correctly unpins the buffer at DIO completion for both aligned and + * unaligned user buffer offsets (w.r.t page boundary), ensuring the hugepage + * is freed upon unmapping. + */ + +#define _GNU_SOURCE +#include <stdio.h> +#include <sys/stat.h> +#include <stdlib.h> +#include <fcntl.h> +#include <stdint.h> +#include <unistd.h> +#include <string.h> +#include <sys/mman.h> +#include "vm_util.h" +#include "../kselftest.h" + +void run_dio_using_hugetlb(unsigned int start_off, unsigned int end_off) +{ + int fd; + char *buffer = NULL; + char *orig_buffer = NULL; + size_t h_pagesize = 0; + size_t writesize; + int free_hpage_b = 0; + int free_hpage_a = 0; + + writesize = end_off - start_off; + + /* Get the default huge page size */ + h_pagesize = default_huge_page_size(); + if (!h_pagesize) + ksft_exit_fail_msg("Unable to determine huge page size\n"); + + /* Open the file to DIO */ + fd = open("/tmp", O_TMPFILE | O_RDWR | O_DIRECT); + if (fd < 0) + ksft_exit_fail_msg("Error opening file"); + + /* Get the free huge pages before allocation */ + free_hpage_b = get_free_hugepages(); + if (free_hpage_b == 0) { + close(fd); + ksft_exit_skip("No free hugepage, exiting!\n"); + } + + /* Allocate a hugetlb page */ + orig_buffer = mmap(NULL, h_pagesize, PROT_READ | PROT_WRITE, MAP_PRIVATE + | MAP_ANONYMOUS | MAP_HUGETLB, -1, 0); + if (orig_buffer == MAP_FAILED) { + close(fd); + ksft_exit_fail_msg("Error mapping memory"); + } + buffer = orig_buffer; + buffer += start_off; + + memset(buffer, 'A', writesize); + + /* Write the buffer to the file */ + if (write(fd, buffer, writesize) != (writesize)) { + munmap(orig_buffer, h_pagesize); + close(fd); + ksft_exit_fail_msg("Error writing to file"); + } + + /* unmap the huge page */ + munmap(orig_buffer, h_pagesize); + close(fd); + + /* Get the free huge pages after unmap*/ + free_hpage_a = get_free_hugepages(); + + /* + * If the no. of free hugepages before allocation and after unmap does + * not match - that means there could still be a page which is pinned. + */ + if (free_hpage_a != free_hpage_b) { + printf("No. Free pages before allocation : %d\n", free_hpage_b); + printf("No. Free pages after munmap : %d\n", free_hpage_a); + ksft_test_result_fail(": Huge pages not freed!\n"); + } else { + printf("No. Free pages before allocation : %d\n", free_hpage_b); + printf("No. Free pages after munmap : %d\n", free_hpage_a); + ksft_test_result_pass(": Huge pages freed successfully !\n"); + } +} + +int main(void) +{ + size_t pagesize = 0; + + ksft_print_header(); + ksft_set_plan(4); + + /* Get base page size */ + pagesize = psize(); + + /* start and end is aligned to pagesize */ + run_dio_using_hugetlb(0, (pagesize * 3)); + + /* start is aligned but end is not aligned */ + run_dio_using_hugetlb(0, (pagesize * 3) - (pagesize / 2)); + + /* start is unaligned and end is aligned */ + run_dio_using_hugetlb(pagesize / 2, (pagesize * 3)); + + /* both start and end are unaligned */ + run_dio_using_hugetlb(pagesize / 2, (pagesize * 3) + (pagesize / 2)); + + ksft_finished(); + return 0; +} + -- 2.39.3

1 year, 1 month

5
7
0 0

FAILED: patch "[PATCH] io_uring: fail NOP if non-zero op flags is passed in" failed to apply to 5.10-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 3d8f874bd620ce03f75a5512847586828ab86544 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2024052548-prance-gliding-4f31@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 3d8f874bd620ce03f75a5512847586828ab86544 Mon Sep 17 00:00:00 2001 From: Ming Lei <ming.lei(a)redhat.com> Date: Fri, 10 May 2024 11:50:27 +0800 Subject: [PATCH] io_uring: fail NOP if non-zero op flags is passed in The NOP op flags should have been checked from beginning like any other opcode, otherwise NOP may not be extended with the op flags. Given both liburing and Rust io-uring crate always zeros SQE op flags, just ignore users which play raw NOP uring interface without zeroing SQE, because NOP is just for test purpose. Then we can save one NOP2 opcode. Suggested-by: Jens Axboe <axboe(a)kernel.dk> Fixes: 2b188cc1bb85 ("Add io_uring IO interface") Cc: stable(a)vger.kernel.org Signed-off-by: Ming Lei <ming.lei(a)redhat.com> Link: https://lore.kernel.org/r/20240510035031.78874-2-ming.lei@redhat.com Signed-off-by: Jens Axboe <axboe(a)kernel.dk> diff --git a/io_uring/nop.c b/io_uring/nop.c index d956599a3c1b..1a4e312dfe51 100644 --- a/io_uring/nop.c +++ b/io_uring/nop.c @@ -12,6 +12,8 @@ int io_nop_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) { + if (READ_ONCE(sqe->rw_flags)) + return -EINVAL; return 0; }

1 year, 1 month

2
1
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror May 2024