- Linux-stable-mirror - lists.linaro.org

[PATCH 03/22] ext4: Do not iput inode under running transaction in ext4_mkdir()

by Jan Kara

When ext4_mkdir() fails to add entry into directory, it ends up dropping freshly created inode under the running transaction and thus inode truncation happens under that transaction. That breaks assumptions that ext4_evict_inode() does not get called from a transaction context (although I'm not aware of any real issue) and is completely unnecessary. Just stop the transaction before dropping inode reference. CC: stable(a)vger.kernel.org Signed-off-by: Jan Kara <jack(a)suse.cz> --- fs/ext4/namei.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index a427d2031a8d..9c872a33aea7 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -2781,8 +2781,9 @@ static int ext4_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) clear_nlink(inode); unlock_new_inode(inode); ext4_mark_inode_dirty(handle, inode); + ext4_journal_stop(handle); iput(inode); - goto out_stop; + goto out_retry; } ext4_inc_count(handle, dir); ext4_update_dx_flag(dir); @@ -2796,6 +2797,7 @@ static int ext4_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) out_stop: if (handle) ext4_journal_stop(handle); +out_retry: if (err == -ENOSPC && ext4_should_retry_alloc(dir->i_sb, &retries)) goto retry; return err; -- 2.16.4

6 years

2
5
0 0

❌ FAIL: Stable queue: queue-5.3

by CKI Project

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 95180e47e77a - Linux 5.3.8 The results of these automated tests are provided below. Overall result: FAILED (see details below) Merge: OK Compile: OK Tests: FAILED All kernel binaries, config files, and logs are available for download here: https://artifacts.cki-project.org/pipelines/262247 One or more kernel tests failed: x86_64: ❌ Loopdev Sanity ❌ jvm test suite We hope that these logs can help you find the problem quickly. For the full detail on our testing procedures, please scroll to the bottom of this message. Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out the following commit: Repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 95180e47e77a - Linux 5.3.8 We grabbed the 666f5bdad6bc commit of the stable queue repository. We then merged the patchset with `git am`: io_uring-fix-up-o_nonblock-handling-for-sockets.patch dm-snapshot-introduce-account_start_copy-and-account.patch dm-snapshot-rework-cow-throttling-to-fix-deadlock.patch btrfs-fix-inode-cache-block-reserve-leak-on-failure-.patch btrfs-qgroup-always-free-prealloc-meta-reserve-in-bt.patch iio-adc-meson_saradc-fix-memory-allocation-order.patch iio-fix-center-temperature-of-bmc150-accel-core.patch libsubcmd-make-_fortify_source-defines-dependent-on-.patch perf-tests-avoid-raising-segv-using-an-obvious-null-.patch perf-map-fix-overlapped-map-handling.patch perf-script-brstackinsn-fix-recovery-from-lbr-binary.patch perf-jevents-fix-period-for-intel-fixed-counters.patch perf-tools-propagate-get_cpuid-error.patch perf-annotate-propagate-perf_env__arch-error.patch perf-annotate-fix-the-signedness-of-failure-returns.patch perf-annotate-propagate-the-symbol__annotate-error-r.patch perf-annotate-fix-arch-specific-init-failure-errors.patch perf-annotate-return-appropriate-error-code-for-allo.patch perf-annotate-don-t-return-1-for-error-when-doing-bp.patch staging-rtl8188eu-fix-null-dereference-when-kzalloc-.patch rdma-siw-fix-serialization-issue-in-write_space.patch rdma-hfi1-prevent-memory-leak-in-sdma_init.patch rdma-iw_cxgb4-fix-srq-access-from-dump_qp.patch rdma-iwcm-fix-a-lock-inversion-issue.patch hid-hyperv-use-in-place-iterator-api-in-the-channel-.patch kselftest-exclude-failed-targets-from-runlist.patch selftests-kselftest-runner.sh-add-45-second-timeout-.patch nfs-fix-nfsi-nrequests-count-error-on-nfs_inode_remo.patch arm64-cpufeature-effectively-expose-frint-capability.patch arm64-fix-incorrect-irqflag-restore-for-priority-mas.patch arm64-ftrace-ensure-synchronisation-in-plt-setup-for.patch tty-serial-owl-fix-the-link-time-qualifier-of-owl_ua.patch tty-serial-rda-fix-the-link-time-qualifier-of-rda_ua.patch serial-sifive-select-serial_earlycon.patch tty-n_hdlc-fix-build-on-sparc.patch misc-fastrpc-prevent-memory-leak-in-fastrpc_dma_buf_.patch rdma-core-fix-an-error-handling-path-in-res_get_comm.patch rdma-cm-fix-memory-leak-in-cm_add-remove_one.patch rdma-nldev-reshuffle-the-code-to-avoid-need-to-rebin.patch rdma-mlx5-do-not-allow-rereg-of-a-odp-mr.patch rdma-mlx5-order-num_pending_prefetch-properly-with-s.patch rdma-mlx5-add-missing-synchronize_srcu-for-mw-cases.patch gpio-max77620-use-correct-unit-for-debounce-times.patch fs-cifs-mute-wunused-const-variable-message.patch arm64-vdso32-fix-broken-compat-vdso-build-warnings.patch arm64-vdso32-detect-binutils-support-for-dmb-ishld.patch serial-mctrl_gpio-check-for-null-pointer.patch serial-8250_omap-fix-gpio-check-for-auto-rts-cts.patch arm64-default-to-building-compat-vdso-with-clang-whe.patch arm64-vdso32-don-t-use-kbuild_cppflags-unconditional.patch efi-cper-fix-endianness-of-pcie-class-code.patch efi-x86-do-not-clean-dummy-variable-in-kexec-path.patch mips-include-mark-__cmpxchg-as-__always_inline.patch riscv-avoid-kernel-hangs-when-trapped-in-bug.patch riscv-avoid-sending-a-sigtrap-to-a-user-thread-trapp.patch riscv-correct-the-handling-of-unexpected-ebreak-in-d.patch x86-xen-return-from-panic-notifier.patch ocfs2-clear-zero-in-unaligned-direct-io.patch fs-ocfs2-fix-possible-null-pointer-dereferences-in-o.patch fs-ocfs2-fix-a-possible-null-pointer-dereference-in-.patch fs-ocfs2-fix-a-possible-null-pointer-dereference-in-.patch btrfs-silence-maybe-uninitialized-warning-in-clone_r.patch arm64-armv8_deprecated-checking-return-value-for-mem.patch x86-cpu-add-comet-lake-to-the-intel-cpu-models-heade.patch sched-fair-scale-bandwidth-quota-and-period-without-.patch sched-vtime-fix-guest-system-mis-accounting-on-task-.patch perf-core-rework-memory-accounting-in-perf_mmap.patch perf-core-fix-corner-case-in-perf_rotate_context.patch perf-x86-amd-change-fix-nmi-latency-mitigation-to-us.patch drm-amdgpu-fix-memory-leak.patch iio-imu-adis16400-release-allocated-memory-on-failur.patch iio-imu-adis16400-fix-memory-leak.patch iio-imu-st_lsm6dsx-fix-waitime-for-st_lsm6dsx-i2c-co.patch mips-include-mark-__xchg-as-__always_inline.patch mips-fw-sni-fix-out-of-bounds-init-of-o32-stack.patch s390-cio-fix-virtio-ccw-dma-without-pv.patch virt-vbox-fix-memory-leak-in-hgcm_call_preprocess_li.patch nbd-fix-possible-sysfs-duplicate-warning.patch nfsv4-fix-leak-of-clp-cl_acceptor-string.patch sunrpc-fix-race-to-sk_err-after-xs_error_report.patch s390-uaccess-avoid-false-positive-compiler-warnings.patch tracing-initialize-iter-seq-after-zeroing-in-tracing.patch perf-annotate-fix-multiple-memory-and-file-descripto.patch perf-aux-fix-tracking-of-auxiliary-trace-buffer-allo.patch usb-legousbtower-fix-a-signedness-bug-in-tower_probe.patch nbd-verify-socket-is-supported-during-setup.patch arm64-dts-qcom-add-lenovo-miix-630.patch arm64-dts-qcom-add-hp-envy-x2.patch arm64-dts-qcom-add-asus-novago-tp370ql.patch rtw88-fix-misuse-of-genmask-macro.patch s390-pci-fix-msi-message-data.patch thunderbolt-correct-path-indices-for-pcie-tunnel.patch thunderbolt-use-32-bit-writes-when-writing-ring-prod.patch ath6kl-fix-a-null-ptr-deref-bug-in-ath6kl_usb_alloc_.patch fuse-flush-dirty-data-metadata-before-non-truncate-setattr.patch fuse-truncate-pending-writes-on-o_trunc.patch alsa-bebob-fix-prototype-of-helper-function-to-return-negative-value.patch alsa-timer-fix-mutex-deadlock-at-releasing-card.patch alsa-hda-realtek-fix-2-front-mics-of-codec-0x623.patch alsa-hda-realtek-add-support-for-alc623.patch ath10k-fix-latency-issue-for-qca988x.patch uas-revert-commit-3ae62a42090f-uas-fix-alignment-of-scatter-gather-segments.patch nl80211-fix-validation-of-mesh-path-nexthop.patch Compile testing --------------- We compiled the kernel for 3 architectures: aarch64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ✅ Boot test ✅ Podman system integration test (as root) ✅ Podman system integration test (as user) ✅ LTP lite ✅ Loopdev Sanity ✅ jvm test suite ✅ AMTU (Abstract Machine Test Utility) ✅ LTP: openposix test suite ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ audit: audit testsuite test ✅ httpd: mod_ssl smoke sanity ✅ iotop: sanity ✅ tuned: tune-processes-through-perf ✅ ALSA PCM loopback test ✅ ALSA Control (mixer) Userspace Element test ✅ Usex - version 1.9-29 ✅ trace: ftrace/tracer 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ storage: dm/common Host 2: ✅ Boot test ✅ xfstests: xfs ✅ selinux-policy: serge-testsuite ✅ storage: software RAID testing 🚧 ✅ Storage blktests ppc64le: Host 1: ✅ Boot test ✅ xfstests: xfs ✅ selinux-policy: serge-testsuite ✅ storage: software RAID testing 🚧 ❌ Storage blktests Host 2: ✅ Boot test ✅ Podman system integration test (as root) ✅ Podman system integration test (as user) ✅ LTP lite ✅ Loopdev Sanity ✅ jvm test suite ✅ AMTU (Abstract Machine Test Utility) ✅ LTP: openposix test suite ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ audit: audit testsuite test ✅ httpd: mod_ssl smoke sanity ✅ iotop: sanity ✅ tuned: tune-processes-through-perf ✅ ALSA PCM loopback test ✅ ALSA Control (mixer) Userspace Element test ✅ Usex - version 1.9-29 ✅ trace: ftrace/tracer 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ storage: dm/common x86_64: Host 1: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test ✅ Podman system integration test (as root) ✅ Podman system integration test (as user) ⚡⚡⚡ LTP lite ❌ Loopdev Sanity ❌ jvm test suite ✅ AMTU (Abstract Machine Test Utility) ✅ LTP: openposix test suite ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ audit: audit testsuite test ✅ httpd: mod_ssl smoke sanity ✅ iotop: sanity ✅ tuned: tune-processes-through-perf ✅ pciutils: sanity smoke test ✅ ALSA PCM loopback test ✅ ALSA Control (mixer) Userspace Element test ✅ Usex - version 1.9-29 ✅ stress: stress-ng ✅ trace: ftrace/tracer 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ storage: dm/common Host 2: ✅ Boot test ✅ xfstests: xfs ✅ selinux-policy: serge-testsuite ✅ storage: software RAID testing 🚧 ✅ Storage blktests Host 3: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test 🚧 ⚡⚡⚡ /kernel/infiniband/env_setup 🚧 ⚡⚡⚡ /kernel/infiniband/sanity Host 4: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test 🚧 ⚡⚡⚡ /kernel/infiniband/env_setup 🚧 ⚡⚡⚡ /kernel/infiniband/sanity Host 5: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test 🚧 ⚡⚡⚡ /kernel/infiniband/env_setup 🚧 ⚡⚡⚡ /kernel/infiniband/sanity Host 6: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test 🚧 ⚡⚡⚡ /kernel/infiniband/env_setup 🚧 ⚡⚡⚡ /kernel/infiniband/sanity Test sources: https://github.com/CKI-project/tests-beaker 💚 Pull requests are welcome for new tests or improvements to existing tests! Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed. Testing timeout --------------- We aim to provide a report within reasonable timeframe. Tests that haven't finished running are marked with ⏱. Reports for non-upstream kernels have a Beaker recipe linked to next to each host.

6 years

1
0
0 0

[STABLE-PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

by Alex Lyakas

From: Vratislav Bendel <vbendel(a)redhat.com> [upstream commit 19957a181608d25c8f4136652d0ea00b3738972d] Due to an inverted logic mistake in xfs_buftarg_isolate() the xfs_buffers with zero b_lru_ref will take another trip around LRU, while isolating buffers with non-zero b_lru_ref. Additionally those isolated buffers end up right back on the LRU once they are released, because b_lru_ref remains elevated. Fix that circuitous route by leaving them on the LRU as originally intended. [Additional description for the issue] Due to this issue, buffers will spend one cycle less in the LRU than intended. If we initialize b_lru_ref to X, we intend the buffer to survive X shrinker calls, and on the X+1'th call to be taken off the LRU (and maybe freed). But with this issue, the buffer will be taken off the LRU and immediately re-added back. But this will happen X-1 times, because on the X'th time the b_lru_ref will be 0, and the buffer will not be re-added to the LRU. So the buffer will survive X-1 shrinker calls and not X as intended. Furthermore, if somehow we end up with the buffer sitting on the LRU and having b_lru_ref==0, this buffer will never be taken off the LRU, due to the bug. Not sure that this can happen, because by default b_lru_ref is set to 1. This issue existed since the introduction of lru in XFS buffer cache in commit "430cbeb86fdcbbdabea7d4aa65307de8de425350 xfs: add a lru to the XFS buffer cache". However, the integration with the "list_lru" insfrastructure was done in kernel 3.12, in commit "e80dfa19976b884db1ac2bc5d7d6ca0a4027bd1c xfs: convert buftarg LRU to generic code" Therefore this patch is relevant for all kernels from 3.12 to 4.15 (upstream fix was made in 4.16). Signed-off-by: Alex Lyakas <alex(a)zadara.com> Signed-off-by: Vratislav Bendel <vbendel(a)redhat.com> Reviewed-by: Brian Foster <bfoster(a)redhat.com> Reviewed-by: Christoph Hellwig <hch(a)lst.de> Reviewed-by: Darrick J. Wong <darrick.wong(a)oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong(a)oracle.com> (cherry picked from commit 19957a181608d25c8f4136652d0ea00b3738972d) --- fs/xfs/xfs_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index 16f93d7..e4a6239 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -1702,7 +1702,7 @@ struct xfs_buf * * zero. If the value is already zero, we need to reclaim the * buffer, otherwise it gets another trip through the LRU. */ - if (!atomic_add_unless(&bp->b_lru_ref, -1, 0)) { + if (atomic_add_unless(&bp->b_lru_ref, -1, 0)) { spin_unlock(&bp->b_lock); return LRU_ROTATE; } -- 1.9.1

6 years

2
1
0 0

Please backport 12e36d98d3e for 5.1+: iwlwifi: exclude GEO SAR support for 3168

by Thomas Deutschmann

Hi, please backport <<<<snip >From 12e36d98d3e5acf5fc57774e0a15906d55f30cb9 Mon Sep 17 00:00:00 2001 From: Luca Coelho <luciano.coelho(a)intel.com> Date: Tue, 8 Oct 2019 13:10:53 +0300 Subject: iwlwifi: exclude GEO SAR support for 3168 We currently support two NICs in FW version 29, namely 7265D and 3168. Out of these, only 7265D supports GEO SAR, so adjust the function that checks for it accordingly. Signed-off-by: Luca Coelho <luciano.coelho(a)intel.com> Fixes: f5a47fae6aa3 ("iwlwifi: mvm: fix version check for GEO_TX_POWER_LIMIT support") Signed-off-by: Luca Coelho <luciano.coelho(a)intel.com> snap>>> This was the first patch of a 2 patch patch series. The second patch, aa0cc7dde17 ("iwlwifi: pcie: change qu with jf devices to use qu configuration") had "Cc: stable(a)vger.kernel.org # 5.1+" and was added. The first one was missed. -- Regards, Thomas Deutschmann / Gentoo Linux Developer C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5

6 years

5
4
0 0

[PATCH linux-4.14.y 0/2] sctp: fix a memory leak

by Xin Long

These 2 patches are missed in linux-4.14.y, it will cause crash when commit 63dfb7938b13 ("sctp: change sctp_prot .no_autobind with true") is backported only. Conflicts: - Context difference in Patch 1/2 due to the lack of Commit c981f254cc82. Xin Long (2): sctp: fix the issue that flags are ignored when using kernel_connect sctp: not bind the socket in sctp_connect include/net/sctp/sctp.h | 2 ++ net/sctp/ipv6.c | 2 +- net/sctp/protocol.c | 2 +- net/sctp/socket.c | 55 ++++++++++++++++++++++++++----------------------- 4 files changed, 33 insertions(+), 28 deletions(-) -- 2.1.0

6 years

2
3
0 0

FAILED: patch "[PATCH] drm/etnaviv: fix dumping of iommuv2" failed to apply to 4.19-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.19-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From a2f10d4a3069fee666dab20fab5458757ba1f22d Mon Sep 17 00:00:00 2001 From: Christian Gmeiner <christian.gmeiner(a)gmail.com> Date: Fri, 25 Oct 2019 12:39:10 +0200 Subject: [PATCH] drm/etnaviv: fix dumping of iommuv2 etnaviv_iommuv2_dump_size(..) returns the number of PTE * SZ_4K but etnaviv_iommuv2_dump(..) increments buf pointer even if there is no PTE. This results in a bad buf pointer which gets used for memcpy(..), when copying the MMU state in the coredump buffer. Fixes: afb7b3b1deb4 ("drm/etnaviv: implement IOMMUv2 translation") Cc: stable(a)vger.kernel.org Signed-off-by: Christian Gmeiner <christian.gmeiner(a)gmail.com> Signed-off-by: Lucas Stach <l.stach(a)pengutronix.de> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c b/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c index 043111a1d60c..f8bf488e9d71 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c @@ -155,9 +155,11 @@ static void etnaviv_iommuv2_dump(struct etnaviv_iommu_context *context, void *bu memcpy(buf, v2_context->mtlb_cpu, SZ_4K); buf += SZ_4K; - for (i = 0; i < MMUv2_MAX_STLB_ENTRIES; i++, buf += SZ_4K) - if (v2_context->mtlb_cpu[i] & MMUv2_PTE_PRESENT) + for (i = 0; i < MMUv2_MAX_STLB_ENTRIES; i++) + if (v2_context->mtlb_cpu[i] & MMUv2_PTE_PRESENT) { memcpy(buf, v2_context->stlb_cpu[i], SZ_4K); + buf += SZ_4K; + } } static void etnaviv_iommuv2_restore_nonsec(struct etnaviv_gpu *gpu,

6 years

1
0
0 0

FAILED: patch "[PATCH] drm/etnaviv: fix dumping of iommuv2" failed to apply to 5.3-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 5.3-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From a2f10d4a3069fee666dab20fab5458757ba1f22d Mon Sep 17 00:00:00 2001 From: Christian Gmeiner <christian.gmeiner(a)gmail.com> Date: Fri, 25 Oct 2019 12:39:10 +0200 Subject: [PATCH] drm/etnaviv: fix dumping of iommuv2 etnaviv_iommuv2_dump_size(..) returns the number of PTE * SZ_4K but etnaviv_iommuv2_dump(..) increments buf pointer even if there is no PTE. This results in a bad buf pointer which gets used for memcpy(..), when copying the MMU state in the coredump buffer. Fixes: afb7b3b1deb4 ("drm/etnaviv: implement IOMMUv2 translation") Cc: stable(a)vger.kernel.org Signed-off-by: Christian Gmeiner <christian.gmeiner(a)gmail.com> Signed-off-by: Lucas Stach <l.stach(a)pengutronix.de> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c b/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c index 043111a1d60c..f8bf488e9d71 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c @@ -155,9 +155,11 @@ static void etnaviv_iommuv2_dump(struct etnaviv_iommu_context *context, void *bu memcpy(buf, v2_context->mtlb_cpu, SZ_4K); buf += SZ_4K; - for (i = 0; i < MMUv2_MAX_STLB_ENTRIES; i++, buf += SZ_4K) - if (v2_context->mtlb_cpu[i] & MMUv2_PTE_PRESENT) + for (i = 0; i < MMUv2_MAX_STLB_ENTRIES; i++) + if (v2_context->mtlb_cpu[i] & MMUv2_PTE_PRESENT) { memcpy(buf, v2_context->stlb_cpu[i], SZ_4K); + buf += SZ_4K; + } } static void etnaviv_iommuv2_restore_nonsec(struct etnaviv_gpu *gpu,

6 years

1
0
0 0

FAILED: patch "[PATCH] drm/etnaviv: fix dumping of iommuv2" failed to apply to 4.9-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.9-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From a2f10d4a3069fee666dab20fab5458757ba1f22d Mon Sep 17 00:00:00 2001 From: Christian Gmeiner <christian.gmeiner(a)gmail.com> Date: Fri, 25 Oct 2019 12:39:10 +0200 Subject: [PATCH] drm/etnaviv: fix dumping of iommuv2 etnaviv_iommuv2_dump_size(..) returns the number of PTE * SZ_4K but etnaviv_iommuv2_dump(..) increments buf pointer even if there is no PTE. This results in a bad buf pointer which gets used for memcpy(..), when copying the MMU state in the coredump buffer. Fixes: afb7b3b1deb4 ("drm/etnaviv: implement IOMMUv2 translation") Cc: stable(a)vger.kernel.org Signed-off-by: Christian Gmeiner <christian.gmeiner(a)gmail.com> Signed-off-by: Lucas Stach <l.stach(a)pengutronix.de> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c b/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c index 043111a1d60c..f8bf488e9d71 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c @@ -155,9 +155,11 @@ static void etnaviv_iommuv2_dump(struct etnaviv_iommu_context *context, void *bu memcpy(buf, v2_context->mtlb_cpu, SZ_4K); buf += SZ_4K; - for (i = 0; i < MMUv2_MAX_STLB_ENTRIES; i++, buf += SZ_4K) - if (v2_context->mtlb_cpu[i] & MMUv2_PTE_PRESENT) + for (i = 0; i < MMUv2_MAX_STLB_ENTRIES; i++) + if (v2_context->mtlb_cpu[i] & MMUv2_PTE_PRESENT) { memcpy(buf, v2_context->stlb_cpu[i], SZ_4K); + buf += SZ_4K; + } } static void etnaviv_iommuv2_restore_nonsec(struct etnaviv_gpu *gpu,

6 years

1
0
0 0

FAILED: patch "[PATCH] drm/etnaviv: fix dumping of iommuv2" failed to apply to 4.14-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From a2f10d4a3069fee666dab20fab5458757ba1f22d Mon Sep 17 00:00:00 2001 From: Christian Gmeiner <christian.gmeiner(a)gmail.com> Date: Fri, 25 Oct 2019 12:39:10 +0200 Subject: [PATCH] drm/etnaviv: fix dumping of iommuv2 etnaviv_iommuv2_dump_size(..) returns the number of PTE * SZ_4K but etnaviv_iommuv2_dump(..) increments buf pointer even if there is no PTE. This results in a bad buf pointer which gets used for memcpy(..), when copying the MMU state in the coredump buffer. Fixes: afb7b3b1deb4 ("drm/etnaviv: implement IOMMUv2 translation") Cc: stable(a)vger.kernel.org Signed-off-by: Christian Gmeiner <christian.gmeiner(a)gmail.com> Signed-off-by: Lucas Stach <l.stach(a)pengutronix.de> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c b/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c index 043111a1d60c..f8bf488e9d71 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c @@ -155,9 +155,11 @@ static void etnaviv_iommuv2_dump(struct etnaviv_iommu_context *context, void *bu memcpy(buf, v2_context->mtlb_cpu, SZ_4K); buf += SZ_4K; - for (i = 0; i < MMUv2_MAX_STLB_ENTRIES; i++, buf += SZ_4K) - if (v2_context->mtlb_cpu[i] & MMUv2_PTE_PRESENT) + for (i = 0; i < MMUv2_MAX_STLB_ENTRIES; i++) + if (v2_context->mtlb_cpu[i] & MMUv2_PTE_PRESENT) { memcpy(buf, v2_context->stlb_cpu[i], SZ_4K); + buf += SZ_4K; + } } static void etnaviv_iommuv2_restore_nonsec(struct etnaviv_gpu *gpu,

6 years

1
0
0 0

WTF: patch "[PATCH] drm/panfrost: fix -Wmissing-prototypes warnings" was seriously submitted to be applied to the 5.3-stable tree?

by gregkh＠linuxfoundation.org

The patch below was submitted to be applied to the 5.3-stable tree. I fail to see how this patch meets the stable kernel rules as found at Documentation/process/stable-kernel-rules.rst. I could be totally wrong, and if so, please respond to <stable(a)vger.kernel.org> and let me know why this patch should be applied. Otherwise, it is now dropped from my patch queues, never to be seen again. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 6f39188c9d5f81af7a3bc687636b7abc9629ee27 Mon Sep 17 00:00:00 2001 From: Yi Wang <wang.yi59(a)zte.com.cn> Date: Fri, 25 Oct 2019 09:30:15 +0800 Subject: [PATCH] drm/panfrost: fix -Wmissing-prototypes warnings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We get these warnings when build kernel W=1: drivers/gpu/drm/panfrost/panfrost_perfcnt.c:35:6: warning: no previous prototype for ‘panfrost_perfcnt_clean_cache_done’ [-Wmissing-prototypes] drivers/gpu/drm/panfrost/panfrost_perfcnt.c:40:6: warning: no previous prototype for ‘panfrost_perfcnt_sample_done’ [-Wmissing-prototypes] drivers/gpu/drm/panfrost/panfrost_perfcnt.c:190:5: warning: no previous prototype for ‘panfrost_ioctl_perfcnt_enable’ [-Wmissing-prototypes] drivers/gpu/drm/panfrost/panfrost_perfcnt.c:218:5: warning: no previous prototype for ‘panfrost_ioctl_perfcnt_dump’ [-Wmissing-prototypes] drivers/gpu/drm/panfrost/panfrost_perfcnt.c:250:6: warning: no previous prototype for ‘panfrost_perfcnt_close’ [-Wmissing-prototypes] drivers/gpu/drm/panfrost/panfrost_perfcnt.c:264:5: warning: no previous prototype for ‘panfrost_perfcnt_init’ [-Wmissing-prototypes] drivers/gpu/drm/panfrost/panfrost_perfcnt.c:320:6: warning: no previous prototype for ‘panfrost_perfcnt_fini’ [-Wmissing-prototypes] drivers/gpu/drm/panfrost/panfrost_mmu.c:227:6: warning: no previous prototype for ‘panfrost_mmu_flush_range’ [-Wmissing-prototypes] drivers/gpu/drm/panfrost/panfrost_mmu.c:435:5: warning: no previous prototype for ‘panfrost_mmu_map_fault_addr’ [-Wmissing-prototypes] For file panfrost_mmu.c, make functions static to fix this. For file panfrost_perfcnt.c, include header file can fix this. Signed-off-by: Yi Wang <wang.yi59(a)zte.com.cn> Reviewed-by: Steven Price <steven.price(a)arm.com> Cc: stable(a)vger.kernel.org [robh: fixup function parameter alignment] Signed-off-by: Rob Herring <robh(a)kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/1571967015-42854-1-git-send-e… diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c index bdd990568476..87e7963b8adf 100644 --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c @@ -224,9 +224,9 @@ static size_t get_pgsize(u64 addr, size_t size) return SZ_2M; } -void panfrost_mmu_flush_range(struct panfrost_device *pfdev, - struct panfrost_mmu *mmu, - u64 iova, size_t size) +static void panfrost_mmu_flush_range(struct panfrost_device *pfdev, + struct panfrost_mmu *mmu, + u64 iova, size_t size) { if (mmu->as < 0) return; @@ -432,7 +432,8 @@ addr_to_drm_mm_node(struct panfrost_device *pfdev, int as, u64 addr) #define NUM_FAULT_PAGES (SZ_2M / PAGE_SIZE) -int panfrost_mmu_map_fault_addr(struct panfrost_device *pfdev, int as, u64 addr) +static int panfrost_mmu_map_fault_addr(struct panfrost_device *pfdev, int as, + u64 addr) { int ret, i; struct panfrost_gem_object *bo; diff --git a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c b/drivers/gpu/drm/panfrost/panfrost_perfcnt.c index 83c57d325ca8..2dba192bf198 100644 --- a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c +++ b/drivers/gpu/drm/panfrost/panfrost_perfcnt.c @@ -16,6 +16,7 @@ #include "panfrost_issues.h" #include "panfrost_job.h" #include "panfrost_mmu.h" +#include "panfrost_perfcnt.h" #include "panfrost_regs.h" #define COUNTERS_PER_BLOCK 64

6 years

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror