Re: [PATCH] nvmem: meson-efuse: Fix return value of nvmem callbacks

On Tue, Jun 11, 2024 at 02:55:24PM +0000, Joy Chakraborty wrote:

Read/write callbacks registered with nvmem core expect 0 to be returned on success and a negative value to be returned on failure.

meson_efuse_read() and meson_efuse_write() call into meson_sm_call_read() and meson_sm_call_write() respectively which return the number of bytes read or written on success as per their api description.

Fix to return error if meson_sm_call_read()/meson_sm_call_write() returns an error else return 0.

Fixes: a29a63bdaf6f ("nvmem: meson-efuse: simplify read callback") Cc: stable@vger.kernel.org Signed-off-by: Joy Chakraborty joychakr@google.com

Thanks!

Reviewed-by: Dan Carpenter dan.carpenter@linaro.org

regards, dan carpenter