On Mon, Sep 22, 2025 at 10:50 AM Sumit Garg sumit.garg@kernel.org wrote:
On Mon, Sep 22, 2025 at 10:31:58AM +0200, Jens Wiklander wrote:
In register_shm_helper(), fix incorrect error handling for a call to iov_iter_extract_pages(). A case is missing for when iov_iter_extract_pages() only got some pages and return a number larger than 0, but not the requested amount.
This fixes a possible NULL pointer dereference following a bad input from ioctl(TEE_IOC_SHM_REGISTER) where parts of the buffer isn't mapped.
Cc: stable@vger.kernel.org Reported-by: Masami Ichikawa masami256@gmail.com Closes: https://lore.kernel.org/op-tee/CACOXgS-Bo2W72Nj1_44c7bntyNYOavnTjJAvUbEiQfq=... Tested-by: Masami Ichikawa masami256@gmail.com Fixes: 7bdee4157591 ("tee: Use iov_iter to better support shared buffer registration") Signed-off-by: Jens Wiklander jens.wiklander@linaro.org
Changes from v1
- Refactor the if statement as requested by Sumit
- Adding Tested-by: Masami Ichikawa <masami256@gmail.com
- Link to v1: https://lore.kernel.org/op-tee/20250919124217.2934718-1-jens.wiklander@linar...
drivers/tee/tee_shm.c | 8 ++++++++ 1 file changed, 8 insertions(+)
Reviewed-by: Sumit Garg sumit.garg@oss.qualcomm.com
I'm picking up this.
Thanks, Jens