On Mon, Nov 11, 2024 at 3:28 AM Andrew Morton akpm@linux-foundation.org wrote:
The quilt patch titled Subject: zram: clear IDLE flag in mark_idle() has been removed from the -mm tree. Its filename was zram-clear-idle-flag-in-mark_idle.patch
This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
I think this also needs to be Cc'd to stable.
From: Sergey Senozhatsky senozhatsky@chromium.org Subject: zram: clear IDLE flag in mark_idle() Date: Tue, 29 Oct 2024 00:36:15 +0900
If entry does not fulfill current mark_idle() parameters, e.g. cutoff time, then we should clear its ZRAM_IDLE from previous mark_idle() invocations.
Consider the following case:
- mark_idle() cutoff time 8h
- mark_idle() cutoff time 4h
- writeback() idle - will writeback entries with cutoff time 8h, while it should only pick entries with cutoff time 4h
The bug was reported by Shin Kawamura.
Link: https://lkml.kernel.org/r/20241028153629.1479791-3-senozhatsky@chromium.org Fixes: 755804d16965 ("zram: introduce an aged idle interface") Signed-off-by: Sergey Senozhatsky senozhatsky@chromium.org Reported-by: Shin Kawamura kawasin@google.com Acked-by: Brian Geffon bgeffon@google.com Cc: Minchan Kim minchan@kernel.org
Cc: stable@vger.kernel.org
Signed-off-by: Andrew Morton akpm@linux-foundation.org
drivers/block/zram/zram_drv.c | 2 ++ 1 file changed, 2 insertions(+)
--- a/drivers/block/zram/zram_drv.c~zram-clear-idle-flag-in-mark_idle +++ a/drivers/block/zram/zram_drv.c @@ -410,6 +410,8 @@ static void mark_idle(struct zram *zram, #endif if (is_idle) zram_set_flag(zram, index, ZRAM_IDLE);
elsezram_clear_flag(zram, index, ZRAM_IDLE); zram_slot_unlock(zram, index); }} _
Patches currently in -mm which might be from senozhatsky@chromium.org are