6.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dmitry Safonov 0x7f454c46@gmail.com
[ Upstream commit beb78cd1329d039d73487ca05633d1b92e1ab2ea ]
On my new laptop with packages from nixos-unstable, gcc 12.3.0 produces:
lib/proc.c: In function ‘netstat_read_type’: lib/proc.c:89:9: error: format not a string literal and no format arguments [-Werror=format-security] 89 | if (fscanf(fnetstat, type->header_name) == EOF) | ^~ cc1: some warnings being treated as errors
Here the selftests lib parses header name, while expectes non-space word ending with a column.
Fixes: cfbab37b3da0 ("selftests/net: Add TCP-AO library") Signed-off-by: Dmitry Safonov 0x7f454c46@gmail.com Reported-by: Muhammad Usama Anjum usama.anjum@collabora.com Signed-off-by: Paolo Abeni pabeni@redhat.com Signed-off-by: Sasha Levin sashal@kernel.org --- tools/testing/selftests/net/tcp_ao/lib/proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/tcp_ao/lib/proc.c b/tools/testing/selftests/net/tcp_ao/lib/proc.c index 2fb6dd8adba69..8b984fa042869 100644 --- a/tools/testing/selftests/net/tcp_ao/lib/proc.c +++ b/tools/testing/selftests/net/tcp_ao/lib/proc.c @@ -86,7 +86,7 @@ static void netstat_read_type(FILE *fnetstat, struct netstat **dest, char *line)
pos = strchr(line, ' ') + 1;
- if (fscanf(fnetstat, type->header_name) == EOF) + if (fscanf(fnetstat, "%[^ :]", type->header_name) == EOF) test_error("fscanf(%s)", type->header_name); if (fread(&tmp, 1, 1, fnetstat) != 1 || tmp != ':') test_error("Unexpected netstat format (%c)", tmp);