Re: [PATCH 6.6.y 1/2] selftests/net: add lib.sh

On Fri, Jun 14, 2024 at 02:58:19PM +0800, Po-Hsu Lin wrote:

--- a/tools/testing/selftests/net/forwarding/lib.sh +++ b/tools/testing/selftests/net/forwarding/lib.sh @@ -4,9 +4,6 @@ ############################################################################## # Defines -# Kselftest framework requirement - SKIP code is 4. -ksft_skip=4

# Can be overridden by the configuration file. PING=${PING:=ping} PING6=${PING6:=ping6} @@ -41,6 +38,7 @@ if [[ -f $relative_path/forwarding.config ]]; then source "$relative_path/forwarding.config" fi +source ../lib.sh ############################################################################## # Sanity checks @@ -395,29 +393,6 @@ log_info() echo "INFO: $msg" } -busywait() -{

• local timeout=$1; shift
• local start_time="$(date -u +%s%3N)"
• while true
• do

• local out
  

• out=$("$@")
  

• local ret=$?
  

• if ((!ret)); then
  

• 	echo -n "$out"
  

• 	return 0
  

• fi
  

• local current_time="$(date -u +%s%3N)"
  

• if ((current_time - start_time > timeout)); then
  

• 	echo -n "$out"
  

• 	return 1
  

• fi
  

• done

-}

Hi Po-Hsu,

There are some selftest architecture issues with only this patch. We need at least the following patch to fix it.

2114e83381d3 ("selftests: forwarding: Avoid failures to source net/lib.sh")

Thanks Hangbin