From: Diego Santa Cruz Diego.SantaCruz@spinetix.com
The quirk added in upstream commit 90c3e2198777 ("drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.") is also required on the ECS Liva Q2.
Note: Would be nicer to figure out the extra delay required for the retimer without quirks, however don't know how to check for that.
Cc: stable@vger.kernel.org Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1326 Signed-off-by: Diego Santa Cruz Diego.SantaCruz@spinetix.com Signed-off-by: Jani Nikula jani.nikula@intel.com --- drivers/gpu/drm/i915/display/intel_quirks.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c b/drivers/gpu/drm/i915/display/intel_quirks.c index c8488f5ebd04..e415cd7c0b84 100644 --- a/drivers/gpu/drm/i915/display/intel_quirks.c +++ b/drivers/gpu/drm/i915/display/intel_quirks.c @@ -191,6 +191,9 @@ static struct intel_quirk intel_quirks[] = { /* ASRock ITX*/ { 0x3185, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, { 0x3184, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, + /* ECS Liva Q2 */ + { 0x3185, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time }, + { 0x3184, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time }, };
void intel_init_quirks(struct drm_i915_private *i915)
On Thu, Jun 16, 2022 at 03:41:37PM +0300, Jani Nikula wrote:
From: Diego Santa Cruz Diego.SantaCruz@spinetix.com
The quirk added in upstream commit 90c3e2198777 ("drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.") is also required on the ECS Liva Q2.
Note: Would be nicer to figure out the extra delay required for the retimer without quirks, however don't know how to check for that.
Cc: stable@vger.kernel.org Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1326 Signed-off-by: Diego Santa Cruz Diego.SantaCruz@spinetix.com Signed-off-by: Jani Nikula jani.nikula@intel.com
Seems fine. Although I do wonder whether we could directly identify the bogus retimer chip via the dual mode adapter registers. I've asked for that in the bug.
Reviewed-by: Ville Syrjälä ville.syrjala@linux.intel.com
drivers/gpu/drm/i915/display/intel_quirks.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c b/drivers/gpu/drm/i915/display/intel_quirks.c index c8488f5ebd04..e415cd7c0b84 100644 --- a/drivers/gpu/drm/i915/display/intel_quirks.c +++ b/drivers/gpu/drm/i915/display/intel_quirks.c @@ -191,6 +191,9 @@ static struct intel_quirk intel_quirks[] = { /* ASRock ITX*/ { 0x3185, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, { 0x3184, 0x1849, 0x2212, quirk_increase_ddi_disabled_time },
- /* ECS Liva Q2 */
- { 0x3185, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time },
- { 0x3184, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time },
}; void intel_init_quirks(struct drm_i915_private *i915) -- 2.30.2
On Thu, 25 Aug 2022, Ville Syrjälä ville.syrjala@linux.intel.com wrote:
On Thu, Jun 16, 2022 at 03:41:37PM +0300, Jani Nikula wrote:
From: Diego Santa Cruz Diego.SantaCruz@spinetix.com
The quirk added in upstream commit 90c3e2198777 ("drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.") is also required on the ECS Liva Q2.
Note: Would be nicer to figure out the extra delay required for the retimer without quirks, however don't know how to check for that.
Cc: stable@vger.kernel.org Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1326 Signed-off-by: Diego Santa Cruz Diego.SantaCruz@spinetix.com Signed-off-by: Jani Nikula jani.nikula@intel.com
Seems fine. Although I do wonder whether we could directly identify the bogus retimer chip via the dual mode adapter registers. I've asked for that in the bug.
Reviewed-by: Ville Syrjälä ville.syrjala@linux.intel.com
Thanks, pushed to drm-intel-next. Let's follow up with cleanups if the folks in the bug ever reply.
BR, Jani.
drivers/gpu/drm/i915/display/intel_quirks.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c b/drivers/gpu/drm/i915/display/intel_quirks.c index c8488f5ebd04..e415cd7c0b84 100644 --- a/drivers/gpu/drm/i915/display/intel_quirks.c +++ b/drivers/gpu/drm/i915/display/intel_quirks.c @@ -191,6 +191,9 @@ static struct intel_quirk intel_quirks[] = { /* ASRock ITX*/ { 0x3185, 0x1849, 0x2212, quirk_increase_ddi_disabled_time }, { 0x3184, 0x1849, 0x2212, quirk_increase_ddi_disabled_time },
- /* ECS Liva Q2 */
- { 0x3185, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time },
- { 0x3184, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time },
}; void intel_init_quirks(struct drm_i915_private *i915) -- 2.30.2
linux-stable-mirror@lists.linaro.org
-
Jani Nikula -
Ville Syrjälä