On Mon, Jun 15, 2020 at 7:05 PM Daniel Díaz <daniel.diaz@linaro.org> wrote:
Hello!

On Mon, 15 Jun 2020 at 11:38, Nicolas Dechesne
<nicolas.dechesne@linaro.org> wrote:
> On Mon, Jun 15, 2020 at 6:34 PM Daniel Díaz <daniel.diaz@linaro.org> wrote:
>> Hello!
>>
>> I mentioned a few weeks back that I had some doubts on the difference
>> between this override:
>>   SRCREV_kernel = "5821a5593fa9f28eb6fcc95c35d00454d9bb8624"
>> and this one:
>>   SRCREV_kernel_juno = "5821a5593fa9f28eb6fcc95c35d00454d9bb8624"
>
>
> Just to make sure I am looking at the right thing, can you please send a link to the actual recipe?

Here's the kernel recipe:
  https://github.com/Linaro/meta-lkft/blob/sumo/recipes-kernel/linux/linux-generic-stable-rc_5.7.bb

here, _kernel is not an override. You are using the SRCREV_FORMAT pattern. 'kernel' is coming from the 'name' arg in you SRC_URI. 

So when you use SRCREV_kernel in local.conf , it's setting this variable for *all* recipes, including your kernel recipe. So your kernel recipe picks up the new value.

If you use SRCREV_kernel_juno, then 'juno' is an override for the variable called SRCREV_kernel. 



>> The following is the definition in the kernel recipe itself:
>>   SRCREV_kernel = "3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162"
>>
>> Turns out that with _only_ the first override in local.conf (without
>> MACHINE), the kernel uses the right SRCREV but Perf uses the one from
>> the recipe; I have to include the second override (with MACHINE) so
>> that Perf can use the right SRCREV.
>
>
> same here

Here's the Perf recipe:
  https://github.com/openembedded/openembedded-core/blob/master/meta/recipes-kernel/perf/perf.bb

I am not too familiar with the perf recipe, but looks like it is setting:
S = "${STAGING_KERNEL_DIR}"
deltask do_fetch

So it doesn't seem to fetch anything, but it reuses the kernel source tree. So here SRCREV is 'irrelevant', I believe.



On local.conf:
# Correct for kernel, incorrect for Perf:
#SRCREV_kernel = "5117c0a56aeeb3ab18fb91bd611e739fec3df9c0"
# Correct for kernel and Perf:
SRCREV_kernel_juno = "5117c0a56aeeb3ab18fb91bd611e739fec3df9c0"

I don't understand why it would make a difference.. maybe with what I said earlier will shed some lights on your side?
 

Thanks and greetings!

Daniel Díaz
daniel.diaz@linaro.org



>> Does anyone have a pointer that could shed more light on that subject?
>>
>> Thanks and greetings!
>>
>> Daniel Díaz
>> daniel.diaz@linaro.org
>> _______________________________________________
>> OpenEmbedded mailing list
>> OpenEmbedded@lists.linaro.org
>> https://lists.linaro.org/mailman/listinfo/openembedded