[PATCH] EXYNOS: Rename exynos5_tzpc structure to s5p_tzpc

Chander Kashyap chander.kashyap at linaro.org
Wed Mar 14 13:38:13 UTC 2012


Hi Kyungmin Park,

On 14 March 2012 19:02, Kyungmin Park <kmpark at infradead.org> wrote:
> Hi Chander,
>
> On Wed, Mar 14, 2012 at 10:14 PM, Chander Kashyap
> <chander.kashyap at linaro.org> wrote:
>> TZPC IP is common across S5P and Exynos based SoC'c. Renaming exynos5_tzpc
>> in arch/arm/include/asm/arch-exynos/tzpc.h to s5p_tzpc will allow generic
>> usase of tzpc.
>>
>> Also modify board/samsung/smdk5250/tzpc_init.c to use s5p_tzpc.
>>
>> Signed-off-by: Chander Kashyap <chander.kashyap at linaro.org>
>> ---
>>  arch/arm/include/asm/arch-exynos/tzpc.h |    2 +-
>>  board/samsung/smdk5250/tzpc_init.c      |    2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/include/asm/arch-exynos/tzpc.h b/arch/arm/include/asm/arch-exynos/tzpc.h
>> index 2c9a07b..63736ae 100644
>> --- a/arch/arm/include/asm/arch-exynos/tzpc.h
>> +++ b/arch/arm/include/asm/arch-exynos/tzpc.h
>> @@ -22,7 +22,7 @@
>>  #define __TZPC_H_
>>
>>  #ifndef __ASSEMBLY__
>> -struct exynos5_tzpc {
>> +struct s5p_tzpc {
> I think 'exynos' is preferable. Even though each SOC has different
I tried to carry forward old conventions as in case of watchdog. I
will change it to exynos.

> number of tzpc. It can be covered one exynos_tzpc. or  we can define
> it for each SoC.
One structure is enough as fields are same.

>
> Thank you,
> Kyungmin Park
>>        unsigned int r0size;
>>        char res1[0x7FC];
>>        unsigned int decprot0stat;
>> diff --git a/board/samsung/smdk5250/tzpc_init.c b/board/samsung/smdk5250/tzpc_init.c
>> index c2ccef3..03e46bb 100644
>> --- a/board/samsung/smdk5250/tzpc_init.c
>> +++ b/board/samsung/smdk5250/tzpc_init.c
>> @@ -28,7 +28,7 @@
>>  /* Setting TZPC[TrustZone Protection Controller] */
>>  void tzpc_init(void)
>>  {
>> -       struct exynos5_tzpc *tzpc;
>> +       struct s5p_tzpc *tzpc;
>>        unsigned int addr;
>>
>>        for (addr = TZPC0_BASE; addr <= TZPC9_BASE; addr += TZPC_BASE_OFFSET) {
>> --
>> 1.7.5.4
>>
>>
>> _______________________________________________
>> linaro-dev mailing list
>> linaro-dev at lists.linaro.org
>> http://lists.linaro.org/mailman/listinfo/linaro-dev



-- 
with warm regards,
Chander Kashyap



More information about the linaro-dev mailing list