[PATCH v7 2/3] clk: introduce the common clock framework
mturquette at ti.com
Mon Mar 19 19:53:50 UTC 2012
On Mon, Mar 19, 2012 at 4:22 AM, Rajendra Nayak <rnayak at ti.com> wrote:
> On Friday 16 March 2012 11:41 AM, Mike Turquette wrote:
>> + * calculate the new rates returning the topmost clock that has to be
>> + * changed.
>> + */
>> +static struct clk *clk_calc_new_rates(struct clk *clk, unsigned long
>> + struct clk *top = clk;
>> + unsigned long best_parent_rate = clk->parent->rate;
> Shouldn't you check for a valid parent before dereferencing it? A
> clk_set_rate() on a root clock might throw up some issues otherwise.
Yes, the clk_calc_new_rates code assumes a valid parent pointer in
several locations. Thanks for the catch. Will roll into my fixes
More information about the linaro-dev