[PATCH v8 4/8] ARM: davinci: Consolidate time keeping and irq enable

Nori, Sekhar nsekhar at ti.com
Wed Mar 21 15:33:33 UTC 2012


Hi Rob,

On Wed, Mar 21, 2012 at 01:52:45, Robert Lee wrote:
> Enable core cpuidle timekeeping and irq enabling and remove that
> handling from this code.
> 
> Signed-off-by: Robert Lee <rob.lee at linaro.org>
> Reviewed-by: Kevin Hilman <khilman at ti.com>
> Reviewed-by: Daniel Lezcano <daniel.lezcano at linaro.org>
> Acked-by: Jean Pihet<j-pihet at ti.com>

>  static struct cpuidle_driver davinci_idle_driver = {
> -	.name	= "cpuidle-davinci",
> -	.owner	= THIS_MODULE,
> +	.name		= "cpuidle-davinci",
> +	.owner		= THIS_MODULE,
> +	.states[0]	= ARM_CPUIDLE_WFI_STATE,
> +	.states[1]	= {
> +		.enter			= davinci_enter_idle,
> +		.exit_latency		= 10,
> +		.target_residency	= 100000,

Apart from your other fix patch, can you also update the
target residency of this state to 10000 as is the case
with current code? With the new value the board is entering
this state really infrequently.

Thanks,
Sekhar



More information about the linaro-dev mailing list