On Mon, 2012-05-07 at 16:30 -0600, Mathieu Poirier wrote:
On 12-05-07 04:05 PM, Bernhard Rosenkränzer wrote:
Hi,
On 7 May 2012 23:40, Mathieu Poirier mathieu.poirier@linaro.org wrote:
Good day y'all,
Many of you have received a gerrit review request that concerns Gator and a kernel API change that happened between 3.3 and 3.4. If you maintain a build associated to a board, please review.
Looks good to me, but I wonder if just fixing the code to handle both cases wouldn't be smarter...
#include <linux/version.h> #if LINUX_VERSION_CODE < KERNEL_VERSION(3,4,0) d_alloc_root #else d_make_root #endif
ttyl bero
This is a much, much better solution. I will revert the merge and implement your way.
Yes, that is the better way, however the API wasn't simply renamed in 3.4, the semantics are different so it needs another change to keep the inode reference count correct in case of error. I have applied a fix in this change... http://git.linaro.org/gitweb?p=arm/ds5/gator.git%3Ba=commit%3Bh=097d741a276a...
I had fixed the 3.4 compilation issue in the Gator topic branch, but forgot that some Android kernels don't yet include this, sorry about that.
Yesterday was a public holiday in the UK which is why I haven't responded sooner.