Hi Zygmunt,
On 07/25/2012 02:26 AM, Zygmunt Krynicki wrote:
Hi everyone.
I've setup a set of builds to examine how my BUILD-INFO.txt overlays are interpreted by the build system.
Sadly the tests seem to indicate that the system does not work. There are two tests to show this:
Build: https://android-build.linaro.org/builds/~zkrynicki/origen-ics-gcc47-samsungl...
This build uses:
- Samsung 'name' of the build
- Panda source code
- Fake overlay with snowball license
The result is: samsung license presented.
Build: https://android-build.linaro.org/builds/~zkrynicki/origen-ics-gcc47-samsungl...
Points 1-3 as before, the only difference is some switch in jenkins (that I cannot see as I don't have access to jenkins) that instructs it to pull BUILD-INFO.txt from the build tree.
The result is: no license is presented, any file can be downloaded at will
Both builds are correct in the term that BUILD-INFO.txt is copied to the output directory, alongside system.tar.bz2 This can be easily confirmed by grepping for BUILD-INFO.txt in the full build logs
My suggestion for tomorrow:
- I'd like to work with Gesha who implemented the php based system to
debug why build #6 failed to work.
Build #6 didn't fail. It works as expected. BUILD-INFO.txt points to an 'open' build, so no license acceptance is asked. Build #5 doesn't have BUILD-INFO.txt, so old EULA style (path-based) is used to determine what license to show, in our case it is Samsung.
Gesha: would you have some time to work on this (in sync) tomorrow?
Sure, please ping me.
- I'd like to get it to work as intended. Getting access to jenkins
would make this part much much easier (I suspect that requires danilos/asac to ack).
- I'd like to ACK the plan on how to switch production builds to this
with all the stakeholders (asac, pfefferz, gesha).
Do you have a plan? :) We are waiting for RTs #518 and #504 being resolved and then we can switch to the new license protection.
Currently we are in position to switch everything bug samsung/origen builds (still waiting for a response from anyone on the samsung team, will reiterate/escalate to get response and move the topic). The only things that are preventing us from doing this is the actual build/download system integration.
Thanks everyone. ZK