On Tue, May 8, 2012 at 12:01 AM, Mathieu Poirier mathieu.poirier@linaro.org wrote:
On 12-05-07 03:48 PM, Alexander Sack wrote:
On Mon, May 7, 2012 at 11:40 PM, Mathieu Poirier mathieu.poirier@linaro.org wrote:
Good day y'all,
Many of you have received a gerrit review request that concerns Gator and a kernel API change that happened between 3.3 and 3.4. If you maintain a build associated to a board, please review.
The problem happens when compiling an android build with a 3.4 kernel. The Gator driver is looking for the 'd_alloc_root' function when compiling 'gator_fs.c', something that is provided by the kernel.
But commit [1] has replaced the function with 'd_make_root' during the 3.4 merge cycle. Zach suggested to point the last SHA of the old API to avoid spinning off yet another branch, something that was implemented as part of [2].
If you are the last one to review and have merge rights, please push the changes.
I assume it's the driver/ part of ds5 causing troubles here? Any way to make the source support both kernel ABIs using an #ifdef or something? In this way we could continue tracking the latest and would be able to spin 3.3 and 3.4 based LEBs off the same thing.
Correct, it's the driver part of ds5.
Using and #ifdef would mean that all builds would have to declare a new define somewhere, which, in my opinion is not as clean as what Zach and I are proposing.
I thought the info which kernel ABI one builds against could be taken from the kernel headers used at build time ...
If that's not the case, then it feels that either ds5 really must find a way to just use stable API (if that exists) or move in-kernel...