Hello,
On Tue, 3 Jul 2012 20:22:24 -0500 Zach Pfeffer zach.pfeffer@linaro.org wrote:
[]
build config either comes completely from the interactive form in build frontend, or completely from git, you can't mix the both. That was kind of requirement for design of the git build config feature - to make sure that complete config comes from a well-known location, and tracked for changes in its entirety.
Sure, but assuming we want to change it so that the build gets kicked off from:
MANIFEST_REPO=git://android.git.linaro.org/platform/manifest.git MANIFEST_BRANCH=linaro_android_4.0.4 MANIFEST_FILENAME=tracking-panda.xml
but then:
TARGET_PRODUCT=pandaboard TARGET_SIMULATOR=false TOOLCHAIN_URL=http://snapshots.linaro.org/android/~linaro-android/toolchain-4.7-2012.06/5/... TOOLCHAIN_TRIPLET=arm-linux-androideabi REPO_SEED_URL=http://android-build.linaro.org/seed/uniseed.tar.gz LAVA_SUBMIT=1 LAVA_SUBMIT_FATAL=0 TARGET_NO_HARDWAREGFX=1 KERNEL_CONFIG=omap4plus_defconfig LAVA_ANDROID_BINARIES=False LAVA_TEST_PLAN="busybox,0xbench,glmark2,skia,v8,mmtest,cts,monkey" MONKEY_RUNNER_URL_1="git://android.git.linaro.org/test/linaro/android/system.git"
is all kept in a git, in the build. What would need to change?
Well, I didn't make any special checks to disallow mixing of BUILD_CONFIG_* vars with "older" ones, but didn't add support for allow that either. So, current code needs to reviewed how exactly it behaves, then updated if needed to process both configs, and in right order.
But again, doing so may just lead us into bigger mess than just using either one way or another config ;-). Infrastructure is about to start working on new build frontend, so it should be thought in that context too - either such requirement should be added there too, or if it won't be supported there, that it makes little sense to hack it in current Android build frontend.
http://android.git.linaro.org/gitweb?p=linaro/build-configs.git%3Ba=summary was created to store configs for the official builds in the Gerrit tree.
Sample job is available here: https://android-build.linaro.org/builds/~pfalcon/git-build-config/ (it uses personal repo as a test).
-- Best Regards, Paul
Linaro.org | Open source software for ARM SoCs Follow Linaro: http://www.facebook.com/pages/Linaro http://twitter.com/#%21/linaroorg - http://www.linaro.org/linaro-blog
-- Best Regards, Paul
Linaro.org | Open source software for ARM SoCs Follow Linaro: http://www.facebook.com/pages/Linaro http://twitter.com/#%21/linaroorg - http://www.linaro.org/linaro-blog
-- Best Regards, Paul
Linaro.org | Open source software for ARM SoCs Follow Linaro: http://www.facebook.com/pages/Linaro http://twitter.com/#%21/linaroorg - http://www.linaro.org/linaro-blog