Re: [Linaro] Comment posted to request #SYS-55: Can not submit changes on android-patchsets.git to dev-private-review.linaro.org for review
Hi, Paul, Andy
On 2 July 2016 at 03:58, John Stultz john.stultz@linaro.org wrote:
Would it make more sense to have gerrit reject new refs/for/ names that don't correlate to a existing branch?
Is it possible from the server side?
Thanks, Yongqin Liu
On Jul 1, 2016 12:41 PM, "YongQin Liu" yongqin.liu@linaro.org wrote:
Hi, Bero, Satish
When you submit changes on android-patchsets repository to dev-private- *review*.linaro.org for review, please run
*git review*
to submit your changes for review, we have .gitreview file in the repository for using that command.
To use "git review", git-review package needs to be installed with commands like this:
*sudo apt-get install git-review*
Thanks, Yongqin Liu On 1 July 2016 at 22:33, Paul Sokolovsky systems-support@linaro.org wrote:
—Write replies above—
I've removed stray branch in refs/for/ namespace. And as Andy mentions, this is second case in last week. Please remember/remind your colleages that for gerrit, dev-private-*review*.linaro.org URL should be used, and using "git review" is largely preferred to directly pushing to refs/for/*.
Yongqin Liu created this request. Bero Rosenkränzer, Vishal Bhoj and Satish Patel are participating. You can reply directly to this email to add any further comments or attachments. See request details and updates for #SYS-55 https://servicedesk.linaro.org/servicedesk/customer/portal/4/SYS-55?sda_source=notification-email
- "Can not submit changes on android-patchsets.git to
dev-private-review.linaro.org for review"
Linaro Help Center sent you this message, *powered by* JIRA Service Desk http://www.atlassian.com/software/jira/service-desk
-- Best Regards, Yongqin Liu
#mailing list linaro-android@lists.linaro.org linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-android
linaro-android mailing list linaro-android@lists.linaro.org https://lists.linaro.org/mailman/listinfo/linaro-android
On Mon, 4 Jul 2016 10:50:35 +0800 YongQin Liu yongqin.liu@linaro.org wrote:
Hi, Paul, Andy
On 2 July 2016 at 03:58, John Stultz john.stultz@linaro.org wrote:
Would it make more sense to have gerrit reject new refs/for/ names that don't correlate to a existing branch?
Is it possible from the server side?
The problem here was that someone submitted a special-for-Gerrit reference via a *normal git daemon*. As mentioned by YongQin below, if one uses "git review" command, such mistakes won't happen, and overall submit-for-review process will be much smoother. Same of course goes for "repo upload" command too.
Otherwise, we didn't have problems with "refs/for/" branches for years, and while it's a second case in last week, I hope that some gentle drawing of attention to the issue is all that's needed so far.
If such cases will re-occur, we (Systems) will definitely look at how to prevent them server-side.
Thanks, Yongqin Liu
On Jul 1, 2016 12:41 PM, "YongQin Liu" yongqin.liu@linaro.org wrote:
Hi, Bero, Satish
When you submit changes on android-patchsets repository to dev-private- *review*.linaro.org for review, please run
*git review*
to submit your changes for review, we have .gitreview file in the repository for using that command.
To use "git review", git-review package needs to be installed with commands like this:
*sudo apt-get install git-review*
Thanks, Yongqin Liu On 1 July 2016 at 22:33, Paul Sokolovsky systems-support@linaro.org wrote:
—Write replies above—
I've removed stray branch in refs/for/ namespace. And as Andy mentions, this is second case in last week. Please remember/remind your colleages that for gerrit, dev-private-*review*.linaro.org URL should be used, and using "git review" is largely preferred to directly pushing to refs/for/*.
Yongqin Liu created this request. Bero Rosenkränzer, Vishal Bhoj and Satish Patel are participating. You can reply directly to this email to add any further comments or attachments. See request details and updates for #SYS-55 https://servicedesk.linaro.org/servicedesk/customer/portal/4/SYS-55?sda_source=notification-email
- "Can not submit changes on android-patchsets.git to
dev-private-review.linaro.org for review"
Linaro Help Center sent you this message, *powered by* JIRA Service Desk http://www.atlassian.com/software/jira/service-desk
-- Best Regards, Yongqin Liu
#mailing list linaro-android@lists.linaro.org linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-android
linaro-android mailing list linaro-android@lists.linaro.org https://lists.linaro.org/mailman/listinfo/linaro-android
linaro-android@lists.linaro.org
-
Paul Sokolovsky -
YongQin Liu