Hi all,
I'm working on a PXA320 on gingerbread. After implementing the GCU graphics acceleration, I'm working on having skia and android using fixed float. It is not a patch submission but give an idea about the problem that we have.
index a10371f..93c162f 100644 --- a/WebCore/platform/graphics/skia/FloatRectSkia.cpp +++ b/WebCore/platform/graphics/skia/FloatRectSkia.cpp @@ -36,14 +36,14 @@ namespace WebCore {
FloatRect::FloatRect(const SkRect& r) - : m_location(r.fLeft, r.fTop) - , m_size(r.width(), r.height()) + : m_location(SkScalarToFloat(r.fLeft), SkScalarToFloat(r.fTop)) + , m_size(SkScalarToFloat(r.width()), SkScalarToFloat(r.height())) { }
FloatRect::operator SkRect() const { - SkRect rect = { x(), y(), right(), bottom() }; + SkRect rect = { SkFloatToScalar(x()), SkFloatToScalar(y()), SkFloatToScalar(right()), SkFloatToScalar(bottom()) }; return rect; }
This fix on the webcore help to start to render webpage. But there are several points to fix. I would like to know if there is some interest on this topic
Michael
MIchael
Have you also posted to android-platform?
On 8 March 2012 15:44, Michael Trimarchi michael@amarulasolutions.com wrote:
Hi all,
I'm working on a PXA320 on gingerbread. After implementing the GCU graphics acceleration, I'm working on having skia and android using fixed float. It is not a patch submission but give an idea about the problem that we have.
index a10371f..93c162f 100644 --- a/WebCore/platform/graphics/skia/FloatRectSkia.cpp +++ b/WebCore/platform/graphics/skia/FloatRectSkia.cpp @@ -36,14 +36,14 @@ namespace WebCore {
FloatRect::FloatRect(const SkRect& r)
- : m_location(r.fLeft, r.fTop)
- , m_size(r.width(), r.height())
- : m_location(SkScalarToFloat(r.fLeft), SkScalarToFloat(r.fTop))
- , m_size(SkScalarToFloat(r.width()), SkScalarToFloat(r.height()))
{ }
FloatRect::operator SkRect() const {
- SkRect rect = { x(), y(), right(), bottom() };
- SkRect rect = { SkFloatToScalar(x()), SkFloatToScalar(y()), SkFloatToScalar(right()), SkFloatToScalar(bottom()) };
return rect; }
This fix on the webcore help to start to render webpage. But there are several points to fix. I would like to know if there is some interest on this topic
Michael
linaro-android mailing list linaro-android@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-android
Dear Zach
On 03/09/2012 07:49 PM, Zach Pfeffer wrote:
MIchael
Have you also posted to android-platform?
done.
I have done other changes in the webkit in order to find all the point where is wrong. No luck until now to cover all the situation
Michael
On 8 March 2012 15:44, Michael Trimarchi michael@amarulasolutions.com wrote:
Hi all,
I'm working on a PXA320 on gingerbread. After implementing the GCU graphics acceleration, I'm working on having skia and android using fixed float. It is not a patch submission but give an idea about the problem that we have.
index a10371f..93c162f 100644 --- a/WebCore/platform/graphics/skia/FloatRectSkia.cpp +++ b/WebCore/platform/graphics/skia/FloatRectSkia.cpp @@ -36,14 +36,14 @@ namespace WebCore {
FloatRect::FloatRect(const SkRect& r)
- : m_location(r.fLeft, r.fTop)
- , m_size(r.width(), r.height())
- : m_location(SkScalarToFloat(r.fLeft), SkScalarToFloat(r.fTop))
- , m_size(SkScalarToFloat(r.width()), SkScalarToFloat(r.height()))
{ }
FloatRect::operator SkRect() const {
- SkRect rect = { x(), y(), right(), bottom() };
- SkRect rect = { SkFloatToScalar(x()), SkFloatToScalar(y()), SkFloatToScalar(right()), SkFloatToScalar(bottom()) }; return rect;
}
This fix on the webcore help to start to render webpage. But there are several points to fix. I would like to know if there is some interest on this topic
Michael
linaro-android mailing list linaro-android@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-android
Dear Zach
On 03/09/2012 07:49 PM, Zach Pfeffer wrote:
MIchael
Have you also posted to android-platform?
done.
I have done other changes in the webkit in order to find all the point where is wrong. No luck until now to cover all the situation
Michael
On 8 March 2012 15:44, Michael Trimarchi michael@amarulasolutions.com wrote:
Hi all,
I'm working on a PXA320 on gingerbread. After implementing the GCU graphics acceleration, I'm working on having skia and android using fixed float. It is not a patch submission but give an idea about the problem that we have.
index a10371f..93c162f 100644 --- a/WebCore/platform/graphics/skia/FloatRectSkia.cpp +++ b/WebCore/platform/graphics/skia/FloatRectSkia.cpp @@ -36,14 +36,14 @@ namespace WebCore {
FloatRect::FloatRect(const SkRect& r)
- : m_location(r.fLeft, r.fTop)
- , m_size(r.width(), r.height())
- : m_location(SkScalarToFloat(r.fLeft), SkScalarToFloat(r.fTop))
- , m_size(SkScalarToFloat(r.width()), SkScalarToFloat(r.height()))
{ }
FloatRect::operator SkRect() const {
- SkRect rect = { x(), y(), right(), bottom() };
- SkRect rect = { SkFloatToScalar(x()), SkFloatToScalar(y()), SkFloatToScalar(right()), SkFloatToScalar(bottom()) }; return rect;
}
This fix on the webcore help to start to render webpage. But there are several points to fix. I would like to know if there is some interest on this topic
Michael
linaro-android mailing list linaro-android@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-android
linaro-android@lists.linaro.org