Hello,
I have the AOSP kernel/common tree cloned, but I'm not in a full android dev environment (not using repo for all the rest of android.)
I'd like to make some minor cleanup/fix patches for the kernel, but need to setup gerrit for this repo. Can anyone share what the .gitreview file should look like for this?
Thanks
Kevin
On Wed, May 20, 2015 at 11:18 AM, Kevin Hilman khilman@linaro.org wrote:
Hello,
I have the AOSP kernel/common tree cloned, but I'm not in a full android dev environment (not using repo for all the rest of android.)
I'd like to make some minor cleanup/fix patches for the kernel, but need to setup gerrit for this repo. Can anyone share what the .gitreview file should look like for this?
So I usually just push directly to gerrit for the few patches I want to submit.
If you're pushing to AOSP, there's some older instructions here: https://wiki.linaro.org/Process/PushingBitsToAndroid
thanks -john
On Wed, May 20, 2015 at 11:37 AM, John Stultz john.stultz@linaro.org wrote:
On Wed, May 20, 2015 at 11:18 AM, Kevin Hilman khilman@linaro.org wrote:
Hello,
I have the AOSP kernel/common tree cloned, but I'm not in a full android dev environment (not using repo for all the rest of android.)
I'd like to make some minor cleanup/fix patches for the kernel, but need to setup gerrit for this repo. Can anyone share what the .gitreview file should look like for this?
So I usually just push directly to gerrit for the few patches I want to submit.
If you're pushing to AOSP, there's some older instructions here: https://wiki.linaro.org/Process/PushingBitsToAndroid
Seems like all the stuff documented there is automated by having the right magic in the .gitreview file, and then commiting changes on a test branch and running "git review" (I've used that on some other gerrit projects.) The question is just what's the right contents of the .gitreview file.
Kevin
On Wed, May 20, 2015 at 11:47 AM, Kevin Hilman khilman@linaro.org wrote:
On Wed, May 20, 2015 at 11:37 AM, John Stultz john.stultz@linaro.org wrote:
On Wed, May 20, 2015 at 11:18 AM, Kevin Hilman khilman@linaro.org wrote:
Hello,
I have the AOSP kernel/common tree cloned, but I'm not in a full android dev environment (not using repo for all the rest of android.)
I'd like to make some minor cleanup/fix patches for the kernel, but need to setup gerrit for this repo. Can anyone share what the .gitreview file should look like for this?
So I usually just push directly to gerrit for the few patches I want to submit.
If you're pushing to AOSP, there's some older instructions here: https://wiki.linaro.org/Process/PushingBitsToAndroid
Seems like all the stuff documented there is automated by having the right magic in the .gitreview file, and then commiting changes on a test branch and running "git review" (I've used that on some other gerrit projects.) The question is just what's the right contents of the .gitreview file.
Ah. I've not played with git review (or yet have it installed apparently :). Will have to check that out. thanks -john
On 21 May 2015 at 00:17, Kevin Hilman khilman@linaro.org wrote:
On Wed, May 20, 2015 at 11:37 AM, John Stultz john.stultz@linaro.org wrote:
On Wed, May 20, 2015 at 11:18 AM, Kevin Hilman khilman@linaro.org wrote:
Hello,
I have the AOSP kernel/common tree cloned, but I'm not in a full android dev environment (not using repo for all the rest of android.)
I'd like to make some minor cleanup/fix patches for the kernel, but need to setup gerrit for this repo. Can anyone share what the .gitreview file should look like for this?
So I usually just push directly to gerrit for the few patches I want to submit.
If you're pushing to AOSP, there's some older instructions here: https://wiki.linaro.org/Process/PushingBitsToAndroid
Seems like all the stuff documented there is automated by having the right magic in the .gitreview file, and then commiting changes on a test branch and running "git review" (I've used that on some other gerrit projects.) The question is just what's the right contents of the .gitreview file.
I use git commands to send patches to AOSP Gerrit for review. So, I don't use or have a .gitreview to send you as a reference at all. This wiki https://wiki.linaro.org/Platform/Systems/Gerrit might be of some help.
Regards, Amit Pundir
Kevin _______________________________________________ linaro-android mailing list linaro-android@lists.linaro.org https://lists.linaro.org/mailman/listinfo/linaro-android
On Wed, May 20, 2015 at 11:53 AM, Amit Pundir amit.pundir@linaro.org wrote:
I use git commands to send patches to AOSP Gerrit for review. So, I don't use or have a .gitreview to send you as a reference at all.
Could you describe the git command you use to do this?
Seems that git-review defaults to using ssh, but the aosp gerrit only has http auth enabled, so that's at least part of my problem.
Kevin
On Wed, May 20, 2015 at 12:26 PM, Kevin Hilman khilman@linaro.org wrote:
On Wed, May 20, 2015 at 11:53 AM, Amit Pundir amit.pundir@linaro.org wrote:
I use git commands to send patches to AOSP Gerrit for review. So, I don't use or have a .gitreview to send you as a reference at all.
Could you describe the git command you use to do this?
Ah, with http auth setup, I found the magic.
I just need to push to a remote branch with the refs/for/<branch-name>.
My first submission is now there: https://android-review.googlesource.com/#/c/151255/
linaro-android@lists.linaro.org
-
Amit Pundir -
John Stultz -
Kevin Hilman