Hi, I just check:
tnew and tdup pass after changing variable name ("table").
hload_num hstore_pri hstore_str hstore_num still fail.
On 28 August 2016 at 21:31, Dikshit, Abhishek Abhishek.Dikshit@cavium.com wrote:
After changing the variable name I am not seeing any failure. Can you check and confirm if you are still seeing the failure and what is the failure ?
On Sun, Aug 28, 2016 at 2:28 AM -0700, "Zhongwei Yao" < zhongwei.yao@linaro.org> wrote:
Thanks!
On 27 August 2016 at 03:25, Dikshit, Abhishek <Abhishek.Dikshit@cavium.com
wrote:
I will start with tnew
-----Original Message----- From: luajit [mailto:luajit-bounces@lists.linaro.org] On Behalf Of Stefan Pejic Sent: Friday, August 26, 2016 7:06 AM To: luajit@lists.linaro.org Subject: Re: Recent merged patches break test cases
Hey,
That pull request wasn't merged. Are you maybe talking about #69? https://github.com/cbaylis/luajit-aarch64/pull/69
Stefan
On 08/26/2016 08:53 AM, Zhongwei Yao wrote:
Hi, all, It seems this PL: https://github.com/cbaylis/luajit-aarch64/pull/65 introduces following breaks: tnew hload_num hstore_pri hstore_str tdup hstore_num
Is anyone working on fixing it?
-- Best regards, Zhongwei
luajit mailing list luajit@lists.linaro.org https://lists.linaro.org/mailman/listinfo/luajit
luajit mailing list luajit@lists.linaro.org https://lists.linaro.org/mailman/listinfo/luajit _______________________________________________ luajit mailing list luajit@lists.linaro.org https://lists.linaro.org/mailman/listinfo/luajit
-- Best regards, Zhongwei
The test cases mentioned below don’t fail for me.
ubuntu@crb4:~/cbaylis/luajit-aarch64/src$ ./luajit -jon ../test/hload_num.lua ubuntu@crb4:~/cbaylis/luajit-aarch64/src$ ./luajit -jon ../test/hstore_pri.lua ubuntu@crb4:~/cbaylis/luajit-aarch64/src$ ./luajit -jon ../test/hstore_str.lua ubuntu@crb4:~/cbaylis/luajit-aarch64/src$ ./luajit -jon ../test/hstore_num.lua ubuntu@crb4:~/cbaylis/luajit-aarch64/src$
ubuntu@crb4:~/cbaylis/luajit-aarch64$ ../../gitinfo == Remote URL: origin https://github.com/cbaylis/luajit-aarch64.git (fetch) origin https://github.com/cbaylis/luajit-aarch64.git (push) == Local Branches: * aarch64-v2.1-new
== Configuration (.git/config) [core] repositoryformatversion = 0 filemode = true bare = false logallrefupdates = true [remote "origin"] url = https://github.com/cbaylis/luajit-aarch64.git fetch = +refs/heads/*:refs/remotes/origin/* [branch "aarch64-v2.1-new"] remote = origin merge = refs/heads/aarch64-v2.1-new
== Most Recent Commit commit cbab6fce779c3e506293fd0a0dc6ffcd9a0862a1 Merge: 8cee96c 5889f2a Author: cbaylis charles.baylis@linaro.org Date: Mon Aug 29 15:53:12 2016 +0100
Merge pull request #71 from sindrom91/tbar
TBAR: Fix 64-bit constant allocation
Should I use a different branch or different options ? BTW I tried the “make test” command and that works too.
Abhishek Dikshit
From: Zhongwei Yao [mailto:zhongwei.yao@linaro.org] Sent: Sunday, August 28, 2016 7:01 PM To: Dikshit, Abhishek Cc: luajit@lists.linaro.org Subject: Re: Recent merged patches break test cases
Hi, I just check:
tnew and tdup pass after changing variable name ("table").
hload_num hstore_pri hstore_str hstore_num still fail.
On 28 August 2016 at 21:31, Dikshit, Abhishek <Abhishek.Dikshit@cavium.commailto:Abhishek.Dikshit@cavium.com> wrote:
After changing the variable name I am not seeing any failure. Can you check and confirm if you are still seeing the failure and what is the failure ?
On Sun, Aug 28, 2016 at 2:28 AM -0700, "Zhongwei Yao" <zhongwei.yao@linaro.orgmailto:zhongwei.yao@linaro.org> wrote: Thanks!
On 27 August 2016 at 03:25, Dikshit, Abhishek <Abhishek.Dikshit@cavium.commailto:Abhishek.Dikshit@cavium.com> wrote: I will start with tnew
-----Original Message----- From: luajit [mailto:luajit-bounces@lists.linaro.orgmailto:luajit-bounces@lists.linaro.org] On Behalf Of Stefan Pejic Sent: Friday, August 26, 2016 7:06 AM To: luajit@lists.linaro.orgmailto:luajit@lists.linaro.org Subject: Re: Recent merged patches break test cases
Hey,
That pull request wasn't merged. Are you maybe talking about #69? https://github.com/cbaylis/luajit-aarch64/pull/69
Stefan
On 08/26/2016 08:53 AM, Zhongwei Yao wrote:
Hi, all, It seems this PL: https://github.com/cbaylis/luajit-aarch64/pull/65 introduces following breaks: tnew hload_num hstore_pri hstore_str tdup hstore_num
Is anyone working on fixing it?
-- Best regards, Zhongwei
luajit mailing list luajit@lists.linaro.orgmailto:luajit@lists.linaro.org https://lists.linaro.org/mailman/listinfo/luajit
_______________________________________________ luajit mailing list luajit@lists.linaro.orgmailto:luajit@lists.linaro.org https://lists.linaro.org/mailman/listinfo/luajit _______________________________________________ luajit mailing list luajit@lists.linaro.orgmailto:luajit@lists.linaro.org https://lists.linaro.org/mailman/listinfo/luajit
-- Best regards, Zhongwei
-- Best regards, Zhongwei
Sorry, I have not checked the latest changes.
After merging Stefan's lasted patch: https://github.com/cbaylis/luajit-aarch64/pull/71
hload_num, hstore_pri, hstore_str, hstore_num pass now.
On 30 August 2016 at 02:21, Dikshit, Abhishek Abhishek.Dikshit@cavium.com wrote:
The test cases mentioned below don’t fail for me.
ubuntu@crb4:~/cbaylis/luajit-aarch64/src$ ./luajit -jon ../test/hload_num.lua
ubuntu@crb4:~/cbaylis/luajit-aarch64/src$ ./luajit -jon ../test/hstore_pri.lua
ubuntu@crb4:~/cbaylis/luajit-aarch64/src$ ./luajit -jon ../test/hstore_str.lua
ubuntu@crb4:~/cbaylis/luajit-aarch64/src$ ./luajit -jon ../test/hstore_num.lua
ubuntu@crb4:~/cbaylis/luajit-aarch64/src$
ubuntu@crb4:~/cbaylis/luajit-aarch64$ ../../gitinfo
== Remote URL: origin https://github.com/cbaylis/luajit-aarch64.git (fetch)
origin https://github.com/cbaylis/luajit-aarch64.git (push)
== Local Branches:
- aarch64-v2.1-new
== Configuration (.git/config)
[core]
repositoryformatversion = 0 filemode = true bare = false logallrefupdates = true[remote "origin"]
url = https://github.com/cbaylis/luajit-aarch64.git fetch = +refs/heads/*:refs/remotes/origin/*[branch "aarch64-v2.1-new"]
remote = origin merge = refs/heads/aarch64-v2.1-new== Most Recent Commit
commit cbab6fce779c3e506293fd0a0dc6ffcd9a0862a1
Merge: 8cee96c 5889f2a
Author: cbaylis charles.baylis@linaro.org
Date: Mon Aug 29 15:53:12 2016 +0100
Merge pull request #71 from sindrom91/tbar TBAR: Fix 64-bit constant allocationShould I use a different branch or different options ? BTW I tried the “make test” command and that works too.
Abhishek Dikshit
*From:* Zhongwei Yao [mailto:zhongwei.yao@linaro.org] *Sent:* Sunday, August 28, 2016 7:01 PM *To:* Dikshit, Abhishek *Cc:* luajit@lists.linaro.org
*Subject:* Re: Recent merged patches break test cases
Hi,
I just check:
tnew and tdup pass after changing variable name ("table").
hload_num hstore_pri hstore_str hstore_num still fail.
On 28 August 2016 at 21:31, Dikshit, Abhishek Abhishek.Dikshit@cavium.com wrote:
After changing the variable name I am not seeing any failure. Can you check and confirm if you are still seeing the failure and what is the failure ?
On Sun, Aug 28, 2016 at 2:28 AM -0700, "Zhongwei Yao" < zhongwei.yao@linaro.org> wrote:
Thanks!
On 27 August 2016 at 03:25, Dikshit, Abhishek Abhishek.Dikshit@cavium.com wrote:
I will start with tnew
-----Original Message----- From: luajit [mailto:luajit-bounces@lists.linaro.org] On Behalf Of Stefan Pejic Sent: Friday, August 26, 2016 7:06 AM To: luajit@lists.linaro.org Subject: Re: Recent merged patches break test cases
Hey,
That pull request wasn't merged. Are you maybe talking about #69? https://github.com/cbaylis/luajit-aarch64/pull/69
Stefan
On 08/26/2016 08:53 AM, Zhongwei Yao wrote:
Hi, all, It seems this PL: https://github.com/cbaylis/luajit-aarch64/pull/65 introduces following breaks: tnew hload_num hstore_pri hstore_str tdup hstore_num
Is anyone working on fixing it?
-- Best regards, Zhongwei
luajit mailing list luajit@lists.linaro.org https://lists.linaro.org/mailman/listinfo/luajit
luajit mailing list luajit@lists.linaro.org https://lists.linaro.org/mailman/listinfo/luajit _______________________________________________ luajit mailing list luajit@lists.linaro.org https://lists.linaro.org/mailman/listinfo/luajit
--
Best regards,
Zhongwei
--
Best regards,
Zhongwei
Great. What else I can start working on ?
From: Zhongwei Yao [mailto:zhongwei.yao@linaro.org] Sent: Monday, August 29, 2016 6:55 PM To: Dikshit, Abhishek Cc: luajit@lists.linaro.org Subject: Re: Recent merged patches break test cases
Sorry, I have not checked the latest changes.
After merging Stefan's lasted patch: https://github.com/cbaylis/luajit-aarch64/pull/71
hload_num, hstore_pri, hstore_str, hstore_num pass now.
On 30 August 2016 at 02:21, Dikshit, Abhishek <Abhishek.Dikshit@cavium.commailto:Abhishek.Dikshit@cavium.com> wrote: The test cases mentioned below don’t fail for me.
ubuntu@crb4:~/cbaylis/luajit-aarch64/src$ ./luajit -jon ../test/hload_num.lua ubuntu@crb4:~/cbaylis/luajit-aarch64/src$ ./luajit -jon ../test/hstore_pri.lua ubuntu@crb4:~/cbaylis/luajit-aarch64/src$ ./luajit -jon ../test/hstore_str.lua ubuntu@crb4:~/cbaylis/luajit-aarch64/src$ ./luajit -jon ../test/hstore_num.lua ubuntu@crb4:~/cbaylis/luajit-aarch64/src$
ubuntu@crb4:~/cbaylis/luajit-aarch64$ ../../gitinfo == Remote URL: origin https://github.com/cbaylis/luajit-aarch64.git (fetch) origin https://github.com/cbaylis/luajit-aarch64.git (push) == Local Branches: * aarch64-v2.1-new
== Configuration (.git/config) [core] repositoryformatversion = 0 filemode = true bare = false logallrefupdates = true [remote "origin"] url = https://github.com/cbaylis/luajit-aarch64.git fetch = +refs/heads/*:refs/remotes/origin/* [branch "aarch64-v2.1-new"] remote = origin merge = refs/heads/aarch64-v2.1-new
== Most Recent Commit commit cbab6fce779c3e506293fd0a0dc6ffcd9a0862a1 Merge: 8cee96c 5889f2a Author: cbaylis <charles.baylis@linaro.orgmailto:charles.baylis@linaro.org> Date: Mon Aug 29 15:53:12 2016 +0100
Merge pull request #71 from sindrom91/tbar
TBAR: Fix 64-bit constant allocation
Should I use a different branch or different options ? BTW I tried the “make test” command and that works too.
Abhishek Dikshit
From: Zhongwei Yao [mailto:zhongwei.yao@linaro.orgmailto:zhongwei.yao@linaro.org] Sent: Sunday, August 28, 2016 7:01 PM To: Dikshit, Abhishek Cc: luajit@lists.linaro.orgmailto:luajit@lists.linaro.org
Subject: Re: Recent merged patches break test cases
Hi, I just check:
tnew and tdup pass after changing variable name ("table").
hload_num hstore_pri hstore_str hstore_num still fail.
On 28 August 2016 at 21:31, Dikshit, Abhishek <Abhishek.Dikshit@cavium.commailto:Abhishek.Dikshit@cavium.com> wrote:
After changing the variable name I am not seeing any failure. Can you check and confirm if you are still seeing the failure and what is the failure ?
On Sun, Aug 28, 2016 at 2:28 AM -0700, "Zhongwei Yao" <zhongwei.yao@linaro.orgmailto:zhongwei.yao@linaro.org> wrote: Thanks!
On 27 August 2016 at 03:25, Dikshit, Abhishek <Abhishek.Dikshit@cavium.commailto:Abhishek.Dikshit@cavium.com> wrote: I will start with tnew
-----Original Message----- From: luajit [mailto:luajit-bounces@lists.linaro.orgmailto:luajit-bounces@lists.linaro.org] On Behalf Of Stefan Pejic Sent: Friday, August 26, 2016 7:06 AM To: luajit@lists.linaro.orgmailto:luajit@lists.linaro.org Subject: Re: Recent merged patches break test cases
Hey,
That pull request wasn't merged. Are you maybe talking about #69? https://github.com/cbaylis/luajit-aarch64/pull/69
Stefan
On 08/26/2016 08:53 AM, Zhongwei Yao wrote:
Hi, all, It seems this PL: https://github.com/cbaylis/luajit-aarch64/pull/65 introduces following breaks: tnew hload_num hstore_pri hstore_str tdup hstore_num
Is anyone working on fixing it?
-- Best regards, Zhongwei
luajit mailing list luajit@lists.linaro.orgmailto:luajit@lists.linaro.org https://lists.linaro.org/mailman/listinfo/luajit
_______________________________________________ luajit mailing list luajit@lists.linaro.orgmailto:luajit@lists.linaro.org https://lists.linaro.org/mailman/listinfo/luajit _______________________________________________ luajit mailing list luajit@lists.linaro.orgmailto:luajit@lists.linaro.org https://lists.linaro.org/mailman/listinfo/luajit
-- Best regards, Zhongwei
-- Best regards, Zhongwei
-- Best regards, Zhongwei
Running "make skipped" shows following cases fail: fpm_cos addov div xload_int mod fref href newref gcstep
I'm looking at "gcstep" case for now, and probably will look at "xload_int" later. I think you could take a look at them if you interested.
Another one is checking tests in https://github.com/LuaJIT/LuaJIT-test-cleanup.
On 31 August 2016 at 01:57, Dikshit, Abhishek Abhishek.Dikshit@cavium.com wrote:
Great. What else I can start working on ?
*From:* Zhongwei Yao [mailto:zhongwei.yao@linaro.org] *Sent:* Monday, August 29, 2016 6:55 PM
*To:* Dikshit, Abhishek *Cc:* luajit@lists.linaro.org *Subject:* Re: Recent merged patches break test cases
Sorry, I have not checked the latest changes.
After merging Stefan's lasted patch:
https://github.com/cbaylis/luajit-aarch64/pull/71
hload_num, hstore_pri, hstore_str, hstore_num pass now.
On 30 August 2016 at 02:21, Dikshit, Abhishek Abhishek.Dikshit@cavium.com wrote:
The test cases mentioned below don’t fail for me.
ubuntu@crb4:~/cbaylis/luajit-aarch64/src$ ./luajit -jon ../test/hload_num.lua
ubuntu@crb4:~/cbaylis/luajit-aarch64/src$ ./luajit -jon ../test/hstore_pri.lua
ubuntu@crb4:~/cbaylis/luajit-aarch64/src$ ./luajit -jon ../test/hstore_str.lua
ubuntu@crb4:~/cbaylis/luajit-aarch64/src$ ./luajit -jon ../test/hstore_num.lua
ubuntu@crb4:~/cbaylis/luajit-aarch64/src$
ubuntu@crb4:~/cbaylis/luajit-aarch64$ ../../gitinfo
== Remote URL: origin https://github.com/cbaylis/luajit-aarch64.git (fetch)
origin https://github.com/cbaylis/luajit-aarch64.git (push)
== Local Branches:
- aarch64-v2.1-new
== Configuration (.git/config)
[core]
repositoryformatversion = 0 filemode = true bare = false logallrefupdates = true[remote "origin"]
url = https://github.com/cbaylis/luajit-aarch64.git fetch = +refs/heads/*:refs/remotes/origin/*[branch "aarch64-v2.1-new"]
remote = origin merge = refs/heads/aarch64-v2.1-new== Most Recent Commit
commit cbab6fce779c3e506293fd0a0dc6ffcd9a0862a1
Merge: 8cee96c 5889f2a
Author: cbaylis charles.baylis@linaro.org
Date: Mon Aug 29 15:53:12 2016 +0100
Merge pull request #71 from sindrom91/tbar TBAR: Fix 64-bit constant allocationShould I use a different branch or different options ? BTW I tried the “make test” command and that works too.
Abhishek Dikshit
*From:* Zhongwei Yao [mailto:zhongwei.yao@linaro.org] *Sent:* Sunday, August 28, 2016 7:01 PM *To:* Dikshit, Abhishek *Cc:* luajit@lists.linaro.org
*Subject:* Re: Recent merged patches break test cases
Hi,
I just check:
tnew and tdup pass after changing variable name ("table").
hload_num hstore_pri hstore_str hstore_num still fail.
On 28 August 2016 at 21:31, Dikshit, Abhishek Abhishek.Dikshit@cavium.com wrote:
After changing the variable name I am not seeing any failure. Can you check and confirm if you are still seeing the failure and what is the failure ?
On Sun, Aug 28, 2016 at 2:28 AM -0700, "Zhongwei Yao" < zhongwei.yao@linaro.org> wrote:
Thanks!
On 27 August 2016 at 03:25, Dikshit, Abhishek Abhishek.Dikshit@cavium.com wrote:
I will start with tnew
-----Original Message----- From: luajit [mailto:luajit-bounces@lists.linaro.org] On Behalf Of Stefan Pejic Sent: Friday, August 26, 2016 7:06 AM To: luajit@lists.linaro.org Subject: Re: Recent merged patches break test cases
Hey,
That pull request wasn't merged. Are you maybe talking about #69? https://github.com/cbaylis/luajit-aarch64/pull/69
Stefan
On 08/26/2016 08:53 AM, Zhongwei Yao wrote:
Hi, all, It seems this PL: https://github.com/cbaylis/luajit-aarch64/pull/65 introduces following breaks: tnew hload_num hstore_pri hstore_str tdup hstore_num
Is anyone working on fixing it?
-- Best regards, Zhongwei
luajit mailing list luajit@lists.linaro.org https://lists.linaro.org/mailman/listinfo/luajit
luajit mailing list luajit@lists.linaro.org https://lists.linaro.org/mailman/listinfo/luajit _______________________________________________ luajit mailing list luajit@lists.linaro.org https://lists.linaro.org/mailman/listinfo/luajit
--
Best regards,
Zhongwei
--
Best regards,
Zhongwei
--
Best regards,
Zhongwei
On 31 August 2016 at 07:22, Zhongwei Yao zhongwei.yao@linaro.org wrote:
Running "make skipped" shows following cases fail: fpm_cos addov div xload_int mod fref href newref gcstep
I'm looking at "gcstep" case for now, and probably will look at "xload_int" later. I think you could take a look at them if you interested.
Another one is checking tests in https://github.com/LuaJIT/LuaJIT-test-cleanup.
FYI I'm looking at div.
Just FYI fpm_cos fails not only on ARM64 but also on ARM32 and X64 even on v2.1 branch. div and addov fail on x64 and ARM32 but not in branch v2.1 so I am guessing a merge from v2.1 branch should fix them.
I guess I can start on mod if no one is working on it.
-----Original Message----- From: Charles Baylis [mailto:charles.baylis@linaro.org] Sent: Wednesday, August 31, 2016 10:49 AM To: Zhongwei Yao Cc: Dikshit, Abhishek; luajit@lists.linaro.org Subject: Re: Recent merged patches break test cases
On 31 August 2016 at 07:22, Zhongwei Yao zhongwei.yao@linaro.org wrote:
Running "make skipped" shows following cases fail: fpm_cos addov div xload_int mod fref href newref gcstep
I'm looking at "gcstep" case for now, and probably will look at "xload_int" later. I think you could take a look at them if you interested.
Another one is checking tests in https://github.com/LuaJIT/LuaJIT-test-cleanup.
FYI I'm looking at div.
-
Charles Baylis -
Dikshit, Abhishek -
Zhongwei Yao