On Fri, Mar 15, 2019 at 05:16:06PM -0600, Anibal Limon wrote:
I sent a review request,
https://review.linaro.org/c/openembedded/meta-linaro/+/30779
Any updates? I'm still getting a lot of warnings during parsing, e.g.:
WARNING: .../meta-linaro/meta-linaro-toolchain/recipes-core/glibc/glibc_linaro-2.20.bb: Unable to get checksum for glibc SRC_URI entry ld.so.conf: file could not be found WARNING: .../meta-linaro/meta-linaro-toolchain/recipes-core/glibc/glibc_linaro-2.20.bb: Unable to get checksum for glibc SRC_URI entry 0022-Add-ILP32-to-makefiles.patch: file could not be found
Denys
On Fri, 15 Mar 2019 at 14:46, Anibal Limon anibal.limon@linaro.org wrote:
On Fri, Mar 15, 2019, 1:54 PM Denys Dmytriyenko denis@denix.org wrote:
On Fri, Mar 15, 2019 at 09:55:21AM -0600, Anibal Limon wrote:
Hi Denys,
I'm not see a PV set on glibc_linaro-2.20.bb, there is a PV set on gcc recipes with linaro-2.20.
As my previous email states - PV is set by the filename. Moreover, you are erroneously referrring to the recipe as "glibc_linaro", while it's "glibc" instead. And "linaro-2.20" is actually recipe's PV. The underscore in the filename separates recipe name from recipe version. From the manual:
https://www.yoctoproject.org/docs/1.6/bitbake-user-manual/bitbake-user-manua...
| In this example, a recipe called "something_1.2.3.bb" sets PN to "something" | and PV to "1.2.3".
Hence, in this case, glibc_linaro-2.20.bb used to set PN to "glibc" and PV to "linaro-2.20". And it used to work for years.
Moreover, since ${FILESPATH} below expects ${FILE_DIRNAME}/glibc-${PV} and there's "glibc-linaro-2.20" directory with whole bunch of patches:
https://git.linaro.org/openembedded/meta-linaro.git/tree/meta-linaro-toolcha...
So, with your change, it would instead try to look into "glibc-2.20" and fail to find any patches. Not even sure how it was tested...
You are right, I not see the error because I'm using upstream glibc (2.29) and the build didn't fail.
I will update the PV in the common file.
Regards, Anibal
-- Denys
... $ git grep PV . glibc-linaro-2.20/eglibc-ppc8xx-cache-line-workaround.patch:+ reads
from
the PVR register. */ glibc-linaro-2.20/eglibc-ppc8xx-cache-line-workaround.patch:+
emulates
PowerPC mfspr reads from the PVR register. */ glibc_linaro-2.20.bb:SRC_URI = "
http://releases.linaro.org/archive/%24%7BMMYY%7D/components/toolchain/glibc-...
\ glibc_linaro-2.20.bb:S = "${WORKDIR}/glibc-${PV}-${RELEASE}" glibc_linaro-2.20.bb:FILESPATH = "${@base_set_filespath([ '${FILE_DIRNAME}/glibc-${PV}', '${FILE_DIRNAME}/glibc', '${FILE_DIRNAME}/files', '${FILE_DIRNAME}' ], d)}" glibc_linaro.inc:PV = "2.20" ...
What is the error that you have noticed?
Regards, Anibal
On Fri, 8 Mar 2019 at 14:32, Denys Dmytriyenko denis@denix.org wrote:
https://git.linaro.org/openembedded/meta-linaro.git/commit/?id=768925270cc24...
meta-linaro-toolchain: Set PV on glibc_linaro Recently a common file was introudced to set PV for glibc [1] in oe-core causing failures becuase glibc_linaro is trying to download the latest oe-core version (2.29).
[1]
https://git.openembedded.org/openembedded-core/commit/?id=41093cb6c6
Change-Id: I5c99c25a953f00a64614046ba40e578795553bc1 Signed-off-by: Aníbal Limón anibal.limon@linaro.org
The problem is that all those modified recipes already had PV set in
their
filename and it was "linaro-2.20", not just "2.20".
-- Denys