Ard,
I think it depends on the license behind the click through.
The fact that there is another .h file with the same content under a BSD license is good data point. However, that other .h file does not reference the spec with the click through license, so it is not clear where the define values come from. I looked at the root of that tree, and it has a Readme.md that has a link to a Notice.md that has a link to a Notice.md in another repository that then has a link to the same specs that require the click through.
https://github.com/OP-TEE/optee_client/blob/master/README.md https://github.com/OP-TEE/optee_client/blob/master/Notice.md https://github.com/OP-TEE/optee_os/blob/master/Notice.md https://globalplatform.org/specs-library/
Can you explain how this other project is using spec content that requires a click through license.
Thanks,
Mike
-----Original Message----- From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] Sent: Tuesday, September 25, 2018 1:32 AM To: Sumit Garg sumit.garg@linaro.org Cc: Kinney, Michael D michael.d.kinney@intel.com; edk2-devel@lists.01.org; tee-dev@lists.linaro.org; Leif Lindholm leif.lindholm@linaro.org; Daniel Thompson daniel.thompson@linaro.org; Matteo Carlini Matteo.Carlini@arm.com; Achin Gupta Achin.Gupta@arm.com; Udit Kumar udit.kumar@nxp.com; Gao, Liming liming.gao@intel.com Subject: Re: [edk2][PATCH v2 1/2] MdePkg/IndustryStandard: Add Global Plaform header file
On Tue, 25 Sep 2018 at 10:27, Sumit Garg sumit.garg@linaro.org wrote:
Thanks Mike for your comments.
On Mon, 24 Sep 2018 at 22:20, Kinney, Michael D michael.d.kinney@intel.com wrote:
Hi Ard,
The initial content is only from the TEE Client API
Specification.
I noticed that there is an errata to that spec as
well. Does this
content follow the errata?
Yes.
I also noticed that the specifications require the
acceptance of
an additional license to view the contents. Is
there a version of
the content for this include file available that
does not require
the acceptance of an additional license?
Yes, following is another version of the content for
this include file:
TEE/optee_client/blob/master/public/tee_client_api.h#L16 3
Thanks Sumit.
Mike,
are you saying this content should not be [click through] license encumbered if we want to put it into MdePkg as an industry standard?
-----Original Message----- From: Ard Biesheuvel
[mailto:ard.biesheuvel@linaro.org]
Sent: Monday, September 24, 2018 1:26 AM To: Sumit Garg sumit.garg@linaro.org Cc: edk2-devel@lists.01.org; tee-
dev@lists.linaro.org;
Leif Lindholm leif.lindholm@linaro.org; Daniel Thompson daniel.thompson@linaro.org; Matteo
Carlini
Matteo.Carlini@arm.com; Achin Gupta Achin.Gupta@arm.com; Udit Kumar
Kinney, Michael D michael.d.kinney@intel.com;
Gao,
Liming liming.gao@intel.com Subject: Re: [edk2][PATCH v2 1/2] MdePkg/IndustryStandard: Add Global Plaform header
file
On Sat, 22 Sep 2018 at 01:15, Ard Biesheuvel ard.biesheuvel@linaro.org wrote:
On 27 August 2018 at 04:50, Sumit Garg
sumit.garg@linaro.org wrote:
Add Global Plaform header file specific to TEE
Client API Specification v1
<http://www.globalplatform.org/specificationsdevice.asp
.
Cc: Michael D Kinney
Cc: Liming Gao liming.gao@intel.com Cc: Ard Biesheuvel ard.biesheuvel@linaro.org Cc: Leif Lindholm leif.lindholm@linaro.org Contributed-under: TianoCore Contribution
Agreement
1.1
Signed-off-by: Sumit Garg
Acked-by: Ard Biesheuvel
Mike,
The header file is a bit light on content at
introduction, but as
discussed online, we can add stuff as we go for
other
use cases.
... as discussed *offline*
MdePkg/Include/IndustryStandard/GlobalPlatform.h |
27 ++++++++++++++++++++++++
1 file changed, 27 insertions(+) create mode 100644
MdePkg/Include/IndustryStandard/GlobalPlatform.h
diff --git
a/MdePkg/Include/IndustryStandard/GlobalPlatform.h b/MdePkg/Include/IndustryStandard/GlobalPlatform.h
new file mode 100644 index 000000000000..72c5af4ef588 --- /dev/null +++
b/MdePkg/Include/IndustryStandard/GlobalPlatform.h
@@ -0,0 +1,27 @@ +/** @file
- Standardized Global Platform header file.
GlobalPlatform TEE Client API
- Specification v1.0:
<http://www.globalplatform.org/specificationsdevice.asp
- Copyright (c) 2018, Linaro Ltd. All rights
reserved.<BR>
- This program and the accompanying materials
- are licensed and made available under the
terms
and conditions of the BSD License
- which accompanies this distribution. The
full
text of the license may be found at
license.php
- THE PROGRAM IS DISTRIBUTED UNDER THE BSD
LICENSE
ON AN "AS IS" BASIS,
- WITHOUT WARRANTIES OR REPRESENTATIONS OF
ANY
KIND, EITHER EXPRESS OR IMPLIED.
+**/
+#ifndef _GLOBAL_PLATFORM_H_ +#define _GLOBAL_PLATFORM_H_
+#define TEEC_ORIGIN_COMMS
0x00000002
+#define TEEC_SUCCESS
0x00000000
+#define TEEC_ERROR_BAD_PARAMETERS
0xFFFF0006
+#define TEEC_ERROR_OUT_OF_MEMORY
0xFFFF000C
+#define TEEC_ERROR_COMMUNICATION
0xFFFF000E
+#endif
2.7.4