Re: [Tee-dev] [PATCH v5 07/10] xen/arm: optee: add support for arbitrary shared memory

Hi Volodymyr,

On 21/05/2019 22:26, Volodymyr Babchuk wrote:

• while ( pg_count )
• {

•    struct page_info *page;
  

•    if ( idx == 0 )
  

•    {
  

•        guest_pg = get_domain_ram_page(gfn);
  

•        if ( !guest_pg )
  

•            return -EINVAL;
  

•        guest_data = __map_domain_page(guest_pg);
  

•        xen_data = __map_domain_page(xen_pgs);
  

•    }
  

•    /*
  

•     * TODO: That function can pin up to 64MB of guest memory by
  

•     * calling lookup_and_pin_guest_ram_addr() 16384 times.
  

I can't find the BUILD_BUG_ON(PAGE_SIZE != 4096) as I requested before.

•     * This is considered insecure and should be fixed in the future.
  

Well, it is not "considered", it is insecure as the guest would be able to delay processing other guest for some times.

So how about:

"This should be addressed before declaring OP-TEE security supported".

With that:

Acked-by: Julien Grall julien.grall@arm.com

•     */
  

Cheers,