On Wed, Jan 8, 2020 at 8:03 AM Thomas, Rijo-john Rijo-john.Thomas@amd.com wrote:

+linux-crypto

On 07/01/20 8:06 pm, Colin King wrote:

...

From: Colin Ian King colin.king@canonical.com

Currently the memory allocation failure checks on drv_data and amdtee are using IS_ERR rather than checking for a null pointer. Fix these checks to use the conventional null pointer check.

Addresses-Coverity: ("Dereference null return") Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver") Signed-off-by: Colin Ian King colin.king@canonical.com

Reviewed-by: Rijo Thomas Rijo-john.Thomas@amd.com

Acked-by: Jens Wiklander jens.wiklander@linaro.org

Thanks, Jens

...

---

drivers/tee/amdtee/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tee/amdtee/core.c b/drivers/tee/amdtee/core.c index 9d0cee1c837f..5fda810c79dc 100644 --- a/drivers/tee/amdtee/core.c +++ b/drivers/tee/amdtee/core.c @@ -444,11 +444,11 @@ static int __init amdtee_driver_init(void) goto err_fail;

  drv_data = kzalloc(sizeof(*drv_data), GFP_KERNEL);

• if (IS_ERR(drv_data))
  

• if (!drv_data)
          return -ENOMEM;
  
  amdtee = kzalloc(sizeof(*amdtee), GFP_KERNEL);
  

• if (IS_ERR(amdtee)) {
  

• if (!amdtee) {
          rc = -ENOMEM;
          goto err_kfree_drv_data;
  }