There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant.
This allows to hide the uuid_t internals.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com --- drivers/tee/optee/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tee/optee/device.c b/drivers/tee/optee/device.c index e3a148521ec1d..2ecc6993f48bb 100644 --- a/drivers/tee/optee/device.c +++ b/drivers/tee/optee/device.c @@ -107,7 +107,7 @@ int optee_enumerate_devices(void) return -ENODEV;
/* Open session with device enumeration pseudo TA */ - memcpy(sess_arg.uuid, pta_uuid.b, TEE_IOCTL_UUID_LEN); + export_uuid(sess_arg.uuid, &pta_uuid); sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC; sess_arg.num_params = 0;
On Wed, 22 Apr 2020 at 19:51, Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant.
This allows to hide the uuid_t internals.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
drivers/tee/optee/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Sumit Garg sumit.garg@linaro.org
diff --git a/drivers/tee/optee/device.c b/drivers/tee/optee/device.c index e3a148521ec1d..2ecc6993f48bb 100644 --- a/drivers/tee/optee/device.c +++ b/drivers/tee/optee/device.c @@ -107,7 +107,7 @@ int optee_enumerate_devices(void) return -ENODEV;
/* Open session with device enumeration pseudo TA */
memcpy(sess_arg.uuid, pta_uuid.b, TEE_IOCTL_UUID_LEN);
export_uuid(sess_arg.uuid, &pta_uuid); sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC; sess_arg.num_params = 0;-- 2.26.1
Tee-dev mailing list Tee-dev@lists.linaro.org https://lists.linaro.org/mailman/listinfo/tee-dev
On Thu, Apr 23, 2020 at 10:51:45AM +0530, Sumit Garg wrote:
On Wed, 22 Apr 2020 at 19:51, Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant.
This allows to hide the uuid_t internals.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
drivers/tee/optee/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Sumit Garg sumit.garg@linaro.org
Thanks!
Can this be applied eventually?
diff --git a/drivers/tee/optee/device.c b/drivers/tee/optee/device.c index e3a148521ec1d..2ecc6993f48bb 100644 --- a/drivers/tee/optee/device.c +++ b/drivers/tee/optee/device.c @@ -107,7 +107,7 @@ int optee_enumerate_devices(void) return -ENODEV;
/* Open session with device enumeration pseudo TA */
memcpy(sess_arg.uuid, pta_uuid.b, TEE_IOCTL_UUID_LEN);
export_uuid(sess_arg.uuid, &pta_uuid); sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC; sess_arg.num_params = 0;-- 2.26.1
Tee-dev mailing list Tee-dev@lists.linaro.org https://lists.linaro.org/mailman/listinfo/tee-dev
On Wed, Jun 17, 2020 at 05:15:17PM +0300, Andy Shevchenko wrote:
On Thu, Apr 23, 2020 at 10:51:45AM +0530, Sumit Garg wrote:
On Wed, 22 Apr 2020 at 19:51, Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant.
This allows to hide the uuid_t internals.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
drivers/tee/optee/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Sumit Garg sumit.garg@linaro.org
Thanks!
Can this be applied eventually?
Thanks for the reminder, I'm picking up this now.
Cheers, Jens
diff --git a/drivers/tee/optee/device.c b/drivers/tee/optee/device.c index e3a148521ec1d..2ecc6993f48bb 100644 --- a/drivers/tee/optee/device.c +++ b/drivers/tee/optee/device.c @@ -107,7 +107,7 @@ int optee_enumerate_devices(void) return -ENODEV;
/* Open session with device enumeration pseudo TA */
memcpy(sess_arg.uuid, pta_uuid.b, TEE_IOCTL_UUID_LEN);
export_uuid(sess_arg.uuid, &pta_uuid); sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC; sess_arg.num_params = 0;-- 2.26.1
Tee-dev mailing list Tee-dev@lists.linaro.org https://lists.linaro.org/mailman/listinfo/tee-dev
-- With Best Regards, Andy Shevchenko
On Thu, Jun 18, 2020 at 12:16:01PM +0200, Jens Wiklander wrote:
On Wed, Jun 17, 2020 at 05:15:17PM +0300, Andy Shevchenko wrote:
On Thu, Apr 23, 2020 at 10:51:45AM +0530, Sumit Garg wrote:
On Wed, 22 Apr 2020 at 19:51, Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant.
This allows to hide the uuid_t internals.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
drivers/tee/optee/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Sumit Garg sumit.garg@linaro.org
Thanks!
Can this be applied eventually?
Thanks for the reminder, I'm picking up this now.
Any tree I can see it in? It seems Linux Next is missing it.
Hi Andy,
On Mon, Oct 12, 2020 at 7:21 PM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
On Thu, Jun 18, 2020 at 12:16:01PM +0200, Jens Wiklander wrote:
On Wed, Jun 17, 2020 at 05:15:17PM +0300, Andy Shevchenko wrote:
On Thu, Apr 23, 2020 at 10:51:45AM +0530, Sumit Garg wrote:
On Wed, 22 Apr 2020 at 19:51, Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant.
This allows to hide the uuid_t internals.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
drivers/tee/optee/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Sumit Garg sumit.garg@linaro.org
Thanks!
Can this be applied eventually?
Thanks for the reminder, I'm picking up this now.
Any tree I can see it in? It seems Linux Next is missing it.
I can't find it either. Apologies, I must have missed sending it again. I have sent a pull request to arm-soc now as you can see.
Thanks, Jens
On Wed, Apr 22, 2020 at 04:00:47PM +0300, Andy Shevchenko wrote:
There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant.
This allows to hide the uuid_t internals.
Any comment on this?
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
drivers/tee/optee/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tee/optee/device.c b/drivers/tee/optee/device.c index e3a148521ec1d..2ecc6993f48bb 100644 --- a/drivers/tee/optee/device.c +++ b/drivers/tee/optee/device.c @@ -107,7 +107,7 @@ int optee_enumerate_devices(void) return -ENODEV; /* Open session with device enumeration pseudo TA */
- memcpy(sess_arg.uuid, pta_uuid.b, TEE_IOCTL_UUID_LEN);
- export_uuid(sess_arg.uuid, &pta_uuid); sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC; sess_arg.num_params = 0;
2.26.1
On Thu, Jun 18, 2020 at 01:55:29PM +0300, Andy Shevchenko wrote:
On Wed, Apr 22, 2020 at 04:00:47PM +0300, Andy Shevchenko wrote:
There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant.
This allows to hide the uuid_t internals.
Any comment on this?
Sorry for the noise, I replied to a wrong thread.
-
Andy Shevchenko -
Jens Wiklander -
Sumit Garg