There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant.
This allows to hide the uuid_t internals.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com --- drivers/firmware/broadcom/tee_bnxt_fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c index ed10da5313e8..4cf0c2576037 100644 --- a/drivers/firmware/broadcom/tee_bnxt_fw.c +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c @@ -197,7 +197,7 @@ static int tee_bnxt_fw_probe(struct device *dev) return -ENODEV;
/* Open session with Bnxt load Trusted App */ - memcpy(sess_arg.uuid, bnxt_device->id.uuid.b, TEE_IOCTL_UUID_LEN); + export_uuid(sess_arg.uuid, &bnxt_device->id.uuid); sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC; sess_arg.num_params = 0;
On Thu, Jan 21, 2021 at 08:37:41PM +0200, Andy Shevchenko wrote:
There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant.
Folks, is this orphaned driver? Should we update MAINTAINERS accordingly? If not, why review is not done yes for more than half a year?
+ Cc: Christoph. Maybe you can apply this one, please?
On Mon, Dec 13, 2021 at 10:36:55PM +0200, Andy Shevchenko wrote:
On Thu, Jan 21, 2021 at 08:37:41PM +0200, Andy Shevchenko wrote:
There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant.
Folks, is this orphaned driver? Should we update MAINTAINERS accordingly? If not, why review is not done yes for more than half a year?
-
Andy Shevchenko