- Acc - lists.linaro.org

[PATCH] uadk/v1/ecc: bugfix buffer overwritten of sm2 decryption

by Zhiqi Song

Fix the problem that the input data field 'c1.x' is overwitten by the output data calculated by the hardware. Signed-off-by: Zhiqi Song <songzhiqi1(a)huawei.com> --- v1/drv/hisi_hpre_udrv.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/v1/drv/hisi_hpre_udrv.c b/v1/drv/hisi_hpre_udrv.c index 0738f44..00ceec2 100644 --- a/v1/drv/hisi_hpre_udrv.c +++ b/v1/drv/hisi_hpre_udrv.c @@ -1969,7 +1969,6 @@ static int fill_sm2_dec_sqe(void *message, struct qm_queue_info *info, __u16 i) /* compute d * c1 */ memcpy(dst, req_src, sizeof(*dst)); - dst->op_type = HPRE_SM2_DEC; *(struct wcrypto_ecc_msg **)(dst + 1) = req_src; dst->in = (void *)&din->c1; @@ -2047,8 +2046,8 @@ static int qm_parse_ecc_sqe_general(void *msg, const struct qm_queue_info *info, dma_out = DMA_ADDR(hw_msg->hi_out, hw_msg->low_out); dma_key = DMA_ADDR(hw_msg->hi_key, hw_msg->low_key); - dma_in = DMA_ADDR(hw_msg->hi_in, hw_msg->hi_in); - drv_iova_unmap(q, NULL, (void *)(uintptr_t)dma_in, olen); + dma_in = DMA_ADDR(hw_msg->hi_in, hw_msg->low_in); + drv_iova_unmap(q, NULL, (void *)(uintptr_t)dma_in, ilen); drv_iova_unmap(q, NULL, (void *)(uintptr_t)dma_out, olen); drv_iova_unmap(q, NULL, (void *)(uintptr_t)dma_key, kbytes); @@ -2265,8 +2264,8 @@ static int is_equal(struct wd_dtb *src, struct wd_dtb *dst) static int sm2_hash(struct wd_dtb *out, struct wcrypto_ecc_point *x2y2, struct wd_dtb *msg, struct q_info *q_info) { - struct wcrypto_hash_mt *hash = &q_info->hash; __u64 lens = (__u64)msg->dsize + 2 * (__u64)x2y2->x.dsize; + struct wcrypto_hash_mt *hash = &q_info->hash; char hash_out[MAX_HASH_LENS] = {0}; __u64 in_len = 0; __u32 h_bytes; @@ -2353,8 +2352,10 @@ static int sm2_convert_dec_out(struct wcrypto_ecc_msg *src, struct wcrypto_sm2_dec_out *dout = &out->param.dout; struct wcrypto_ecc_in *in = (void *)src->in; struct wcrypto_sm2_dec_in *din = &in->param.din; + char buff[MAX_HASH_LENS] = {0}; struct wcrypto_ecc_point x2y2; __u32 ksz = dst->key_bytes; + struct wd_dtb u = {0}; int ret; /* dec origin out data fmt: @@ -2362,8 +2363,6 @@ static int sm2_convert_dec_out(struct wcrypto_ecc_msg *src, * final out data fmt: * | plaintext | */ - - /* x2y2 :copy x2y2 into din->c1 */ x2y2.x.data = (void *)dst->out; x2y2.y.data = (void *)(dst->out + ksz); x2y2.x.dsize = ksz; @@ -2376,20 +2375,21 @@ static int sm2_convert_dec_out(struct wcrypto_ecc_msg *src, return ret; } - /* M' = C2 XOR t */ + /* M' = c2 XOR t */ sm2_xor(&dout->plaintext, &din->c2); - /* u = hash(x2 || M' || y2), save u to din->c2 */ - ret = sm2_hash(&din->c1.x, &x2y2, &dout->plaintext, q_info); + /* u = hash(x2 || M' || y2) */ + u.data = buff; + ret = sm2_hash(&u, &x2y2, &dout->plaintext, q_info); if (unlikely(ret)) { WD_ERR("failed to compute c3, ret = %d!\n", ret); return ret; } - /* u == c3 */ - ret = is_equal(&din->c1.x, &din->c3); + /* Judge whether u == c3 */ + ret = is_equal(&u, &din->c3); if (ret) - WD_ERR("failed to dec sm2, u != C3!\n"); + WD_ERR("failed to dec sm2, u != c3!\n"); return ret; } -- 2.30.0

2 years, 7 months

1
0
0 0

[PATCH 0/4] Add dynamic driver loading function

by liulongfang

Update the current driver adaptation and usage method, from fixed use of Hisilicon device driver to automatic registration of the driver according to the algorithm. When the algorithm API layer uses the driver, it is no longer bound to the fixed device driver, but dynamically obtained and stored according to the algorithm query to use. Update the driver and API layer of the zip module, keep the function of the init interface unchanged, update the implementation of the init2 interface and match the dynamic loading function. liulongfang (4): uadk: Add driver dynamic loading function uadk: added ability to query supported algorithms uadk: improve the dynamic loading public framework uadk/zip: Adapt the zip module to the dynamic loading framework Makefile.am | 4 +- drv/hisi_comp.c | 101 ++++++++- include/drv/wd_comp_drv.h | 27 --- include/wd.h | 12 + include/wd_alg.h | 85 ++++++++ include/wd_alg_common.h | 10 + include/wd_sched.h | 6 +- include/wd_util.h | 18 +- libwd.map | 8 + wd.c | 56 ++++- wd_alg.c | 265 ++++++++++++++++++++++ wd_comp.c | 160 +++++++------- wd_util.c | 447 +++++++++++++++++++++++++++++++++++++- 13 files changed, 1068 insertions(+), 131 deletions(-) create mode 100644 include/wd_alg.h create mode 100644 wd_alg.c -- 2.33.0

2 years, 7 months

3
17
0 0

test

by mk7＠mk.poescnae.top

2 years, 7 months

1
0
0 0

[PATCH v2 0/5] Add dynamic driver loading function

by liulongfang

Update the current driver adaptation and usage method, from fixed use of Hisilicon device driver to automatic registration of the driver according to the algorithm. When the algorithm API layer uses the driver, it is no longer bound to the fixed device driver, but dynamically obtained and stored according to the algorithm query to use. Update the driver and API layer of the zip and sec module, keep the function of the init interface unchanged, update the implementation of the init2 interface and match the dynamic loading function. Changes v1 -> v2: - Fixed the compatibility method with the previous library file loading liulongfang (5): uadk: Add driver dynamic loading function uadk: added ability to query supported algorithms uadk: improve the dynamic loading public framework uadk/zip: Adapt the zip module to the dynamic loading framework uadk/sec: adapt the sec module to the dynamic loading framework Makefile.am | 4 +- drv/hisi_comp.c | 59 ++++- drv/hisi_sec.c | 125 ++++++++-- include/drv/wd_cipher_drv.h | 26 -- include/drv/wd_comp_drv.h | 27 --- include/wd.h | 12 + include/wd_alg.h | 95 ++++++++ include/wd_alg_common.h | 10 + include/wd_sched.h | 6 +- include/wd_util.h | 19 +- libwd.map | 8 + libwd_crypto.map | 3 + wd.c | 56 ++++- wd_alg.c | 258 ++++++++++++++++++++ wd_cipher.c | 233 ++++++++++++++---- wd_comp.c | 188 ++++++++------- wd_sched.c | 57 +++++ wd_util.c | 463 +++++++++++++++++++++++++++++++++++- 18 files changed, 1419 insertions(+), 230 deletions(-) create mode 100644 include/wd_alg.h create mode 100644 wd_alg.c -- 2.33.0

2 years, 7 months

1
5
0 0

[[PATCH] 0/5] bugfix and cleanup about uadk engine

by Zhiqi Song

This patch set contains some tiny bugfix and cleanup of ecc/rsa/cipher. Wenkai Lin (1): cipher: code clean for update iv and check length Zhiqi Song (4): rsa: fix wrong input parameters cipher: fix unused input parameter uadk_engine: bugfix null dereference in abnormal conditions ecc: bugfix potential null dereference problems -- 2.30.0

2 years, 7 months

1
5
0 0

[PATCH 0/2] support zlibwrapper for uadk compression

by Yang Shen

Add a set of zlibwrapper interfaces for users to fit uadk interfaces quickly. Yang Shen (2): uadk/comp - support reset session zlibwrapper: add zlibwrapper to adapt for zlib interface Makefile.am | 2 +- include/wd_comp.h | 9 +- libwd_comp.map | 11 ++ wd_comp.c | 15 +++ wd_zlibwrapper.c | 335 ++++++++++++++++++++++++++++++++++++++++++++++ wd_zlibwrapper.h | 112 ++++++++++++++++ 6 files changed, 482 insertions(+), 2 deletions(-) create mode 100644 wd_zlibwrapper.c create mode 100644 wd_zlibwrapper.h -- 2.24.0

2 years, 7 months

3
6
0 0

[PATCH 0/5] Add dynamic driver loading function

by liulongfang

Update the current driver adaptation and usage method, from fixed use of Hisilicon device driver to automatic registration of the driver according to the algorithm. When the algorithm API layer uses the driver, it is no longer bound to the fixed device driver, but dynamically obtained and stored according to the algorithm query to use. Update the driver and API layer of the zip module, keep the function of the init interface unchanged, update the implementation of the init2 interface and match the dynamic loading function. liulongfang (5): uadk: Add driver dynamic loading function uadk: added ability to query supported algorithms uadk: improve the dynamic loading public framework uadk/zip: Adapt the zip module to the dynamic loading framework uadk/sec: adapt the sec module to the dynamic loading framework Makefile.am | 4 +- drv/hisi_comp.c | 59 ++++- drv/hisi_sec.c | 125 ++++++++-- include/drv/wd_cipher_drv.h | 26 -- include/drv/wd_comp_drv.h | 27 --- include/wd.h | 12 + include/wd_alg.h | 96 ++++++++ include/wd_alg_common.h | 10 + include/wd_sched.h | 6 +- include/wd_util.h | 19 +- libwd.map | 8 + libwd_crypto.map | 3 + wd.c | 56 ++++- wd_alg.c | 265 ++++++++++++++++++++ wd_cipher.c | 214 +++++++++++++---- wd_comp.c | 169 +++++++------ wd_util.c | 464 +++++++++++++++++++++++++++++++++++- 17 files changed, 1347 insertions(+), 216 deletions(-) create mode 100644 include/wd_alg.h create mode 100644 wd_alg.c -- 2.33.0

2 years, 7 months

1
5
0 0

dpdk performance

by Zhangfei Gao

dpdk performance 12.1 https://docs.qq.com/doc/DRUNSWFlGeXRJSk1D 1. uadk  $ sudo dpdk-test-crypto-perf -l 1,2 --vdev crypto_uadk -- --devtype crypto_uadk --optype cipher-only --buffer-sz 64,128,256,512,1024,2048 --silent [sudo] password for linaro:  EAL: Detected CPU lcores: 128 EAL: Detected NUMA nodes: 4 EAL: Detected static linkage of DPDK EAL: Multi-process socket /var/run/dpdk/rte/mp_socket EAL: Selected IOVA mode 'VA' EAL: VFIO support initialized CRYPTODEV: Creating cryptodev crypto_uadk CRYPTODEV: Initialisation parameters - name: crypto_uadk,socket id: 0, max queue pairs: 8 TELEMETRY: No legacy callbacks, legacy socket not created Allocated pool "sess_mp_0" on socket 0     lcore id    Buf Size  Burst Size    Enqueued    Dequeued  Failed Enq  Failed Deq        MOps        Gbps  Cycles/Buf            2          64          32    10000000    10000000           0           0      0.8115      0.4155      123.23            2         128          32    10000000    10000000           0           0      0.7859      0.8048      127.24            2         256          32    10000000    10000000           0           0      0.7356      1.5066      135.93            2         512          32    10000000    10000000           0           0      0.6401      2.6219      156.23            2        1024          32    10000000    10000000           0           0      0.5186      4.2483      192.83            2        2048          32    10000000    10000000           0           0      0.3770      6.1774      265.22 $ sudo dpdk-test-crypto-perf -l 1,2 --vdev crypto_uadk -- --devtype crypto_uadk --buffer-sz 64,128,256,512,1024,2048 --optype cipher-then-auth --ptest throughput --auth-key-sz 64 --cipher-key-sz 16 --cipher-iv-sz 16 --auth-op generate --burst-sz 32 --total-ops 30000000 --silent --digest-sz 20 --auth-algo sha1-hmac --cipher-algo aes-cbc --cipher-op encrypt EAL: Detected CPU lcores: 128 EAL: Detected NUMA nodes: 4 EAL: Detected static linkage of DPDK EAL: Multi-process socket /var/run/dpdk/rte/mp_socket EAL: Selected IOVA mode 'VA' EAL: VFIO support initialized CRYPTODEV: Creating cryptodev crypto_uadk CRYPTODEV: Initialisation parameters - name: crypto_uadk,socket id: 0, max queue pairs: 8 TELEMETRY: No legacy callbacks, legacy socket not created Allocated pool "sess_mp_0" on socket 0     lcore id    Buf Size  Burst Size    Enqueued    Dequeued  Failed Enq  Failed Deq        MOps        Gbps  Cycles/Buf            2          64          32    30000000    30000000           0           0      0.3734      0.1912      267.80            2         128          32    30000000    30000000           0           0      0.3611      0.3698      276.90            2         256          32    30000000    30000000           0           0      0.3388      0.6939      295.16            2         512          32    30000000    30000000           0           0      0.2986      1.2230      334.92            2        1024          32    30000000    30000000           0           0      0.2419      1.9820      413.33            2        2048          32    30000000    30000000           0           0      0.1810      2.9661      552.37 2. openssl $ sudo dpdk-test-crypto-perf -l 1,2 --vdev crypto_openssl -- --devtype crypto_openssl --optype cipher-only --buffer-sz 64,128,256,512,1024,2048 --silent EAL: Detected CPU lcores: 128 EAL: Detected NUMA nodes: 4 EAL: Detected static linkage of DPDK EAL: Multi-process socket /var/run/dpdk/rte/mp_socket EAL: Selected IOVA mode 'VA' EAL: VFIO support initialized CRYPTODEV: Creating cryptodev crypto_openssl CRYPTODEV: Initialisation parameters - name: crypto_openssl,socket id: 0, max queue pairs: 8 TELEMETRY: No legacy callbacks, legacy socket not created Allocated pool "sess_mp_0" on socket 0     lcore id    Buf Size  Burst Size    Enqueued    Dequeued  Failed Enq  Failed Deq        MOps        Gbps  Cycles/Buf            2          64          32    10000000    10000000           0           0      3.5600      1.8227       28.09            2         128          32    10000000    10000000           0           0      2.9432      3.0138       33.98            2         256          32    10000000    10000000           0           0      2.2142      4.5347       45.16            2         512          32    10000000    10000000           0           0      1.4678      6.0122       68.13            2        1024          32    10000000    10000000           0           0      0.8805      7.2133      113.57            2        2048          32    10000000    10000000           0           0      0.4877      7.9898      205.06 $ sudo dpdk-test-crypto-perf -l 1,2 --vdev crypto_openssl -- --devtype crypto_openssl --buffer-sz 64,128,256,512,1024,2048 -- optype cipher-then-auth --ptest throughput --auth-key-sz 64 --cipher-key-sz 16 --cipher-iv-sz 16 --auth-op generate --burst-sz 32 --total-ops 30000 000 --silent --digest-sz 20 --auth-algo sha1-hmac --cipher-algo aes-cbc --cipher-op encrypt EAL: Detected CPU lcores: 128 EAL: Detected NUMA nodes: 4 EAL: Detected static linkage of DPDK EAL: Multi-process socket /var/run/dpdk/rte/mp_socket EAL: Selected IOVA mode 'VA' EAL: VFIO support initialized CRYPTODEV: Creating cryptodev crypto_openssl CRYPTODEV: Initialisation parameters - name: crypto_openssl,socket id: 0, max queue pairs: 8 TELEMETRY: No legacy callbacks, legacy socket not created Allocated pool "sess_mp_0" on socket 0     lcore id    Buf Size  Burst Size    Enqueued    Dequeued  Failed Enq  Failed Deq        MOps        Gbps  Cycles/Buf            2          64          32    30000000    30000000           0           0      0.9686      0.4959      103.24            2         128          32    30000000    30000000           0           0      0.8857      0.9069      112.91            2         256          32    30000000    30000000           0           0      0.7573      1.5510      132.05            2         512          32    30000000    30000000           0           0      0.5850      2.3964      170.93            2        1024          32    30000000    30000000           0           0      0.4017      3.2910      248.92            2        2048          32    30000000    30000000           0           0      0.2478      4.0601      403.54 3. Intel http://fast.dpdk.org/doc/perf/DPDK_22_07_Intel_crypto_performance_report.pdf

2 years, 7 months

1
0
0 0

Re: uadk branch & tag policy

by zhangfei.gao＠foxmail.com

On 2022/11/10 下午4:15, fanghao (A) wrote: > > > 在 2022/11/10 10:54, Zhangfei Gao 写道: >> Here is discussion about uadk branch & tag policy >> >> By now, I saw the best example >> https://github.com/intel/intel-ipsec-mb >> >> 1. no lts branch, only use tag + ReleaseNotes.txt >> >> Lts branch will cost too much resources, it is hard for a small team >> like us. >> For example it is difficult to git am current patch to any tag half >> year ago. >> >> Unlike OS, it is little meaning for UADK to keep a stable version. >> We can not attract customer only by maintaining a stable version, > mainly for LTS OS easy to catch the bugfix update for which version > that have been intergrated. Yes, but it maybe another story if we promise like two years' maintain. > >> but only the performance and new feautre, like support both >> accelerators and cpu instructions. >> >> >> 2. Tag policy >> >> Refer >> https://github.com/intel/intel-ipsec-mb/blob/main/ReleaseNotes.txt >> >> Basically two releases each year, > looks good to me. > >> >> v1.3 September 2022 >> v1.2 February 2022 >> v1.1 October 2021 >> v1.0 April 2021 >> > The time node is not fixed. Do we need fixed time? Sure, How about one month before Euler release? > >> No small tag, since uadk is stable enough. is it too simple, suitable? >> What's the minor tag used for? >> Other component (openssl-uadk) need refer these tag accordingly. >> >> We may consider minor tag for bug fix? like 1.3.1 for a big bug fix? > looks good to me. > >> intel-ipsec-mb$ >> $ git tag >> v1.0 >> v1.1 >> v1.2 >> v1.3 >> >> 3. ReleaseNotes Contents: >> >> General: >> Working combination, uadk xxx & openssl-uadk xxx & dpdk xxx >> >> Main change: >> Like support cpu instructions >> api change? >> >> Library >> New algoirthm: >> >> Test Applications: >> >> Fixes: >> > Can be simplified like this? > > Features： > ... > > Fixes: > ... We can use this for UADK. For openssl-uadk, the testing combination maybe required. I am not sure whether openssl-uadk can work with any version of UADK from now on. ie. the UADK interface keeps stable. We found openssl-uadk can not work with some old version UADK before. openssl-uadk depend on UADK, we can add testing combination in openssl-uadk ReleaseNotes. UADK releasenotes may have no such issue. > > > But how to kown the bugfix for which tag? > For example: new tag 2.3.1 for bugfix,how to kown this fix for which > version.maybe fix > for 2.1 just not for 2.3. Since no lts branch, only description in ReleaseNotes can be check. Since one release half year, suppose there is no such issue, like a bug fix happens half year later. Thanks > >> Release status: Unreleased & tag (like v1.3 September 2022) >> -Unreleased >> +v1.3 September 2022 >> >> _______________________________________________ >> Acc mailing list -- acc(a)openeuler.org >> To unsubscribe send an email to acc-leave(a)openeuler.org > _______________________________________________ > Acc mailing list -- acc(a)openeuler.org > To unsubscribe send an email to acc-leave(a)openeuler.org

2 years, 7 months

2
2
0 0

Fwd: DPDK 22.11 released

by Zhangfei Gao

-------- Forwarded Message -------- Subject: DPDK 22.11 released Date: Sun, 27 Nov 2022 23:22:17 +0100 From: Thomas Monjalon <thomas(a)monjalon.net> To: announce(a)dpdk.org A new major release is available: https://fast.dpdk.org/rel/dpdk-22.11.tar.xz It was a comfortable release cycle: 1387 commits from 193 authors 1902 files changed, 137224 insertions(+), 61256 deletions(-) The branch 22.11 should be supported for at least two years, maybe more, making it recommended for system integration and deployment. The new major ABI version is 23. The next releases 23.03 and 23.07 will be ABI-compatible with 22.11. Below are some new features: - LoongArch build - Intel uncore frequency control - mempool optimizations - new mbuf layout for IOVA-as-VA build - multiple mbuf pools per Rx queue - Rx buffer split based on protocol - hardware congestion management - hairpin memory configuration - proactive NIC error handling - Rx/Tx descriptor dump - flow API extensions - GVE (Google Virtual Ethernet) - IDPF (Intel Infrastructure DataPath Function) - UADK supporting HiSilicon crypto - MACsec processing offload - ShangMi crypto algorithms - baseband FFT operations - eventdev Tx queue start/stop - eventdev crypto vectorization - NitroSketch membership - DTS introduction in DPDK repository More details in the release notes: https://doc.dpdk.org/guides/rel_notes/release_22_11.html There are 74 new contributors (including authors, reviewers and testers). Welcome to Abdullah Sevincer, Abhishek Maheshwari, Alan Liu, Aleksandr Miloshenko, Alex Vesker, Alexander Chernavin, Allen Hubbe, Amit Prakash Shukla, Anatolii Gerasymenko, Arkadiusz Kubalewski, Arshdeep Kaur, Benjamin Le Berre, Bhagyada Modali, David MacDougal, Dawid Zielinski, Dexia Li, Dukai Yuan, Erez Shitrit, Fei Qin, Frank Du, Gal Shalom, Grzegorz Siwik, Hamdan Igbaria, Hamza Khan, Henning Schild, Huang Wei, Huzaifa Rahman, James Hershaw, Jeremy Spewock, Jin Ling, Joey Xing, Jun Qiu, Kaiwen Deng, Karen Sornek, Ke Xu, Kevin O'Sullivan, Lei Cai, Lei Ji, Leszek Zygo, Long Wu, Lukasz Czapnik, Lukasz Kupczak, Mah Yock Gen, Mandal Purna Chandra, Mao YingMing, Marcin Szycik, Michael Savisko, Min Zhou, Mingjin Ye, Mingshan Zhang, Mário Kuka, Piotr Gardocki, Qingmin Liu, R Mohamed Shah, Roman Storozhenko, Sathesh Edara, Sergey Temerkhanov, Shiqi Liu, Stephen Coleman, Steven Zou, Sunil Uttarwar, Sunyang Wu, Sylvia Grundwürmer, Tadhg Kearney, Taekyung Kim, Taripin Samuel, Tomasz Jonak, Tomasz Zawadzki, Tsotne Chakhvadze, Usman Tanveer, Wiktor Pilarczyk, Yaqi Tang, Yi Li and Zhangfei Gao. Below is the number of commits per employer (with authors count): 456 Intel (65) 227 Marvell (29) 179 NVIDIA (28) 83 Corigine (6) 81 Red Hat (5) 60 Huawei (6) 58 AMD (5) 55 Microsoft (4) 53 OKTET Labs (2) 19 NXP (5) 14 Ericsson (1) 13 6WIND (2) ... A big thank to all courageous people who took on the non rewarding task of reviewing other's job. Based on Reviewed-by and Acked-by tags, the top non-PMD reviewers are: 53 Akhil Goyal <gakhil(a)marvell.com> 45 Andrew Rybchenko <andrew.rybchenko(a)oktetlabs.ru> 36 Morten Brørup <mb(a)smartsharesystems.com> 34 Niklas Söderlund <niklas.soderlund(a)corigine.com> 34 Bruce Richardson <bruce.richardson(a)intel.com> 33 David Marchand <david.marchand(a)redhat.com> 31 Ori Kam <orika(a)nvidia.com> 25 Maxime Coquelin <maxime.coquelin(a)redhat.com> 21 Jerin Jacob <jerinj(a)marvell.com> 20 Chengwen Feng <fengchengwen(a)huawei.com> The next version will be 23.03 in March. The new features for 23.03 can be submitted during the next 4 weeks: http://core.dpdk.org/roadmap#dates Please share your roadmap. Thanks everyone

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

Acc