- Acc - lists.linaro.org

[PATCH] crypto/uadk: set queue pair in dev_configure

by Zhangfei Gao

By default uadk only alloc two queues for each algorithm, which will impact performance. Set queue pair number as required in dev_configure. By default the max queue pair number is 8, which can be modified via para: max_nb_queue_pairs Example: sudo dpdk-test-crypto-perf -l 0-10 --vdev crypto_uadk,max_nb_queue_pairs=10 -- --devtype crypto_uadk --optype cipher-only --buffer-sz 8192 lcore id Buf Size Burst Size Gbps Cycles/Buf 3 8192 32 7.5226 871.19 7 8192 32 7.5225 871.20 1 8192 32 7.5225 871.20 4 8192 32 7.5224 871.21 5 8192 32 7.5224 871.21 10 8192 32 7.5223 871.22 9 8192 32 7.5223 871.23 2 8192 32 7.5222 871.23 8 8192 32 7.5222 871.23 6 8192 32 7.5218 871.28 Signed-off-by: Zhangfei Gao <zhangfei.gao(a)linaro.org> --- drivers/crypto/uadk/uadk_crypto_pmd.c | 19 +++++++++++++++++-- drivers/crypto/uadk/uadk_crypto_pmd_private.h | 1 + 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/uadk/uadk_crypto_pmd.c b/drivers/crypto/uadk/uadk_crypto_pmd.c index 4f729e0f07..34aae99342 100644 --- a/drivers/crypto/uadk/uadk_crypto_pmd.c +++ b/drivers/crypto/uadk/uadk_crypto_pmd.c @@ -357,8 +357,15 @@ static const struct rte_cryptodev_capabilities uadk_crypto_v2_capabilities[] = { /* Configure device */ static int uadk_crypto_pmd_config(struct rte_cryptodev *dev __rte_unused, - struct rte_cryptodev_config *config __rte_unused) + struct rte_cryptodev_config *config) { + char env[128]; + + /* set queue pairs num via env */ + sprintf(env, "sync:%d@0", config->nb_queue_pairs); + setenv("WD_CIPHER_CTX_NUM", env, 1); + setenv("WD_DIGEST_CTX_NUM", env, 1); + return 0; } @@ -434,7 +441,7 @@ uadk_crypto_pmd_info_get(struct rte_cryptodev *dev, if (dev_info != NULL) { dev_info->driver_id = dev->driver_id; dev_info->driver_name = dev->device->driver->name; - dev_info->max_nb_queue_pairs = 128; + dev_info->max_nb_queue_pairs = priv->max_nb_qpairs; /* No limit of number of sessions */ dev_info->sym.max_nb_sessions = 0; dev_info->feature_flags = dev->feature_flags; @@ -1015,6 +1022,7 @@ uadk_cryptodev_probe(struct rte_vdev_device *vdev) struct uadk_crypto_priv *priv; struct rte_cryptodev *dev; struct uacce_dev *udev; + const char *input_args; const char *name; udev = wd_get_accel_dev("cipher"); @@ -1030,6 +1038,9 @@ uadk_cryptodev_probe(struct rte_vdev_device *vdev) if (name == NULL) return -EINVAL; + input_args = rte_vdev_device_args(vdev); + rte_cryptodev_pmd_parse_input_args(&init_params, input_args); + dev = rte_cryptodev_pmd_create(name, &vdev->device, &init_params); if (dev == NULL) { UADK_LOG(ERR, "driver %s: create failed", init_params.name); @@ -1044,6 +1055,7 @@ uadk_cryptodev_probe(struct rte_vdev_device *vdev) RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO; priv = dev->data->dev_private; priv->version = version; + priv->max_nb_qpairs = init_params.max_nb_queue_pairs; rte_cryptodev_pmd_probing_finish(dev); @@ -1078,4 +1090,7 @@ static struct cryptodev_driver uadk_crypto_drv; RTE_PMD_REGISTER_VDEV(UADK_CRYPTO_DRIVER_NAME, uadk_crypto_pmd); RTE_PMD_REGISTER_CRYPTO_DRIVER(uadk_crypto_drv, uadk_crypto_pmd.driver, uadk_cryptodev_driver_id); +RTE_PMD_REGISTER_PARAM_STRING(UADK_CRYPTO_DRIVER_NAME, + "max_nb_queue_pairs=<int> " + "socket_id=<int>"); RTE_LOG_REGISTER_DEFAULT(uadk_crypto_logtype, INFO); diff --git a/drivers/crypto/uadk/uadk_crypto_pmd_private.h b/drivers/crypto/uadk/uadk_crypto_pmd_private.h index 9075f0f058..5a7dbff117 100644 --- a/drivers/crypto/uadk/uadk_crypto_pmd_private.h +++ b/drivers/crypto/uadk/uadk_crypto_pmd_private.h @@ -67,6 +67,7 @@ struct uadk_crypto_priv { bool env_cipher_init; bool env_auth_init; enum uadk_crypto_version version; + unsigned int max_nb_qpairs; } __rte_cache_aligned; extern int uadk_crypto_logtype; -- 2.39.2 (Apple Git-143)

2 years, 5 months

1
0
0 0

[PATCH 0/6] add init2 and dynamic load for digest/aead agls

by Hao Fang

compress/cipher/rsa/ecc already support the init2 and dynamic load, now add support for digest/aead algs. Hao Fang (6): uadk/digest: introduce the init2 interface for digest uadk/aead: introduce the init2 interface for aead uadk/digest: adapt the module dynamic load for the digest algs uadk/aead: adadpt the module dynamic load for aead algs uadk/tools: add init2 test for digest algs uadk/tool: add init2 test for aead algs drv/hisi_sec.c | 105 +++++++++---- include/drv/wd_aead_drv.h | 26 ---- include/drv/wd_digest_drv.h | 26 ---- include/wd_aead.h | 28 ++++ include/wd_digest.h | 28 ++++ libwd_crypto.map | 6 + uadk_tool/test/test_sec.c | 249 ++++++++++++++++++++++++++++--- wd_aead.c | 288 +++++++++++++++++++++++++++--------- wd_digest.c | 286 ++++++++++++++++++++++++++--------- 9 files changed, 794 insertions(+), 248 deletions(-) -- 2.30.0

2 years, 5 months

1
6
0 0

[ACC] [PATCH 0/6] uadk: update ecc/rsa/dh function

by Weili Qian

To simplify the calling logic of uadk, a new init2 interface is added to the ecc/rsa/dh algorithm class, which includes hardware device resource initialization and scheduler initialization. Weili Qian (6): uadk/ecc: add the init2 interface for ecc uadk/rsa: add the init2 interface for rsa uadk/dh: add the init2 interface for dh uadk/ecc: adapt the ecc module to the dynamic loading framework uadk/rsa: adapt the rsa module to the dynamic loading framework uadk/dh: adapt the dh module to the dynamic loading framework drv/hisi_hpre.c | 180 +++++++++++++++++++-------- include/drv/wd_dh_drv.h | 27 ---- include/drv/wd_ecc_drv.h | 27 ---- include/drv/wd_rsa_drv.h | 27 ---- include/wd_dh.h | 30 +++++ include/wd_ecc.h | 28 +++++ include/wd_rsa.h | 28 +++++ libwd_crypto.map | 9 ++ wd_dh.c | 256 +++++++++++++++++++++++++++----------- wd_ecc.c | 262 ++++++++++++++++++++++++++++----------- wd_rsa.c | 256 +++++++++++++++++++++++++++----------- 11 files changed, 786 insertions(+), 344 deletions(-) -- 2.33.0

2 years, 6 months

2
8
0 0

[PATCH v3 0/2] uadk: update cipher function

by Longfang Liu

In order to simplify the calling logic of uadk, a new init2 interface is added to the cipher algorithm class, which includes hardware device resource initialization and scheduler initialization. Changes v2 -> v3: Remove some redundant opcodes. Changes v1 -> v2: init2 interface and dynamic loading driver modification for splitting Longfang Liu (2): uadk/cipher: add the init2 interface for cipher uadk/sec: adapt the sec module to the dynamic loading framework drv/hisi_sec.c | 102 +++++++++++-- include/drv/wd_aead_drv.h | 2 +- include/drv/wd_cipher_drv.h | 26 ---- include/drv/wd_digest_drv.h | 2 +- include/wd_cipher.h | 29 ++++ libwd_crypto.map | 3 + wd_cipher.c | 297 +++++++++++++++++++++++++++--------- 7 files changed, 345 insertions(+), 116 deletions(-) -- 2.33.0

2 years, 6 months

1
2
0 0

Test email

by Prasanth Nair

Test email. Please ignore.

2 years, 7 months

1
0
0 0

Test email please ignore

by Prasanth S Nair

Test email please ignore

2 years, 7 months

1
0
0 0

acc@lists.linaro.org Password Expiry Notice!

by lists.linaro.org

2 years, 7 months

1
0
0 0

Fwd: S390 testing for IOMMUFD

by Zhangfei Gao

-------- Forwarded Message -------- Subject: S390 testing for IOMMUFD Date: Mon, 7 Nov 2022 21:09:02 -0400 From: Jason Gunthorpe <jgg(a)nvidia.com> To: Cornelia Huck <cohuck(a)redhat.com>, Eric Farman <farman(a)linux.ibm.com>, Matthew Rosato <mjrosato(a)linux.ibm.com>, Niklas Schnelle <schnelle(a)linux.ibm.com>, Tony Krowiak <akrowiak(a)linux.ibm.com>, Halil Pasic <pasic(a)linux.ibm.com>, Jason Herne <jjherne(a)linux.ibm.com>, linux-s390(a)vger.kernel.org CC: iommu(a)lists.linux.dev, Kevin Tian <kevin.tian(a)intel.com>, Alex Williamson <alex.williamson(a)redhat.com>, kvm(a)vger.kernel.org, Lu Baolu <baolu.lu(a)linux.intel.com>, Nicolin Chen <nicolinc(a)nvidia.com> On Mon, Nov 07, 2022 at 08:48:53PM -0400, Jason Gunthorpe wrote: > [ > This has been in linux-next for a little while now, and we've completed > the syzkaller run. 1300 hours of CPU time have been invested since the > last report with no improvement in coverage or new detections. syzkaller > coverage reached 69%(75%), and review of the misses show substantial > amounts are WARN_ON's and other debugging which are not expected to be > covered. > ] > > iommufd is the user API to control the IOMMU subsystem as it relates to > managing IO page tables that point at user space memory. [chop cc list] s390 mdev maintainers, Can I ask your help to test this with the two S390 mdev drivers? Now that gvt is passing and we've covered alot of the QA ground it is a good time to run it. Take the branch from here: https://git.kernel.org/pub/scm/linux/kernel/git/jgg/iommufd.git/log/?h=for-… And build the kernel with CONFIG_VFIO_CONTAINER=n CONFIG_IOMMUFD=y CONFIG_IOMMUFD_VFIO_CONTAINER=y And your existing stuff should work with iommufd providing the iommu support to vfio. There will be a dmesg confirming this. Let me know if there are any problems! If I recall there was some desire from the S390 platform team to start building on iommufd to create some vIOMMU acceleration for S390 guests, this is a necessary first step. Thanks, Jason

2 years, 7 months

3
2
0 0

[PATCH] dh: cleanup redundant macro definition

by Zhiqi Song

Remove duplicated definition of CTX_MODE_NUM. Signed-off-by: Zhiqi Song <songzhiqi1(a)huawei.com> --- src/uadk_dh.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/uadk_dh.c b/src/uadk_dh.c index 6065160..a14d215 100644 --- a/src/uadk_dh.c +++ b/src/uadk_dh.c @@ -39,7 +39,6 @@ #define CHAR_BIT_SIZE 3 #define DH_PARAMS_CNT 3 #define CTX_MODE_NUM 2 -#define CTX_MODE_NUM 2 #define UN_SET 0 #define IS_SET 1 #define CTX_ASYNC 1 -- 2.30.0

2 years, 8 months

1
2
0 0

[PATCH v7 0/6] add dynamic driver loading function

by Longfang Liu

Update the current driver adaptation and usage method, from fixed use of Hisilicon device driver to automatic registration of the driver according to the algorithm. When the algorithm API layer uses the driver, it is no longer bound to the fixed device driver, but dynamically obtained and stored according to the algorithm query to use. Update the driver and API layer of the zip and sec module, keep the function of the init interface unchanged, update the implementation of the init2 interface and match the dynamic loading function. Changes v6 -> v7: - Added dynamically loaded design documents. Changes v5 -> v6: - Rebase based on the patch of the zlib interface. Changes v4 -> v5: - Enhance the inclusiveness of the init2 interface. Changes v3 -> v4: - Remove the template instance code of cipher. - Split the scheduler code into a separate patch. Changes v2 -> v3: - Add dynamic library file search function - Fix some memory handling issues Changes v1 -> v2: - Fixed the compatibility method with the previous library file loading Longfang Liu (6): uadk: Add driver dynamic loading function uadk: update scheduler for dynamic loading uadk: improve the dynamic loading public framework uadk/doc: adding dynamically loaded design documents uadk: added ability to query supported algorithms uadk/zip: Adapt the zip module to the dynamic loading framework Makefile.am | 4 +- ...sion_and_modular_dynamic_loading_design.md | 432 ++++++++++++++ drv/hisi_comp.c | 59 +- include/drv/wd_comp_drv.h | 27 - include/wd.h | 12 + include/wd_alg.h | 95 +++ include/wd_alg_common.h | 11 + include/wd_sched.h | 6 +- include/wd_util.h | 63 +- libwd.map | 8 + wd.c | 56 +- wd_alg.c | 265 +++++++++ wd_comp.c | 243 ++++---- wd_sched.c | 105 +++- wd_util.c | 549 +++++++++++++++++- 15 files changed, 1769 insertions(+), 166 deletions(-) create mode 100644 docs/UADK_framework_expansion_and_modular_dynamic_loading_design.md create mode 100644 include/wd_alg.h create mode 100644 wd_alg.c -- 2.33.0

2 years, 8 months

1
6
0 0

2025

2024

2023

2022

Acc