August 2016 - git-lng-odp - lists.linaro.org

[COMMIT] branch api-next updated. v1.10.1.0-132-gfa65775

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, api-next has been updated via fa657759a41b23b4fd76c30b8f3ca27d709950d2 (commit) from 179074e0d0771c82d064e29a20531b75d17289d7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fa657759a41b23b4fd76c30b8f3ca27d709950d2 Author: Maxim Uvarov <maxim.uvarov(a)linaro.org> Date: Thu Aug 11 17:14:19 2016 +0300 helper: cuckootable: add missing return codes add missing return codes for non void functions. Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> Reviewed-and-tested-by: Bill Fischofer <bill.fischofer(a)linaro.org> diff --git a/helper/cuckootable.c b/helper/cuckootable.c index 91a73b4..b4fce6c 100644 --- a/helper/cuckootable.c +++ b/helper/cuckootable.c @@ -163,18 +163,19 @@ is_power_of_2(uint32_t n) odph_table_t odph_cuckoo_table_lookup(const char *name) { - odph_cuckoo_table_impl *tbl = NULL; + odph_cuckoo_table_impl *tbl; if (name == NULL || strlen(name) >= ODPH_TABLE_NAME_LEN) return NULL; tbl = (odph_cuckoo_table_impl *)odp_shm_addr(odp_shm_lookup(name)); + if (!tbl || tbl->magicword != ODPH_CUCKOO_TABLE_MAGIC_WORD) + return NULL; - if ( - tbl != NULL && - tbl->magicword == ODPH_CUCKOO_TABLE_MAGIC_WORD && - strcmp(tbl->name, name) == 0) - return (odph_table_t)tbl; + if (strcmp(tbl->name, name)) + return NULL; + + return (odph_table_t)tbl; } odph_table_t @@ -311,6 +312,9 @@ odph_cuckoo_table_destroy(odph_table_t tbl) int ret, i, j; odph_cuckoo_table_impl *impl = NULL; char pool_name[ODPH_TABLE_NAME_LEN + 3]; + odp_event_t ev; + odp_shm_t shm; + odp_pool_t pool; if (tbl == NULL) return -1; @@ -333,8 +337,6 @@ odph_cuckoo_table_destroy(odph_table_t tbl) } /* free all free buffers */ - odp_event_t ev; - while ((ev = odp_queue_deq(impl->free_slots)) != ODP_EVENT_INVALID) { odp_buffer_free(odp_buffer_from_event(ev)); @@ -347,14 +349,26 @@ odph_cuckoo_table_destroy(odph_table_t tbl) /* destroy key-value pool */ snprintf(pool_name, sizeof(pool_name), "kv_%s", impl->name); - ret = odp_pool_destroy(odp_pool_lookup(pool_name)); + pool = odp_pool_lookup(pool_name); + if (pool == ODP_POOL_INVALID) { + ODPH_DBG("invalid pool\n"); + return -1; + } + + ret = odp_pool_destroy(pool); if (ret != 0) { ODPH_DBG("failed to destroy key-value buffer pool\n"); - return ret; + return -1; } /* free impl */ - odp_shm_free(odp_shm_lookup(impl->name)); + shm = odp_shm_lookup(impl->name); + if (shm == ODP_SHM_INVALID) { + ODPH_DBG("unable look up shm\n"); + return -1; + } + + return odp_shm_free(shm); } static uint32_t hash(const odph_cuckoo_table_impl *h, const void *key) ----------------------------------------------------------------------- Summary of changes: helper/cuckootable.c | 36 +++++++++++++++++++++++++----------- 1 file changed, 25 insertions(+), 11 deletions(-) hooks/post-receive --

7 years, 8 months

1
0
0 0

[COMMIT] branch master updated. v1.10.1.0-84-ga5d7ade

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via a5d7adea4b2487b020371ac554935972ec947385 (commit) from 8e9c4fe4ec0611ddde0b027d7c45a1b92d182a0e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a5d7adea4b2487b020371ac554935972ec947385 Author: Barry Spinney <spinney(a)mellanox.com> Date: Wed Aug 10 15:44:35 2016 -0400 linux-generic: tm: made tm thread creation more flexible These changes add a new concept called the tm_system_group. This new entity collects together a set of tm_systems that all share some common resources - eg. share the service thread. Signed-off-by: Barry Spinney <spinney(a)mellanox.com> Reviewed-and-tested-by: Bill Fischofer <bill.fischofer(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/platform/linux-generic/include/odp_traffic_mngr_internal.h b/platform/linux-generic/include/odp_traffic_mngr_internal.h index e4bc5ce..858183b 100644 --- a/platform/linux-generic/include/odp_traffic_mngr_internal.h +++ b/platform/linux-generic/include/odp_traffic_mngr_internal.h @@ -44,6 +44,11 @@ typedef struct stat file_stat_t; /* Macros to convert handles to internal pointers and vice versa. */ +#define MAKE_ODP_TM_SYSTEM_GROUP(tm_group) \ + ((_odp_tm_group_t)(uintptr_t)tm_group) +#define GET_TM_GROUP(odp_tm_group) \ + ((tm_system_group_t *)(uintptr_t)odp_tm_group) + #define MAKE_ODP_TM_HANDLE(tm_system) ((odp_tm_t)(uintptr_t)tm_system) #define GET_TM_SYSTEM(odp_tm) ((tm_system_t *)(uintptr_t)odp_tm) @@ -347,14 +352,25 @@ typedef struct { tm_tos_marking_t ip_tos_marking[ODP_NUM_PACKET_COLORS]; } tm_marking_t; -typedef struct { +typedef struct tm_system_s tm_system_t; +typedef struct tm_system_group_s tm_system_group_t; +typedef uint64_t _odp_tm_group_t; + +struct tm_system_s { + /* The previous and next tm_system in the same tm_system_group. These + * links form a circle and so to round robin amongst the tm_system's + * one just needs to continue to follow next. In the case where the + * tm_system_group only has one tm_system, the prev and next point to + * this single tm_system. */ + tm_system_t *prev; + tm_system_t *next; + _odp_tm_group_t odp_tm_group; + odp_ticketlock_t tm_system_lock; odp_barrier_t tm_system_barrier; odp_barrier_t tm_system_destroy_barrier; odp_atomic_u64_t destroying; _odp_int_name_t name_tbl_id; - pthread_t thread; - pthread_attr_t attr; void *trace_buffer; uint32_t next_queue_num; @@ -389,7 +405,22 @@ typedef struct { uint64_t shaper_green_cnt; uint64_t shaper_yellow_cnt; uint64_t shaper_red_cnt; -} tm_system_t; +}; + +/* A tm_system_group is a set of 1 to N tm_systems that share some processing + * resources - like a bunch of service threads, input queue, timers, etc. + * Currently a tm_system_group only supports a single service thread - and + * while the input work queue is shared - timers are not. */ + +struct tm_system_group_s { + tm_system_group_t *prev; + tm_system_group_t *next; + + tm_system_t *first_tm_system; + uint32_t num_tm_systems; + pthread_t thread; + pthread_attr_t attr; +}; #ifdef __cplusplus } diff --git a/platform/linux-generic/odp_traffic_mngr.c b/platform/linux-generic/odp_traffic_mngr.c index e668bf9..37d3323 100644 --- a/platform/linux-generic/odp_traffic_mngr.c +++ b/platform/linux-generic/odp_traffic_mngr.c @@ -78,11 +78,14 @@ static dynamic_tbl_t odp_tm_profile_tbls[ODP_TM_NUM_PROFILES]; /* TM systems table. */ static tm_system_t *odp_tm_systems[ODP_TM_MAX_NUM_SYSTEMS]; +static tm_system_group_t *tm_group_list; + static odp_ticketlock_t tm_create_lock; static odp_ticketlock_t tm_profile_lock; static odp_barrier_t tm_first_enq; static int g_main_thread_cpu = -1; +static int g_tm_cpu_num; /* Forward function declarations. */ static void tm_queue_cnts_decrement(tm_system_t *tm_system, @@ -2312,6 +2315,7 @@ static void *tm_system_thread(void *arg) { _odp_timer_wheel_t _odp_int_timer_wheel; input_work_queue_t *input_work_queue; + tm_system_group_t *tm_group; tm_system_t *tm_system; uint64_t current_ns; uint32_t destroying, work_queue_cnt, timer_cnt; @@ -2319,7 +2323,9 @@ static void *tm_system_thread(void *arg) rc = odp_init_local(INSTANCE_ID, ODP_THREAD_WORKER); ODP_ASSERT(rc == 0); - tm_system = arg; + tm_group = arg; + + tm_system = tm_group->first_tm_system; _odp_int_timer_wheel = tm_system->_odp_int_timer_wheel; input_work_queue = tm_system->input_work_queue; @@ -2371,6 +2377,11 @@ static void *tm_system_thread(void *arg) tm_system->is_idle = (timer_cnt == 0) && (work_queue_cnt == 0); destroying = odp_atomic_load_u64(&tm_system->destroying); + + /* Advance to the next tm_system in the tm_system_group. */ + tm_system = tm_system->next; + _odp_int_timer_wheel = tm_system->_odp_int_timer_wheel; + input_work_queue = tm_system->input_work_queue; } odp_barrier_wait(&tm_system->tm_system_destroy_barrier); @@ -2558,7 +2569,7 @@ static int affinitize_main_thread(void) static uint32_t tm_thread_cpu_select(void) { odp_cpumask_t odp_cpu_mask; - int cpu_count; + int cpu_count, cpu; odp_cpumask_default_worker(&odp_cpu_mask, 0); if ((g_main_thread_cpu != -1) && @@ -2576,30 +2587,224 @@ static uint32_t tm_thread_cpu_select(void) odp_cpumask_all_available(&odp_cpu_mask); } - return odp_cpumask_first(&odp_cpu_mask); + if (g_tm_cpu_num == 0) { + cpu = odp_cpumask_first(&odp_cpu_mask); + } else { + cpu = odp_cpumask_next(&odp_cpu_mask, g_tm_cpu_num); + if (cpu == -1) { + g_tm_cpu_num = 0; + cpu = odp_cpumask_first(&odp_cpu_mask); + } + } + + g_tm_cpu_num++; + return cpu; } -static int tm_thread_create(tm_system_t *tm_system) +static int tm_thread_create(tm_system_group_t *tm_group) { cpu_set_t cpu_set; uint32_t cpu_num; int rc; - pthread_attr_init(&tm_system->attr); + pthread_attr_init(&tm_group->attr); cpu_num = tm_thread_cpu_select(); CPU_ZERO(&cpu_set); CPU_SET(cpu_num, &cpu_set); - pthread_attr_setaffinity_np(&tm_system->attr, sizeof(cpu_set_t), + pthread_attr_setaffinity_np(&tm_group->attr, sizeof(cpu_set_t), &cpu_set); - rc = pthread_create(&tm_system->thread, &tm_system->attr, - tm_system_thread, tm_system); + rc = pthread_create(&tm_group->thread, &tm_group->attr, + tm_system_thread, tm_group); if (rc != 0) ODP_DBG("Failed to start thread on cpu num=%u\n", cpu_num); return rc; } +static _odp_tm_group_t _odp_tm_group_create(const char *name ODP_UNUSED) +{ + tm_system_group_t *tm_group, *first_tm_group, *second_tm_group; + + tm_group = malloc(sizeof(tm_system_group_t)); + memset(tm_group, 0, sizeof(tm_system_group_t)); + + /* Add this group to the tm_group_list linked list. */ + if (tm_group_list == NULL) { + tm_group_list = tm_group; + tm_group->next = tm_group; + tm_group->prev = tm_group; + } else { + first_tm_group = tm_group_list; + second_tm_group = first_tm_group->next; + first_tm_group->next = tm_group; + second_tm_group->prev = tm_group; + tm_group->next = second_tm_group; + tm_group->prev = first_tm_group; + } + + return MAKE_ODP_TM_SYSTEM_GROUP(tm_group); +} + +static void _odp_tm_group_destroy(_odp_tm_group_t odp_tm_group) +{ + tm_system_group_t *tm_group, *prev_tm_group, *next_tm_group; + int rc; + + tm_group = GET_TM_GROUP(odp_tm_group); + + /* Wait for the thread to exit. */ + ODP_ASSERT(tm_group->num_tm_systems <= 1); + rc = pthread_join(tm_group->thread, NULL); + ODP_ASSERT(rc == 0); + pthread_attr_destroy(&tm_group->attr); + if (g_tm_cpu_num > 0) + g_tm_cpu_num--; + + /* Remove this group from the tm_group_list linked list. Special case + * when this is the last tm_group in the linked list. */ + prev_tm_group = tm_group->prev; + next_tm_group = tm_group->next; + if (prev_tm_group == next_tm_group) { + ODP_ASSERT(tm_group_list == tm_group); + tm_group_list = NULL; + } else { + prev_tm_group->next = next_tm_group; + next_tm_group->prev = prev_tm_group; + if (tm_group_list == tm_group) + tm_group_list = next_tm_group; + } + + tm_group->prev = NULL; + tm_group->next = NULL; + free(tm_group); +} + +static int _odp_tm_group_add(_odp_tm_group_t odp_tm_group, odp_tm_t odp_tm) +{ + tm_system_group_t *tm_group; + tm_system_t *tm_system, *first_tm_system, *second_tm_system; + + tm_group = GET_TM_GROUP(odp_tm_group); + tm_system = GET_TM_SYSTEM(odp_tm); + tm_group->num_tm_systems++; + tm_system->odp_tm_group = odp_tm_group; + + /* Link this tm_system into the circular linked list of all tm_systems + * belonging to the same tm_group. */ + if (tm_group->num_tm_systems == 1) { + tm_group->first_tm_system = tm_system; + tm_system->next = tm_system; + tm_system->prev = tm_system; + } else { + first_tm_system = tm_group->first_tm_system; + second_tm_system = first_tm_system->next; + first_tm_system->next = tm_system; + second_tm_system->prev = tm_system; + tm_system->prev = first_tm_system; + tm_system->next = second_tm_system; + tm_group->first_tm_system = tm_system; + } + + /* If this is the first tm_system associated with this group, then + * create the service thread and the input work queue. */ + if (tm_group->num_tm_systems >= 2) + return 0; + + affinitize_main_thread(); + return tm_thread_create(tm_group); +} + +static int _odp_tm_group_remove(_odp_tm_group_t odp_tm_group, odp_tm_t odp_tm) +{ + tm_system_group_t *tm_group; + tm_system_t *tm_system, *prev_tm_system, *next_tm_system; + + tm_group = GET_TM_GROUP(odp_tm_group); + tm_system = GET_TM_SYSTEM(odp_tm); + if (tm_system->odp_tm_group != odp_tm_group) + return -1; + + if ((tm_group->num_tm_systems == 0) || + (tm_group->first_tm_system == NULL)) + return -1; + + /* Remove this tm_system from the tm_group linked list. */ + if (tm_group->first_tm_system == tm_system) + tm_group->first_tm_system = tm_system->next; + + prev_tm_system = tm_system->prev; + next_tm_system = tm_system->next; + prev_tm_system->next = next_tm_system; + next_tm_system->prev = prev_tm_system; + tm_system->next = NULL; + tm_system->prev = NULL; + tm_group->num_tm_systems--; + + /* If this is the last tm_system associated with this group then + * destroy the group (and thread etc). */ + if (tm_group->num_tm_systems == 0) + _odp_tm_group_destroy(odp_tm_group); + + return 0; +} + +static int tm_group_attach(odp_tm_t odp_tm) +{ + tm_system_group_t *tm_group, *min_tm_group; + _odp_tm_group_t odp_tm_group; + odp_cpumask_t all_cpus, worker_cpus; + uint32_t total_cpus, avail_cpus; + + /* If this platform has a small number of cpu's then allocate one + * tm_group and assign all tm_system's to this tm_group. Otherwise in + * the case of a manycore platform try to allocate one tm_group per + * tm_system, as long as there are still extra cpu's left. If not + * enough cpu's left than allocate this tm_system to the next tm_group + * in a round robin fashion. */ + odp_cpumask_all_available(&all_cpus); + odp_cpumask_default_worker(&worker_cpus, 0); + total_cpus = odp_cpumask_count(&all_cpus); + avail_cpus = odp_cpumask_count(&worker_cpus); + + if (total_cpus < 24) { + tm_group = tm_group_list; + odp_tm_group = MAKE_ODP_TM_SYSTEM_GROUP(tm_group); + if (tm_group == NULL) + odp_tm_group = _odp_tm_group_create(""); + + _odp_tm_group_add(odp_tm_group, odp_tm); + return 0; + } + + /* Manycore case. */ + if ((tm_group_list == NULL) || (avail_cpus > 1)) { + odp_tm_group = _odp_tm_group_create(""); + _odp_tm_group_add(odp_tm_group, odp_tm); + return 0; + } + + /* Pick a tm_group according to the smallest number of tm_systems. */ + tm_group = tm_group_list; + min_tm_group = NULL; + while (tm_group != NULL) { + if (min_tm_group == NULL) + min_tm_group = tm_group; + else if (tm_group->num_tm_systems < + min_tm_group->num_tm_systems) + min_tm_group = tm_group; + + tm_group = tm_group->next; + } + + if (min_tm_group == NULL) + return -1; + + odp_tm_group = MAKE_ODP_TM_SYSTEM_GROUP(tm_group); + _odp_tm_group_add(odp_tm_group, odp_tm); + return 0; +} + odp_tm_t odp_tm_create(const char *name, odp_tm_requirements_t *requirements, odp_tm_egress_t *egress) @@ -2693,8 +2898,9 @@ odp_tm_t odp_tm_create(const char *name, } if (create_fail == 0) { + /* Pass any odp_groups or hints to tm_group_attach here. */ affinitize_main_thread(); - rc = tm_thread_create(tm_system); + rc = tm_group_attach(odp_tm); create_fail |= rc < 0; } @@ -2754,7 +2960,6 @@ int odp_tm_capability(odp_tm_t odp_tm, odp_tm_capabilities_t *capabilities) int odp_tm_destroy(odp_tm_t odp_tm) { tm_system_t *tm_system; - int rc; tm_system = GET_TM_SYSTEM(odp_tm); @@ -2765,10 +2970,10 @@ int odp_tm_destroy(odp_tm_t odp_tm) odp_atomic_inc_u64(&tm_system->destroying); odp_barrier_wait(&tm_system->tm_system_destroy_barrier); - /* Next wait for the thread to exit. */ - rc = pthread_join(tm_system->thread, NULL); - ODP_ASSERT(rc == 0); - pthread_attr_destroy(&tm_system->attr); + /* Remove ourselves from the group. If we are the last tm_system in + * this group, odp_tm_group_remove will destroy any service threads + * allocated by this group. */ + _odp_tm_group_remove(tm_system->odp_tm_group, odp_tm); input_work_queue_destroy(tm_system->input_work_queue); _odp_sorted_pool_destroy(tm_system->_odp_int_sorted_pool); ----------------------------------------------------------------------- Summary of changes: .../include/odp_traffic_mngr_internal.h | 39 +++- platform/linux-generic/odp_traffic_mngr.c | 233 +++++++++++++++++++-- 2 files changed, 254 insertions(+), 18 deletions(-) hooks/post-receive --

7 years, 8 months

1
0
0 0

[COMMIT] branch master updated. v1.10.1.0-83-g8e9c4fe

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via 8e9c4fe4ec0611ddde0b027d7c45a1b92d182a0e (commit) from 5d4f6cbd12a7f079917bc5ad18b710b3e34485b1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8e9c4fe4ec0611ddde0b027d7c45a1b92d182a0e Author: Bill Fischofer <bill.fischofer(a)linaro.org> Date: Tue Aug 9 18:56:42 2016 -0500 doc: release-guide: elaborate release naming scheme Add additional detail and examples to the description of the release naming scheme used by ODP, detailing the expected impact to ODP applications and/or other ODP implementations for each change. Signed-off-by: Bill Fischofer <bill.fischofer(a)linaro.org> Reviewed-by: Petri Savolainen <petri.savolainen(a)nokia.com> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/doc/process-guide/release-guide.adoc b/doc/process-guide/release-guide.adoc index 8816c03..788eb6b 100644 --- a/doc/process-guide/release-guide.adoc +++ b/doc/process-guide/release-guide.adoc @@ -116,28 +116,82 @@ atomically as possible * the maintainer tags the master branch == Releases == -All releases are from master. - -They are tagged in the repository using the format -v<Generation>.<Major>.<Minor>.<Impl> -There are three release types with differing frequencies and impact to the -applications. +All releases are from a tag in the master branch of the ODP git +repository. Recall that ODP consists of three separate components: + +* An API Specification +* Multiple independently owned and maintained _implementations_ of the ODP API +* A Validation Test Suite that tests implementation conformance to the ODP API + +Included with the main ODP git repository is the `odp-linux` reference +implementation of the ODP API, and it also has an associated service stream +that is independent of all other ODP implementations. This means that the ODP +release naming conventions address the needs of all three of these components, +which is accomplished via a multi-level structure using the format: + +*v<Generation>.<Major>.<Minor>.<Point>* + +This is used as the tag from which all ODP releases are published and is also +used as the release identifier in the CHANGELOG for each release. The first +three of these digits represent the ODP API level, and these reflect three +types of API changes with differing frequencies and impact to applications and +other ODP implementations. A fourth digit is used to reflect changes to other +items included within the ODP git repository. In addition, each individual ODP +implementation will have its own service stream identifier that is defined +using whatever conventions meet its needs. === Generation releases === A generation release indicates a major completion of work, and a possible -change in direction for the API. Same as for Major release plus they are -defined by the Steering committee. +change in direction for the API. Generation release changes are approved by the +LNG Steering Committee, which is the governing body for ODP. === Major releases === -Major (API) releases are scheduled to be about once a -quarter, but when there is significant progress made they may be more frequent. +Major (API) releases are used when new APIs or capabilities are introduced or +changes are made to existing APIs that are not backwards-compatible. Major +release changes thus potentially affect ODP applications as well as +implementations. + +=== Minor releases === +Minor (API) releases are used when new APIs or capabilities are introduced or +changes are made to existing APIs in a backwards-compatible manner. Examples +of these might be wording changes in API documentation, or introducing new +APIs that are orthogonal to the existing set of APIs and hence have no impact +on existing applications that do not make use of them. Minor release changes +should therefore have no impact on existing ODP applications but will have +impact for ODP implementations that need to support these API additions and +changes. + +NOTE: The first three digits of the release name are the API version returned +by the `odp_version_api_str()` API. === Point releases === -General bug fixes and other non API altering changes are gathered and a release -made every month if sufficient change has accumulated. - -=== Implementation (Impl) === -Platform specific free form text relating to the version. +General bug fixes and other non API altering changes are gathered and a +release made every month if sufficient change has accumulated. Examples of a +point release would be additional documentation, extensions or corrections to +the validation test suite, additions or corrections to helpers, example +programs, etc. No API changes are permitted in a point release, so ODP +applications are not impacted. Other ODP implementations _may_ be impacted +if, for example, a bug is fixed in a validation test that results in a latent +bug in other implementations being exposed. + +=== Implementation Service Strings === +Beyond the four-digit release name, platform specific free form text is used +to capture the service level of each ODP implementation. This field is for the +sole use of implementations to represent their individual service streams. Its +format may vary between implementations. For example, the `odp-linux` +reference implementation uses a simple incrementing digit (0, 1, 2, +etc.). Other implementations may use `Build xxxx` or something similar. +Changes in this designator have no impact on and may be ignored by other ODP +implementations. The only changes that ODP applications should see is +corrected functional or performance behavior when running on that specific ODP +implementation. + +NOTE: The full four-digit release name plus implementation service string as +well as other platform-specific identification information is returned by the +`odp_version_impl_str()` API. This may be useful, for example, in logging an +error to include in a bug report to the vendor that owns and supports this ODP +implementation. The release-independent name of a given implementation (for +identification purposed) is supplied by the `odp_version_impl_name()` API. == Deprecating part of the API Deleting or changing the published API follows the normal <<anchor-1,process>>, with the following additional rules: ----------------------------------------------------------------------- Summary of changes: doc/process-guide/release-guide.adoc | 84 +++++++++++++++++++++++++++++------- 1 file changed, 69 insertions(+), 15 deletions(-) hooks/post-receive --

7 years, 8 months

1
0
0 0

[COMMIT] branch master updated. v1.10.1.0-82-g5d4f6cb

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via 5d4f6cbd12a7f079917bc5ad18b710b3e34485b1 (commit) from 26b90314427f088c7f7e2accd41ec7db5d396265 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5d4f6cbd12a7f079917bc5ad18b710b3e34485b1 Author: Mike Holmes <mike.holmes(a)linaro.org> Date: Thu Aug 4 09:18:14 2016 -0400 test:linux-generic: run odp_scheduling in process mode Set up the environment to allow calling the performance tests in process mode as part of make check when enabled. To run the tests use --enable-test-perf-proc Initial patch using odp_scheduling as a proof Signed-off-by: Mike Holmes <mike.holmes(a)linaro.org> Reviewed-by: Brian Brooks <brian.brooks(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/configure.ac b/configure.ac index c0f0f21..6551287 100644 --- a/configure.ac +++ b/configure.ac @@ -169,6 +169,7 @@ AM_CONDITIONAL([test_installdir], [test "$testdir" != ""]) AM_CONDITIONAL([cunit_support], [test x$cunit_support = xyes ]) AM_CONDITIONAL([test_vald], [test x$test_vald = xyes ]) AM_CONDITIONAL([test_perf], [test x$test_perf = xyes ]) +AM_CONDITIONAL([test_perf_proc], [test x$test_perf_proc = xyes ]) AM_CONDITIONAL([test_cpp], [test x$test_cpp = xyes ]) AM_CONDITIONAL([test_helper], [test x$test_helper = xyes ]) AM_CONDITIONAL([test_example], [test x$test_example = xyes ]) @@ -302,6 +303,7 @@ AC_MSG_RESULT([ cunit: ${cunit_support} test_vald: ${test_vald} test_perf: ${test_perf} + test_perf_proc: ${test_perf_proc} test_cpp: ${test_cpp} test_helper: ${test_helper} test_example: ${test_example} diff --git a/test/linux-generic/Makefile.am b/test/linux-generic/Makefile.am index f5cc52d..4660cf0 100644 --- a/test/linux-generic/Makefile.am +++ b/test/linux-generic/Makefile.am @@ -3,7 +3,7 @@ TESTS_ENVIRONMENT += TEST_DIR=${top_builddir}/test/common_plat/validation ALL_API_VALIDATION_DIR = ${top_builddir}/test/common_plat/validation/api -SUBDIRS = +SUBDIRS = performance if test_vald TESTS = validation/api/pktio/pktio_run.sh \ diff --git a/test/linux-generic/m4/configure.m4 b/test/linux-generic/m4/configure.m4 index 9eec545..6b92201 100644 --- a/test/linux-generic/m4/configure.m4 +++ b/test/linux-generic/m4/configure.m4 @@ -1,5 +1,8 @@ +m4_include([test/linux-generic/m4/performance.m4]) + AC_CONFIG_FILES([test/linux-generic/Makefile test/linux-generic/validation/api/shmem/Makefile test/linux-generic/validation/api/pktio/Makefile test/linux-generic/pktio_ipc/Makefile - test/linux-generic/ring/Makefile]) + test/linux-generic/ring/Makefile + test/linux-generic/performance/Makefile]) diff --git a/test/linux-generic/m4/performance.m4 b/test/linux-generic/m4/performance.m4 new file mode 100644 index 0000000..7f54b96 --- /dev/null +++ b/test/linux-generic/m4/performance.m4 @@ -0,0 +1,9 @@ +########################################################################## +# Enable/disable test-perf-proc +########################################################################## +test_perf_proc=no +AC_ARG_ENABLE([test-perf-proc], + [ --enable-test-perf-proc run test in test/performance in process mode], + [if test "x$enableval" = "xyes"; then + test_perf_proc=yes + fi]) diff --git a/test/linux-generic/performance/.gitignore b/test/linux-generic/performance/.gitignore new file mode 100644 index 0000000..7e563b8 --- /dev/null +++ b/test/linux-generic/performance/.gitignore @@ -0,0 +1,2 @@ +*.log +*.trs diff --git a/test/linux-generic/performance/Makefile.am b/test/linux-generic/performance/Makefile.am new file mode 100644 index 0000000..cb72fce --- /dev/null +++ b/test/linux-generic/performance/Makefile.am @@ -0,0 +1,13 @@ +include $(top_srcdir)/test/Makefile.inc + +TESTS_ENVIRONMENT += TEST_DIR=${builddir} + +TESTSCRIPTS = odp_scheduling_run_proc.sh + +TEST_EXTENSIONS = .sh + +if test_perf_proc +TESTS = $(TESTSCRIPTS) +endif + +EXTRA_DIST = $(TESTSCRIPTS) diff --git a/test/linux-generic/performance/odp_scheduling_run_proc.sh b/test/linux-generic/performance/odp_scheduling_run_proc.sh new file mode 100755 index 0000000..b3ef26f --- /dev/null +++ b/test/linux-generic/performance/odp_scheduling_run_proc.sh @@ -0,0 +1,26 @@ +#!/bin/sh +# +# Copyright (c) 2016, Linaro Limited +# All rights reserved. +# +# SPDX-License-Identifier: BSD-3-Clause +# +# Script that passes command line arguments to odp_scheduling test when +# launched by 'make check' + +TEST_DIR="${TEST_DIR:-$(dirname $0)}" +PERFORMANCE="$TEST_DIR/../../common_plat/performance" +ret=0 + +run() +{ + echo odp_scheduling_run_proc starts with $1 worker threads + echo ===================================================== + + $PERFORMANCE/odp_scheduling${EXEEXT} --odph_proc -c $1 || ret=1 +} + +run 1 +run 8 + +exit $ret ----------------------------------------------------------------------- Summary of changes: configure.ac | 2 ++ test/linux-generic/Makefile.am | 2 +- test/linux-generic/m4/configure.m4 | 5 ++++- .../m4/performance.m4 | 10 ++++----- .../api => linux-generic/performance}/.gitignore | 0 test/linux-generic/performance/Makefile.am | 13 +++++++++++ .../performance/odp_scheduling_run_proc.sh | 26 ++++++++++++++++++++++ 7 files changed, 51 insertions(+), 7 deletions(-) copy test/{common_plat => linux-generic}/m4/performance.m4 (51%) copy test/{common_plat/validation/api => linux-generic/performance}/.gitignore (100%) create mode 100644 test/linux-generic/performance/Makefile.am create mode 100755 test/linux-generic/performance/odp_scheduling_run_proc.sh hooks/post-receive --

7 years, 8 months

1
0
0 0

[COMMIT] branch master updated. v1.10.1.0-81-g26b9031

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via 26b90314427f088c7f7e2accd41ec7db5d396265 (commit) from e072ea084a27df729d1b94c0bec2d45fb1e4d26f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 26b90314427f088c7f7e2accd41ec7db5d396265 Author: Maxim Uvarov <maxim.uvarov(a)linaro.org> Date: Mon Aug 8 11:40:29 2016 +0300 linux-gen: do not init scheduler context on termination We should not try to redifine current odp thread id on termination as well as set poll queues to invalid values, which has to be cleared later in schedule_term_global(). Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> Reviewed-and-tested-by: Bill Fischofer <bill.fischofer(a)linaro.org> diff --git a/platform/linux-generic/odp_schedule.c b/platform/linux-generic/odp_schedule.c index 8765f48..8405423 100644 --- a/platform/linux-generic/odp_schedule.c +++ b/platform/linux-generic/odp_schedule.c @@ -328,8 +328,6 @@ static int schedule_term_local(void) } schedule_release_context(); - - sched_local_init(); return 0; } ----------------------------------------------------------------------- Summary of changes: platform/linux-generic/odp_schedule.c | 2 -- 1 file changed, 2 deletions(-) hooks/post-receive --

7 years, 8 months

1
0
0 0

[COMMIT] branch api-next updated. v1.10.1.0-131-g179074e

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, api-next has been updated via 179074e0d0771c82d064e29a20531b75d17289d7 (commit) from 32e95a4ed19e5cd567d02125c4b74bb6e41ee197 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 179074e0d0771c82d064e29a20531b75d17289d7 Author: Bill Fischofer <bill.fischofer(a)linaro.org> Date: Tue Jul 12 21:27:05 2016 -0500 api: byteorder: avoid bitfield order doxygen omissions Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2402 by assigning explicit values to ODP_LITTLE_ENDIAN_BITFIELD and ODP_BIT_ENDIAN_BITFIELD to avoid Doxygen warnings. This makes these consistent with the usage for ODP_BIG_ENDIAN and ODP_LITTLE_ENDIAN. Also define the summary variable ODP_BITFIELD_ORDER which can be used similar to ODP_BYTE_ORDER for an explicit test of bitfield endianness. Note that this requires tests of these fields to change from #ifdef to #if. Signed-off-by: Bill Fischofer <bill.fischofer(a)linaro.org> Reviewed-by: Petri Savolainen <petri.savolainen(a)nokia.com> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/helper/include/odp/helper/tcp.h b/helper/include/odp/helper/tcp.h index cabef90..fd234e5 100644 --- a/helper/include/odp/helper/tcp.h +++ b/helper/include/odp/helper/tcp.h @@ -34,7 +34,7 @@ typedef struct ODP_PACKED { odp_u32be_t ack_no; /**< Acknowledgment number */ union { odp_u16be_t doffset_flags; -#if defined(ODP_BIG_ENDIAN_BITFIELD) +#if ODP_BIG_ENDIAN_BITFIELD struct { odp_u16be_t rsvd1:8; odp_u16be_t flags:8; /**< TCP flags as a byte */ @@ -51,7 +51,7 @@ typedef struct ODP_PACKED { odp_u16be_t syn:1; odp_u16be_t fin:1; }; -#elif defined(ODP_LITTLE_ENDIAN_BITFIELD) +#elif ODP_LITTLE_ENDIAN_BITFIELD struct { odp_u16be_t flags:8; odp_u16be_t rsvd1:8; /**< TCP flags as a byte */ diff --git a/include/odp/api/spec/byteorder.h b/include/odp/api/spec/byteorder.h index 6b18eb3..38c0bdb 100644 --- a/include/odp/api/spec/byteorder.h +++ b/include/odp/api/spec/byteorder.h @@ -38,6 +38,9 @@ extern "C" { * * @def ODP_BYTE_ORDER * Selected byte order + * + * @def ODP_BITFIELD_ORDER + * Selected bitfield order */ /** diff --git a/platform/linux-generic/include/odp/api/plat/byteorder_types.h b/platform/linux-generic/include/odp/api/plat/byteorder_types.h index d4bf3d6..20d52bf 100644 --- a/platform/linux-generic/include/odp/api/plat/byteorder_types.h +++ b/platform/linux-generic/include/odp/api/plat/byteorder_types.h @@ -49,12 +49,16 @@ extern "C" { #define ODP_LITTLE_ENDIAN 1 #define ODP_BIG_ENDIAN 0 #define ODP_BYTE_ORDER ODP_LITTLE_ENDIAN - #define ODP_LITTLE_ENDIAN_BITFIELD + #define ODP_LITTLE_ENDIAN_BITFIELD 1 + #define ODP_BIG_ENDIAN_BITFIELD 0 + #define ODP_BITFIELD_ORDER ODP_LITTLE_ENDIAN_BITFIELD #else #define ODP_LITTLE_ENDIAN 0 #define ODP_BIG_ENDIAN 1 #define ODP_BYTE_ORDER ODP_BIG_ENDIAN - #define ODP_BIG_ENDIAN_BITFIELD + #define ODP_LITTLE_ENDIAN_BITFIELD 0 + #define ODP_BIG_ENDIAN_BITFIELD 1 + #define ODP_BITFIELD_ORDER ODP_BIG_ENDIAN_BITFIELD #endif typedef uint16_t __odp_bitwise odp_u16le_t; diff --git a/platform/linux-generic/include/protocols/tcp.h b/platform/linux-generic/include/protocols/tcp.h index 4e92e4b..114262e 100644 --- a/platform/linux-generic/include/protocols/tcp.h +++ b/platform/linux-generic/include/protocols/tcp.h @@ -34,7 +34,7 @@ typedef struct ODP_PACKED { odp_u32be_t ack_no; /**< Acknowledgment number */ union { odp_u16be_t doffset_flags; -#if defined(ODP_BIG_ENDIAN_BITFIELD) +#if ODP_BIG_ENDIAN_BITFIELD struct { odp_u16be_t rsvd1:8; odp_u16be_t flags:8; /**< TCP flags as a byte */ @@ -51,7 +51,7 @@ typedef struct ODP_PACKED { odp_u16be_t syn:1; odp_u16be_t fin:1; }; -#elif defined(ODP_LITTLE_ENDIAN_BITFIELD) +#elif ODP_LITTLE_ENDIAN_BITFIELD struct { odp_u16be_t flags:8; odp_u16be_t rsvd1:8; /**< TCP flags as a byte */ ----------------------------------------------------------------------- Summary of changes: helper/include/odp/helper/tcp.h | 4 ++-- include/odp/api/spec/byteorder.h | 3 +++ platform/linux-generic/include/odp/api/plat/byteorder_types.h | 8 ++++++-- platform/linux-generic/include/protocols/tcp.h | 4 ++-- 4 files changed, 13 insertions(+), 6 deletions(-) hooks/post-receive --

7 years, 8 months

1
0
0 0

[COMMIT] branch api-next updated. v1.10.1.0-130-g32e95a4

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, api-next has been updated via 32e95a4ed19e5cd567d02125c4b74bb6e41ee197 (commit) from b9995659aabf9a20cae2ae6905b84c94b733636c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 32e95a4ed19e5cd567d02125c4b74bb6e41ee197 Author: Christophe Milard <christophe.milard(a)linaro.org> Date: Thu Aug 4 07:52:32 2016 +0000 linux-gen: drv: byteorder: fixed macro typo Signed-off-by: Christophe Milard <christophe.milard(a)linaro.org> Reviewed-by: Mike Holmes <mike.holmes(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/platform/linux-generic/include/odp/drv/plat/byteorder_types.h b/platform/linux-generic/include/odp/drv/plat/byteorder_types.h index bf461e5..cb7aec2 100644 --- a/platform/linux-generic/include/odp/drv/plat/byteorder_types.h +++ b/platform/linux-generic/include/odp/drv/plat/byteorder_types.h @@ -48,7 +48,7 @@ extern "C" { #if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ #define ODPDRV_LITTLE_ENDIAN 1 #define ODPDRV_BIG_ENDIAN 0 - #define ODPDRV_BYTE_ORDER ODP_LITTLE_ENDIAN + #define ODPDRV_BYTE_ORDER ODPDRV_LITTLE_ENDIAN #define ODPDRV_LITTLE_ENDIAN_BITFIELD #else #define ODPDRV_LITTLE_ENDIAN 0 ----------------------------------------------------------------------- Summary of changes: platform/linux-generic/include/odp/drv/plat/byteorder_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive --

7 years, 8 months

1
0
0 0

[COMMIT] branch master updated. v1.10.1.0-80-ge072ea0

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via e072ea084a27df729d1b94c0bec2d45fb1e4d26f (commit) from 3eb700768b6369e674e5d5a9758eb39f8fd34c3d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e072ea084a27df729d1b94c0bec2d45fb1e4d26f Author: Mike Holmes <mike.holmes(a)linaro.org> Date: Fri Aug 5 11:37:11 2016 -0400 doc: implimenters: fix spelling Signed-off-by: Mike Holmes <mike.holmes(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/doc/implementers-guide/implementers-guide.adoc b/doc/implementers-guide/implementers-guide.adoc index 5c0e864..0e2edc0 100644 --- a/doc/implementers-guide/implementers-guide.adoc +++ b/doc/implementers-guide/implementers-guide.adoc @@ -29,7 +29,7 @@ mapping of the ODP APIs to a specific target platform. This is the focus of this document. - A Validation Test Suite. This is an independent set of routines that when -run against an ODP implmenetation verifies that it correctly implements all of +run against an ODP implementation verifies that it correctly implements all of the defined ODP APIs at a functional level. The test suite is used by implementers to self-certify their ODP implementation as well as by third-parties to verify an implementation's claim to be ODP API compliant. @@ -39,18 +39,18 @@ fully defined in the _ODP User's Guide_ === Organization of this Document This document is designed to serve two purposes. Its larger purpose is to -provide guidenace and practical advice for those wishing to implement ODP on +provide guidance and practical advice for those wishing to implement ODP on their platform. To help with this, as well as to provide deeper insight into how to think about ODP from an implementer's standpoint, this document also discusses in some depth the design and organization of a specific ODP implementation: the odp-linux reference implementation distributed as part of the main ODP git repository. By grounding theory in practice and discussing a particular example implementation, it is hoped this will provide insight into -the tradeoffs implementers should consider in approaching how to best implement +the trade-offs implementers should consider in approaching how to best implement ODP on their platforms. The section <<include_structure>> discusses the layout of the ODP include tree -from an implementer's perspective. Although implementers have wide lattitude +from an implementer's perspective. Although implementers have wide latitude in how they organize their ODP implementations, it is recommended that this layout be be observed by other implementations. Doing so both simplifies code sharing with the odp-linux reference implementation and also ensure ease of @@ -637,7 +637,7 @@ It is recommended that however a platform wishes to represent ODP abstract types, that it do so in a strongly typed manner. Using strong types means that an application that tries to pass a variable of type `odp_packet_t` to an API that expects an argument of type `odp_queue_t`, for example, will result -in a compililation error rather than some difficult to debug runtime failure. +in a compilation error rather than some difficult to debug runtime failure. The *odp-linux* reference implementation defines all ODP abstract types strongly using a set of utility macros contained in @@ -653,13 +653,13 @@ implementations choose typdefs and representations that permit the implementation to realize ODP APIs efficiently. This typically means that the handles defined by typedefs are either a pointer to an implementation-defined struct or else an index into an implementation-defined resource table. The two -LNG-provided ODP reference implemnetations illustrate both of these approaches. +LNG-provided ODP reference implementations illustrate both of these approaches. The *odp-dpdk* implementation follows the former approach (pointers) as this offers the highest performance. For example, in *odp-dpdk* an `odp_packet_t` is a pointer to an `rte_mbuf` struct, which is how DPDK represents packets. The *odp-linux* implementation, by contrast, uses indices as this permits more robust validation support while still being highly -efficient. In general, software-based implemnetations will typically favor +efficient. In general, software-based implementations will typically favor pointers while hardware-based implementations will typically favor indices. === ABI Considerations @@ -670,13 +670,13 @@ portability guarantees provided by APIs to permit binary portability as well. It is important to note that ODP neither defines nor prohibits the specification of ABIs. This is because ODP itself is an _Abstract API Specification_. As -noted earlier, abstract APIs cannot be compiled in the absense of completion +noted earlier, abstract APIs cannot be compiled in the absence of completion by an implementation that instantiates them, so the question of ABIs is really a question of representation agreement between multiple ODP implementations. If two or more ODP implementations agree on things like typedefs, endianness, alignments, etc., then they are defining an ABI which -would permit ODP applications compiled to that common set of instantations -to interoperate at a binary as well as source level. +would permit ODP applications compiled to that common set of instantiations +to inter operate at a binary as well as source level. ==== Traditional ABI ABIs can be defined at two levels. The simplest ABI is within a specific @@ -692,7 +692,7 @@ of typedefs, etc. so that the resulting output from compilation is directly executable on any platform that subscribes to that ABI. Adding a new platform in this approach simply requires that platform to accept the existing ABI specification. Note that since the output of compilation in a traditional ABI -is a ISA-specific binary that applications cannot offer binary compability +is a ISA-specific binary that applications cannot offer binary compatibility across platforms that use different ISAs. ==== Bitcode based ABI @@ -716,9 +716,9 @@ library system selects the appropriate managed binary for that target platform and loads and runs it. Adding a new platform in this approach involves adding the definition for that -platform to the libary system so that a managed binary for it can be created +platform to the library system so that a managed binary for it can be created and deployed as needed. This occurs without developer involvement since the -bitcode format that is input to this backend process is indepentent of the +bitcode format that is input to this backend process is independent of the specific target platform. Note also that since bitcode is not tied to any ISA, applications using bitcode ABIs are binary portable between platforms that use different ISAs. This occurs without loss of efficiency because the process of ----------------------------------------------------------------------- Summary of changes: doc/implementers-guide/implementers-guide.adoc | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) hooks/post-receive --

7 years, 9 months

1
0
0 0

[COMMIT] branch master updated. v1.10.1.0-79-g3eb7007

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via 3eb700768b6369e674e5d5a9758eb39f8fd34c3d (commit) from c05c1c608c6dbc367ebb9a819fa4cbbbca882db3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3eb700768b6369e674e5d5a9758eb39f8fd34c3d Author: Bill Fischofer <bill.fischofer(a)linaro.org> Date: Wed Aug 3 21:06:05 2016 +0000 validation: tm: use strncmp() to avoid potential string overrun Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2426 by switching from strcmp() to strncmp() Signed-off-by: Bill Fischofer <bill.fischofer(a)linaro.org> Reviewed-by: Mike Holmes <mike.holmes(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/test/common_plat/validation/api/traffic_mngr/traffic_mngr.c b/test/common_plat/validation/api/traffic_mngr/traffic_mngr.c index b857800..c7bde40 100644 --- a/test/common_plat/validation/api/traffic_mngr/traffic_mngr.c +++ b/test/common_plat/validation/api/traffic_mngr/traffic_mngr.c @@ -1507,7 +1507,7 @@ static tm_node_desc_t *find_node_desc(uint8_t tm_system_idx, name_ptr++; while (node_desc != NULL) { - if (strcmp(node_desc->node_name, node_name) == 0) + if (strncmp(node_desc->node_name, node_name, TM_NAME_LEN) == 0) return node_desc; if (name_ptr == NULL) ----------------------------------------------------------------------- Summary of changes: test/common_plat/validation/api/traffic_mngr/traffic_mngr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive --

7 years, 9 months

1
0
0 0

[COMMIT] branch master updated. v1.10.1.0-78-gc05c1c6

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via c05c1c608c6dbc367ebb9a819fa4cbbbca882db3 (commit) from ca927a72b1f9ea2a583e8a628790d62eb93d430f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c05c1c608c6dbc367ebb9a819fa4cbbbca882db3 Author: Christophe Milard <christophe.milard(a)linaro.org> Date: Fri Jul 22 14:51:53 2016 +0200 test: update in readme file mostly updating paths following new test structure Signed-off-by: Christophe Milard <christophe.milard(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/test/README b/test/README index 857c366..f4886d3 100644 --- a/test/README +++ b/test/README @@ -3,14 +3,15 @@ All rights reserved. SPDX-License-Identifier: BSD-3-Clause -Files in test/validation directory are intended to be terse checks that help -ensure that the ODP API Implementations all perform identically and to -specification. Tests inside the validation directory shall be platform +Files in test/common_plat/validation directory are intended to be terse +checks that help ensure that the ODP implementations all perform identically +and to specification. Tests inside the validation directory shall be platform independent. To run valgrind on the executables do: $ ./bootstrap $ ./configure --enable-test-vald --enable-valgrind -$ cd test/validation +$ make +$ cd test/<platform_name> $ make check-valgrind ----------------------------------------------------------------------- Summary of changes: test/README | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) hooks/post-receive --

7 years, 9 months

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

git-lng-odp August 2016